Skip to content

ARROW-13003: [C++] Fix key map unaligned access - #10489

Closed
cyb70289 wants to merge 1 commit into
apache:masterfrom
cyb70289:13003-unaligned-access
Closed

ARROW-13003: [C++] Fix key map unaligned access#10489
cyb70289 wants to merge 1 commit into
apache:masterfrom
cyb70289:13003-unaligned-access

Conversation

@cyb70289

@cyb70289cyb70289 commented Jun 9, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@cyb70289
cyb70289 marked this pull request as draft June 9, 2021 08:10
@cyb70289

cyb70289 commented Jun 9, 2021

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

@github-actions

github-actionsBot commented Jun 9, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13003

@github-actions

github-actionsBot commented Jun 9, 2021

Copy link
Copy Markdown

Revision: 7c073cd613d0918bd4b33c077368839278096b98

Submitted crossbow builds: ursacomputing/crossbow @ actions-490

TaskStatus
test-ubuntu-18.04-r-sanitizerAzure

@cyb70289cyb70289 changed the title ARROW-13003: [C++] Fix key map unaligned access[WIP] ARROW-13003: [C++] Fix key map unaligned accessJun 9, 2021
@cyb70289

cyb70289 commented Jun 9, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@github-actions crossbow submit test-ubuntu-18.04-r-sanitizer

@github-actions

github-actionsBot commented Jun 9, 2021

Copy link
Copy Markdown

Revision: 7c073cd613d0918bd4b33c077368839278096b98

Submitted crossbow builds: ursacomputing/crossbow @ actions-491

TaskStatus
test-ubuntu-18.04-r-sanitizerAzure

@cyb70289cyb70289 changed the title [WIP] ARROW-13003: [C++] Fix key map unaligned accessARROW-13003: [C++] Fix key map unaligned accessJun 9, 2021
@cyb70289
cyb70289 marked this pull request as ready for review June 9, 2021 14:13
@cyb70289

cyb70289 commented Jun 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Error logs without this PR:
https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=6217&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=842

@cyb70289
cyb70289 requested a review from pitrouJune 9, 2021 14:22
@pitrou
pitrou requested a review from bkietzJune 9, 2021 17:48
@pitrou

pitrou commented Jun 15, 2021

Copy link
Copy Markdown
Member

Rebased.

@pitrou

pitrou commented Jun 15, 2021

Copy link
Copy Markdown
Member

@ursabot please benchmark

@ursabot

ursabot commented Jun 15, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 4b3f6c3 and contender = 1cce371. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2 (mimalloc)
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x (mimalloc)
[Finished ⬇️0.1% ⬆️0.1%] ursa-thinkcentre-m75q (mimalloc)

@cyb70289
cyb70289 deleted the 13003-unaligned-access branch June 15, 2021 23:58
sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Jun 23, 2021
@cyb70289@sjperkins
ARROW-13003: [C++] Fix key map unaligned access
40585c1
Closesapache#10489 from cyb70289/13003-unaligned-access
Authored-by: Yibo Cai <yibo.cai@arm.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport mentioned this pull request Jun 15, 2021
Closed
@asfimportasfimport mentioned this pull request Jul 26, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitrouAwaiting requested review from pitrou
@bkietzbkietzAwaiting requested review from bkietz

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyb70289@pitrou@ursabot