Skip to content

ARROW-13027: [C++] Fix ASAN stack traces in CI - #10498

Closed
westonpace wants to merge 3 commits into
apache:masterfrom
westonpace:feature/ARROW-13027--c-fix-asan-stack-traces-in-ci
Closed

ARROW-13027: [C++] Fix ASAN stack traces in CI#10498
westonpace wants to merge 3 commits into
apache:masterfrom
westonpace:feature/ARROW-13027--c-fix-asan-stack-traces-in-ci

Conversation

@westonpace

@westonpacewestonpace commented Jun 9, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Before change:

Direct leak of 65536 byte(s) in 1 object(s) allocated from:
#0 0x522f09 in
#1 0x7f28ae5826f4 in
#2 0x7f28ae57fa5d in
#3 0x7f28ae58cb0f in
#4 0x7f28ae58bda0 in
...

After change:

Direct leak of 65536 byte(s) in 1 object(s) allocated from:
#0 0x522f09 in posix_memalign (/build/cpp/debug/arrow-dataset-file-csv-test+0x522f09)
#1 0x7f28ae5826f4 in arrow::(anonymous namespace)::SystemAllocator::AllocateAligned(long, unsigned char**) /arrow/cpp/src/arrow/memory_pool.cc:213:24
#2 0x7f28ae57fa5d in arrow::BaseMemoryPoolImpl<arrow::(anonymous namespace)::SystemAllocator>::Allocate(long, unsigned char**) /arrow/cpp/src/arrow/memory_pool.cc:405:5
#3 0x7f28ae58cb0f in arrow::PoolBuffer::Reserve(long) /arrow/cpp/src/arrow/memory_pool.cc:717:9
#4 0x7f28ae58bda0 in arrow::PoolBuffer::Resize(long, bool) /arrow/cpp/src/arrow/memory_pool.cc:741:7
...

pitrou
pitrou reviewed Jun 9, 2021
View reviewed changes
Comment threaddocker-compose.yml Outdated
ARROW_S3: "OFF"
ARROW_USE_ASAN: "ON"
ARROW_USE_UBSAN: "ON"
ASAN_SYMBOLIZER_PATH: /usr/lib/llvm-12/bin/llvm-symbolizer

@pitroupitrouJun 9, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be added to the Dockerfile instead? Presumably it depends on the Ubuntu version.

@westonpace

westonpace commented Jun 9, 2021

Copy link
Copy Markdown
MemberAuthor

Good catch. The dockerfile also has a variable for llvm version so I don't have to hard code 12.

@github-actions

github-actionsBot commented Jun 9, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13027

@pitrou

pitrou commented Jun 15, 2021

Copy link
Copy Markdown
Member

This will be a welcome improvement :-)

sjperkins pushed a commit to sjperkins/arrow that referenced this pull request Jun 23, 2021
@westonpace@sjperkins
ARROW-13027: [C++] Fix ASAN stack traces in CI
71bcfae
Before change:
```
Direct leak of 65536 byte(s) in 1 object(s) allocated from:
#0 0x522f09 in
apache#1 0x7f28ae5826f4 in
apache#2 0x7f28ae57fa5d in
apache#3 0x7f28ae58cb0f in
apache#4 0x7f28ae58bda0 in
...
```
After change:
```
Direct leak of 65536 byte(s) in 1 object(s) allocated from:
#0 0x522f09 in posix_memalign (/build/cpp/debug/arrow-dataset-file-csv-test+0x522f09)
apache#1 0x7f28ae5826f4 in arrow::(anonymous namespace)::SystemAllocator::AllocateAligned(long, unsigned char**) /arrow/cpp/src/arrow/memory_pool.cc:213:24
apache#2 0x7f28ae57fa5d in arrow::BaseMemoryPoolImpl<arrow::(anonymous namespace)::SystemAllocator>::Allocate(long, unsigned char**) /arrow/cpp/src/arrow/memory_pool.cc:405:5
apache#3 0x7f28ae58cb0f in arrow::PoolBuffer::Reserve(long) /arrow/cpp/src/arrow/memory_pool.cc:717:9
apache#4 0x7f28ae58bda0 in arrow::PoolBuffer::Resize(long, bool) /arrow/cpp/src/arrow/memory_pool.cc:741:7
...
```
Closesapache#10498 from westonpace/feature/ARROW-13027--c-fix-asan-stack-traces-in-ci
Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@westonpace
westonpace deleted the feature/ARROW-13027--c-fix-asan-stack-traces-in-ci branch January 6, 2022 08:16
@asfimportasfimport mentioned this pull request Jun 15, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@westonpace@pitrou