ARROW-13073: [Developer] archery benchmark list: unexpected keyword 'benchmark_filter'

[dianaclarke]

$ archery benchmark list
Traceback (most recent call last):
File "/Users/diana/envs/arrow/bin/archery", line 33, in <module>
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/core.py", line 1137, in __call__
return self.main(*args, **kwargs)
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/core.py", line 1062, in main
rv = self.invoke(ctx)
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/core.py", line 1668, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/core.py", line 763, in invoke
return __callback(*args, **kwargs)
File "/Users/diana/envs/arrow/lib/python3.9/site-packages/click/decorators.py", line 26, in new_func
return f(get_current_context(), *args, **kwargs)
File "/Users/diana/workspace/arrow/dev/archery/archery/cli.py", line 430, in benchmark_list
conf = CppBenchmarkRunner.default_configuration(
File "/Users/diana/workspace/arrow/dev/archery/archery/benchmark/runner.py", line 118, in default_configuration
return CppConfiguration(
TypeError: __init__() got an unexpected keyword argument 'benchmark_filter'

[github-actions]

https://issues.apache.org/jira/browse/ARROW-13073

[westonpace]

You also can fix the option (without removing it) by adding benchmark_filter and suite_filter as arguments to benchmark_list (so they don't show up in kwargs and won't be passed to CppConfiguration) and then you can add them to the instantiation of the runner like it does here.

This will allow the error to go away. However, I notice that the CppBenchmarkRunner doesn't factor benchmark_filter into its list_benchmarks command so this won't error but it also won't work as advertised. From a quick glance it appears JavaBenchmarkRunner acts the same.

This is a long-winded (:smile:) way of saying I approve this approach. Since neither benchmark runner actually supports listing filtered benchmarks it's probably better to remove the options than it is to partially fix them. If someone decides they want the functionality then it can be implemented then.

[cyb70289]

+1

[dianaclarke]

Thanks @cyb70289 & @westonpace! ❤️

[cyb70289]

Thanks @dianaclarke for fixing the bug and @westonpace for careful review.
I only pressed the return key several times :)