Uh oh!
There was an error while loading. Please reload this page.
ARROW-13092: [C++] Return an error in CreateDir if target is a file - #10541
Closed
pitrou wants to merge 1 commit into
Closed
ARROW-13092: [C++] Return an error in CreateDir if target is a file#10541pitrou wants to merge 1 commit into
pitrou wants to merge 1 commit into
Conversation
pitrouforce-pushed
the
ARROW-13092-create-dir-is-a-file
branch
from
June 16, 2021 13:01
45b94f6 to
a712a23Comparepitrou
marked this pull request as ready for review
June 16, 2021 13:11
Member
There was a problem hiding this comment.
I checked and this code does the right thing with symlinks today (There is a S_ISLNK but you have to use lstat to get it) 👍 . I'm not sure if you want to add a test case or not.
MemberAuthor
There was a problem hiding this comment.
I'd rather not complicate the tests with that (especially as it would require some symlink creation code for Windows).
bkietz
approved these changes
Jun 16, 2021
Uh oh!
There was an error while loading. Please reload this page.
pitrouforce-pushed
the
ARROW-13092-create-dir-is-a-file
branch
from
June 17, 2021 17:38
a712a23 to
8909d43Comparesjperkins pushed a commit
to sjperkins/arrow
that referenced
this pull request
Jun 23, 2021
Closesapache#10541 from pitrou/ARROW-13092-create-dir-is-a-file Authored-by: Antoine Pitrou <antoine@python.org> Signed-off-by: Antoine Pitrou <antoine@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.