ARROW-11675: [CI][C++] Resolve ctest failures on VS 2019 builds by ianmcook · Pull Request #10583 · apache/arrow

ianmcook · 2021-06-23T16:21:35Z

No description provided.

github-actions · 2021-06-23T16:21:55Z

https://issues.apache.org/jira/browse/ARROW-11675

ianmcook · 2021-06-23T16:22:42Z

@github-actions crossbow submit test-build-vcpkg-win

github-actions · 2021-06-23T16:23:27Z

Revision: 877e2f829ccf2b2e892a674cb83700376f972a5d

Submitted crossbow builds: ursacomputing/crossbow @ actions-508

Task	Status
test-build-vcpkg-win

pitrou · 2021-06-24T08:11:10Z

Wow, the build took two hours. Is there a way to make it shorter?

pitrou · 2021-06-24T08:12:20Z

@github-actions crossbow submit test-build-vcpkg-win

github-actions · 2021-06-24T08:13:16Z

Revision: 4bf11fbd1e4c0de986cf74a029d9c6fb197ac548

Submitted crossbow builds: ursacomputing/crossbow @ actions-509

Task	Status
test-build-vcpkg-win

pitrou · 2021-06-24T09:02:56Z

@github-actions crossbow submit test-build-vcpkg-win

github-actions · 2021-06-24T09:03:55Z

Revision: 0f36f0f8f1ec9f775105b66df31c7f492d320434

Submitted crossbow builds: ursacomputing/crossbow @ actions-510

Task	Status
test-build-vcpkg-win

ianmcook · 2021-06-24T14:13:51Z

@pitrou the manifest file cpp/vcpkg.json specifies which Arrow library build dependencies to install when ARROW_DEPENDENCY_SOURCE=VCPKG, as described in the Building Arrow C++ and Developing on Windows docs, so if you're making changes to that file, please keep in mind that it serves a general purpose beyond what this CI job tests.

pitrou · 2021-06-24T18:51:16Z

Yawn. When I added some logging calls inside the inner routines, the bug disappeared. Looks like a compiler bug of sorts :-(

pitrou · 2021-06-25T11:22:50Z

TODO: perhaps add Spaced tests and specialization

pitrou · 2021-06-28T15:31:29Z

@github-actions crossbow submit test-build-vcpkg-win

github-actions · 2021-06-28T15:32:19Z

Revision: 42d2df8829baa2b4af5bbf02ae4aa0993bd27b61

Submitted crossbow builds: ursacomputing/crossbow @ actions-518

Task	Status
test-build-vcpkg-win

pitrou · 2021-06-28T15:38:55Z

@github-actions crossbow submit test-build-vcpkg-win

github-actions · 2021-06-28T15:42:03Z

Revision: 08ab1076947ab7fe7b778e80846704f96d5d71d2

Submitted crossbow builds: ursacomputing/crossbow @ actions-519

Task	Status
test-build-vcpkg-win

bkietz

A few nits. Otherwise this looks fine. Thanks for figuring this out

ianmcook · 2021-06-28T20:22:52Z

Thanks for working on this! The boost changes in cpp/vcpkg.json look good 👍

pitrou · 2021-06-29T13:07:35Z

@github-actions crossbow submit test-build-vcpkg-win

github-actions · 2021-06-29T13:08:23Z

Revision: 0f6c823

Submitted crossbow builds: ursacomputing/crossbow @ actions-531

Task	Status
test-build-vcpkg-win

pitrou · 2021-06-29T15:01:57Z

CI failures are unrelated, I'll merge.

github-actionsBot added Component: C++ Component: Parquet labels Jun 24, 2021

pitrou force-pushed the ARROW-11675 branch 3 times, most recently from 4df24a8 to 9b82e51Compare June 24, 2021 14:01

pitrou force-pushed the ARROW-11675 branch 2 times, most recently from 764fa80 to f53b013Compare June 24, 2021 17:53

pitrou force-pushed the ARROW-11675 branch 2 times, most recently from 6416786 to 42d2df8Compare June 28, 2021 15:30

pitrou marked this pull request as ready for review June 28, 2021 15:31

pitrou reviewed Jun 28, 2021
View reviewed changes

Comment threaddev/tasks/vcpkg-tests/github.windows.yml Outdated

pitrou requested a review from bkietz June 28, 2021 18:24

bkietz approved these changes Jun 28, 2021
View reviewed changes

Comment threadcpp/src/parquet/statistics.cc Outdated
Comment threadcpp/src/parquet/statistics.cc Outdated

Uncomment ctest
578de0d

pitrou added 12 commits June 29, 2021 15:01

Add debug output
6c909c8

Try possible fix
e4c22c0

Try caching binaries
fc3f3d7

Re-enable building
da0ce4d

More debug info
4cca568

Remove debug log
899c5b8

Try SafeCopy
07929c2

Add unsigned Int32 specialization
7773983

Add spaced tests
4ab145d

Cleanups
9b3a20b

Restore vcpkg reinstall
a581c29

Address review comments
0f6c823

pitrou force-pushed the ARROW-11675 branch from 08ab107 to 0f6c823Compare June 29, 2021 13:06

pitrou closed this in bf443c4Jun 29, 2021

asfimport mentioned this pull request Jun 29, 2021
[CI][C++] Resolve ctest failures on VS 2019 builds #27538
Closed

Uh oh!

Conversation

ianmcook commented Jun 23, 2021

Uh oh!

github-actionsBot commented Jun 23, 2021

Uh oh!

ianmcook commented Jun 23, 2021

Uh oh!

github-actionsBot commented Jun 23, 2021

Uh oh!

pitrou commented Jun 24, 2021

Uh oh!

pitrou commented Jun 24, 2021

Uh oh!

github-actionsBot commented Jun 24, 2021

Uh oh!

pitrou commented Jun 24, 2021

Uh oh!

github-actionsBot commented Jun 24, 2021

Uh oh!

ianmcook commented Jun 24, 2021

Uh oh!

pitrou commented Jun 24, 2021

Uh oh!

pitrou commented Jun 25, 2021

Uh oh!

pitrou commented Jun 28, 2021

Uh oh!

github-actionsBot commented Jun 28, 2021

Uh oh!

pitrou commented Jun 28, 2021

Uh oh!

Uh oh!

github-actionsBot commented Jun 28, 2021

Uh oh!

bkietz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ianmcook commented Jun 28, 2021

Uh oh!

pitrou commented Jun 29, 2021

Uh oh!

github-actionsBot commented Jun 29, 2021

Uh oh!

pitrou commented Jun 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants