Uh oh!
There was an error while loading. Please reload this page.
ARROW-12716: [C++] Add string padding kernel - #10586
Conversation
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Can you add a small python test to just ensure the cython options class is working correctly?
lidavidm
commented
Jun 24, 2021
Done (also set the default pad character to ' ' to be nicer to Python users). |
There was a problem hiding this comment.
There's no need to template this on OffsetValue, just return int64_t.
Also, since this is a generally useful function, perhaps put it in arrow/util/utf8.h?
There was a problem hiding this comment.
Moved & added a small test case.
There was a problem hiding this comment.
"codeunits" is the same as bytes for UTF8 ("codeunits" as opposed to "codepoints").
But, yes, it's pointlessly pedantic. Perhaps a wholesale renaming would be useful.
There was a problem hiding this comment.
Argh, somehow I had thought a codeunit was an encoded codepoint (i.e. 1-4 bytes). I'll remove the comment at least so as not to be misleading.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.