Uh oh!
There was an error while loading. Please reload this page.
ARROW-13113: [R] use RTasks to manage parallel in converting arrow to R - #10593
ARROW-13113: [R] use RTasks to manage parallel in converting arrow to R#10593romainfrancois wants to merge 12 commits into
Conversation
romainfrancois
commented
Jun 24, 2021
romainfrancois
commented
Jun 24, 2021
refactoring the Previously altrep was only triggered when converting the arrays. This is not done in parallel because altrep allocates, but also because at least for these, it's cheap/instant. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nealrichardson
commented
Jun 24, 2021
@ursabot please benchmark lang=R |
Benchmark runs are scheduled for baseline = 998a2a1 and contender = a85e40bfaebac5c59249e9a3dd9b4049828fd932. Results will be available as each benchmark for each run completes. |
nealrichardson
commented
Jun 25, 2021
@github-actions crossbow submit -g r |
Revision: a0f18640e86ccd4f0ef4a55ece186dc614bc7559 Submitted crossbow builds: ursacomputing/crossbow @ actions-511 |
a0f1864 to
903677eCompareromainfrancois
commented
Jul 2, 2021
I have code that deals with https://issues.apache.org/jira/browse/ARROW-13164 on top of this pull request. Can/Should I merge it in here or can this be merged and then I rebase ? @nealrichardson |
nealrichardson
commented
Jul 3, 2021
I think this can be merged and then you rebase for ARROW-13164, but I'll defer to @jonkeane to give the final 👍 and merge here, I've been out all week and haven't been keeping up with everything that's going on. |
romainfrancois
commented
Jul 5, 2021
Thanks @nealrichardson. @jonkeane did you have a chance to review this ? |
jonkeane
commented
Jul 5, 2021
This looks good to merge. I did noticed there is one benchmark that seemed to have gotten longer (https://conbench.ursa.dev/compare/benchmarks/8cd9415be73542b5b6422f112b82ab6c...7752b1285dea4eb6b4af79a42a191189/). It's possible that won't persist, but if it does we can dig into it and address it in a follow on. |
No description provided.