Skip to content

ARROW-13113: [R] use RTasks to manage parallel in converting arrow to R - #10593

Closed
romainfrancois wants to merge 12 commits into
apache:masterfrom
romainfrancois:ARROW-13113_RTasks
Closed

ARROW-13113: [R] use RTasks to manage parallel in converting arrow to R#10593
romainfrancois wants to merge 12 commits into
apache:masterfrom
romainfrancois:ARROW-13113_RTasks

Conversation

@romainfrancois

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

@romainfrancois

Copy link
Copy Markdown
ContributorAuthor

@romainfrancois

Copy link
Copy Markdown
ContributorAuthor

refactoring the Table$create()and RecordBatch internals to take advantage of altrep when a column is fit for altrep (i.e. at the moment is a double array with no nulls, or an int32 array with no nulls).

Previously altrep was only triggered when converting the arrays.

This is not done in parallel because altrep allocates, but also because at least for these, it's cheap/instant.

Comment threadr/R/chunked-array.R Outdated
Comment threadr/src/r_task_group.h Outdated
@nealrichardson

Copy link
Copy Markdown
Member

@ursabot please benchmark lang=R

@ursabot

ursabot commented Jun 24, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 998a2a1 and contender = a85e40bfaebac5c59249e9a3dd9b4049828fd932. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2 (mimalloc)
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x (mimalloc)
[Skipped ⚠️ Only ['C++'] langs are supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q (mimalloc)

@nealrichardson

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g r

@github-actions

Copy link
Copy Markdown

Revision: a0f18640e86ccd4f0ef4a55ece186dc614bc7559

Submitted crossbow builds: ursacomputing/crossbow @ actions-511

TaskStatus
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
homebrew-r-autobrewGithub Actions
test-r-devdocsGithub Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-rtools-35Github Actions
test-r-version-compatibilityGithub Actions
test-r-versionsGithub Actions
test-r-without-arrowAzure
test-ubuntu-18.04-r-sanitizerAzure

@romainfrancois

Copy link
Copy Markdown
ContributorAuthor

I have code that deals with https://issues.apache.org/jira/browse/ARROW-13164 on top of this pull request. Can/Should I merge it in here or can this be merged and then I rebase ? @nealrichardson

@nealrichardson

Copy link
Copy Markdown
Member

I have code that deals with https://issues.apache.org/jira/browse/ARROW-13164 on top of this pull request. Can/Should I merge it in here or can this be merged and then I rebase ? @nealrichardson

I think this can be merged and then you rebase for ARROW-13164, but I'll defer to @jonkeane to give the final 👍 and merge here, I've been out all week and haven't been keeping up with everything that's going on.

@romainfrancois

Copy link
Copy Markdown
ContributorAuthor

Thanks @nealrichardson. @jonkeane did you have a chance to review this ?

@jonkeane

Copy link
Copy Markdown
Member

This looks good to merge. I did noticed there is one benchmark that seemed to have gotten longer (https://conbench.ursa.dev/compare/benchmarks/8cd9415be73542b5b6422f112b82ab6c...7752b1285dea4eb6b4af79a42a191189/). It's possible that won't persist, but if it does we can dig into it and address it in a follow on.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@romainfrancois@nealrichardson@ursabot@jonkeane