Skip to content

ARROW-12967: [R] Add bindings for pmin() and pmax() - #10615

Closed
pachadotdev wants to merge 16 commits into
apache:masterfrom
pachadotdev:arrow12967v3
Closed

ARROW-12967: [R] Add bindings for pmin() and pmax()#10615
pachadotdev wants to merge 16 commits into
apache:masterfrom
pachadotdev:arrow12967v3

Conversation

@pachadotdev

@pachadotdevpachadotdev commented Jun 29, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@pachadotdevpachadotdev changed the title Arrow12967v3ARROW-12967: [R] Add bindings for pmin() and pmax() #10497 #10613 Jun 29, 2021
@github-actions

github-actionsBot commented Jun 29, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-12967

pitrou
pitrou reviewed Jun 29, 2021
View reviewed changes
Comment threadr/R/dplyr-functions.R Outdated
ianmcook
ianmcook reviewed Jun 29, 2021
View reviewed changes
Comment threadr/src/compute.cpp Outdated
@apacheapache deleted a comment from github-actionsBotJun 29, 2021
ianmcook
ianmcook reviewed Jun 29, 2021
View reviewed changes
Comment threadr/R/dplyr-functions.R Outdated
ianmcook
ianmcook reviewed Jun 29, 2021
View reviewed changes
Comment threadr/R/dplyr-functions.R Outdated
Pacháand others added 3 commits June 29, 2021 14:55
Pachá@ianmcook
Update r/src/compute.cpp
db277c6
Co-authored-by: Ian Cook <ianmcook@gmail.com>
Pachá@ianmcook
Update r/R/dplyr-functions.R
5a4c396
Co-authored-by: Ian Cook <ianmcook@gmail.com>
Pachá@ianmcook
Update r/R/dplyr-functions.R
6c41491
Co-authored-by: Ian Cook <ianmcook@gmail.com>
ianmcook
ianmcook reviewed Jun 29, 2021
View reviewed changes
Comment threadr/tests/testthat/test-dplyr-mutate.R
@pachadotdevpachadotdev changed the title ARROW-12967: [R] Add bindings for pmin() and pmax() #10497 #10613 ARROW-12967: [R] Add bindings for pmin() and pmax()Jun 29, 2021
ianmcook
ianmcook approved these changes Jun 30, 2021
View reviewed changes

@ianmcookianmcook left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@asfimportasfimport mentioned this pull request Jun 30, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou left review comments
@ianmcookianmcookianmcook approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pachadotdev@ianmcook@pitrou