Skip to content

ARROW-13220: [C++] Implement 'choose' function - #10642

Closed
lidavidm wants to merge 3 commits into
apache:masterfrom
lidavidm:arrow-13220
Closed

ARROW-13220: [C++] Implement 'choose' function#10642
lidavidm wants to merge 3 commits into
apache:masterfrom
lidavidm:arrow-13220

Conversation

@lidavidm

@lidavidmlidavidm commented Jul 1, 2021

Copy link
Copy Markdown
Member

Also makes two changes:

  • MakeArrayFromScalar now works with Decimal256 and FixedSizeBinaryType
  • VarArgs(min_args=N) for N>1 now works (before different assertions/runtime checks would trigger). Though, might it make sense to update KernelSignature to reflect min_args?

@lidavidmlidavidm changed the title ARROW-13064: [C++] Implement 'choose' functionARROW-13220: [C++] Implement 'choose' functionJul 2, 2021
@github-actions

github-actionsBot commented Jul 2, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13220

@apacheapache deleted a comment from github-actionsBotJul 2, 2021
@lidavidmlidavidm mentioned this pull request Jul 2, 2021
Closed
@lidavidm
lidavidmforce-pushed the arrow-13220 branch 2 times, most recently from f419cf1 to 9fdbdc0CompareJuly 13, 2021 13:22
@lidavidm

lidavidm commented Jul 13, 2021

Copy link
Copy Markdown
MemberAuthor

@ursabot please benchmark lang=C++

@ursabot

ursabot commented Jul 13, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = ca50cd1 and contender = 3c1182c9bdaf656c2ef1c0311e5078f45b87eb78. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Provided benchmark filters do not have any benchmark groups to be executed on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2 (mimalloc)
[Skipped ⚠️ Only ['Python', 'R'] langs are supported on ursa-i9-9960x] ursa-i9-9960x (mimalloc)
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q (mimalloc)
Supported benchmarks:
ursa-i9-9960x: langs = Python, R
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@lidavidm
lidavidmforce-pushed the arrow-13220 branch 2 times, most recently from 80858c2 to e74efb6CompareJuly 14, 2021 15:48
@lidavidm

lidavidm commented Jul 16, 2021

Copy link
Copy Markdown
MemberAuthor

This needs a lot of merge conflict resolving, so moving to draft for now until #10608 is also merged.

@lidavidm
lidavidm marked this pull request as draft July 16, 2021 15:55
@lidavidm
lidavidm marked this pull request as ready for review July 19, 2021 20:26
pitrou
pitrou requested changes Jul 27, 2021
View reviewed changes
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
Comment threaddocs/source/cpp/compute.rst Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else_benchmark.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else_test.cc Outdated
Comment threadcpp/src/arrow/compute/kernels/scalar_if_else.cc Outdated
@pitroupitrou closed this in af75883Aug 4, 2021
This was referenced Jul 16, 2021
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm@ursabot@pitrou