Skip to content

ARROW-13189: [R] Disable row-level metadata application on datasets - #10646

Closed
jonkeane wants to merge 5 commits into
apache:masterfrom
jonkeane:ARROW-13189-ds-row-metadata
Closed

ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom
jonkeane:ARROW-13189-ds-row-metadata

Conversation

@jonkeane

@jonkeanejonkeane commented Jul 1, 2021

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Jul 1, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189

thisisnic
thisisnic reviewed Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R Outdated

@thisisnicthisisnicJul 13, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?

@thisisnic

thisisnic commented Jul 13, 2021

Copy link
Copy Markdown
Member

Other than minor thing about typo (or phrasing) LGTM

nealrichardson
nealrichardson reviewed Jul 15, 2021
View reviewed changes

@nealrichardsonnealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you

Comment threadr/R/metadata.R Outdated
Comment threadr/R/metadata.R Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.

Also:

Suggested change
warning("Row-level metadata has been discarded")
warning("Row-level metadata has been discarded", call.=FALSE)

Comment threadr/tests/testthat/test-metadata.R Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.

@jonkeanejonkeaneJul 15, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):

> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
>

@jonkeanejonkeaneJul 15, 2021

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test

@jonkeane
jonkeaneforce-pushed the ARROW-13189-ds-row-metadata branch from ab7f0d7 to 0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane

jonkeane commented Jul 15, 2021

Copy link
Copy Markdown
MemberAuthor

Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.

@asfimportasfimport mentioned this pull request Oct 19, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ARROW-13189: [R] Disable row-level metadata application on datasets by jonkeane · Pull Request #10646 · apache/arrow · GitHub
Skip to content
ARROW-13189: [R] Disable row-level metadata application on datasets - #10646
Closed
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Closed
ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Conversation
@jonkeane
@jonkeanejonkeane
commented
Jul 1, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Jul 1, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189
thisisnic
thisisnic
reviewed
Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R
Outdated

@thisisnicthisisnicJul 13, 2021•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?
@thisisnic
thisisnic
commented
Jul 13, 2021

Copy link


Copy Markdown

Member
Other than minor thing about typo (or phrasing) LGTM
nealrichardson
nealrichardson
reviewed
Jul 15, 2021
View reviewed changes
@nealrichardsonnealrichardson
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you
Comment threadr/R/metadata.R
Outdated

Comment threadr/R/metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.
Also:

Suggested change

 warning("Row-level metadata has been discarded")
 warning("Row-level metadata has been discarded", call.=FALSE)
Comment threadr/tests/testthat/test-metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):
> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
> 
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test
@jonkeane
jonkeaneforce-pushed
the
ARROW-13189-ds-row-metadata
branch
from
ab7f0d7 to
0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane
jonkeane
commented
Jul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.
@asfimportasfimport
mentioned this pull request
Oct 19, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-13189: [R] Disable row-level metadata application on datasets by jonkeane · Pull Request #10646 · apache/arrow · GitHub
Skip to content
ARROW-13189: [R] Disable row-level metadata application on datasets - #10646
Closed
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Closed
ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Conversation
@jonkeane
@jonkeanejonkeane
commented
Jul 1, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Jul 1, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189
thisisnic
thisisnic
reviewed
Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R
Outdated

@thisisnicthisisnicJul 13, 2021•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?
@thisisnic
thisisnic
commented
Jul 13, 2021

Copy link


Copy Markdown

Member
Other than minor thing about typo (or phrasing) LGTM
nealrichardson
nealrichardson
reviewed
Jul 15, 2021
View reviewed changes
@nealrichardsonnealrichardson
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you
Comment threadr/R/metadata.R
Outdated

Comment threadr/R/metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.
Also:

Suggested change

 warning("Row-level metadata has been discarded")
 warning("Row-level metadata has been discarded", call.=FALSE)
Comment threadr/tests/testthat/test-metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):
> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
> 
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test
@jonkeane
jonkeaneforce-pushed
the
ARROW-13189-ds-row-metadata
branch
from
ab7f0d7 to
0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane
jonkeane
commented
Jul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.
@asfimportasfimport
mentioned this pull request
Oct 19, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-13189: [R] Disable row-level metadata application on datasets by jonkeane · Pull Request #10646 · apache/arrow · GitHub
Skip to content
ARROW-13189: [R] Disable row-level metadata application on datasets - #10646
Closed
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Closed
ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Conversation
@jonkeane
@jonkeanejonkeane
commented
Jul 1, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Jul 1, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189
thisisnic
thisisnic
reviewed
Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R
Outdated

@thisisnicthisisnicJul 13, 2021•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?
@thisisnic
thisisnic
commented
Jul 13, 2021

Copy link


Copy Markdown

Member
Other than minor thing about typo (or phrasing) LGTM
nealrichardson
nealrichardson
reviewed
Jul 15, 2021
View reviewed changes
@nealrichardsonnealrichardson
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you
Comment threadr/R/metadata.R
Outdated

Comment threadr/R/metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.
Also:

Suggested change

 warning("Row-level metadata has been discarded")
 warning("Row-level metadata has been discarded", call.=FALSE)
Comment threadr/tests/testthat/test-metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):
> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
> 
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test
@jonkeane
jonkeaneforce-pushed
the
ARROW-13189-ds-row-metadata
branch
from
ab7f0d7 to
0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane
jonkeane
commented
Jul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.
@asfimportasfimport
mentioned this pull request
Oct 19, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ARROW-13189: [R] Disable row-level metadata application on datasets by jonkeane · Pull Request #10646 · apache/arrow · GitHub
Skip to content
ARROW-13189: [R] Disable row-level metadata application on datasets - #10646
Closed
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Closed
ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Conversation
@jonkeane
@jonkeanejonkeane
commented
Jul 1, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Jul 1, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189
thisisnic
thisisnic
reviewed
Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R
Outdated

@thisisnicthisisnicJul 13, 2021•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?
@thisisnic
thisisnic
commented
Jul 13, 2021

Copy link


Copy Markdown

Member
Other than minor thing about typo (or phrasing) LGTM
nealrichardson
nealrichardson
reviewed
Jul 15, 2021
View reviewed changes
@nealrichardsonnealrichardson
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you
Comment threadr/R/metadata.R
Outdated

Comment threadr/R/metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.
Also:

Suggested change

 warning("Row-level metadata has been discarded")
 warning("Row-level metadata has been discarded", call.=FALSE)
Comment threadr/tests/testthat/test-metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):
> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
> 
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test
@jonkeane
jonkeaneforce-pushed
the
ARROW-13189-ds-row-metadata
branch
from
ab7f0d7 to
0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane
jonkeane
commented
Jul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.
@asfimportasfimport
mentioned this pull request
Oct 19, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-13189: [R] Disable row-level metadata application on datasets by jonkeane · Pull Request #10646 · apache/arrow · GitHub
Skip to content
ARROW-13189: [R] Disable row-level metadata application on datasets - #10646
Closed
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Closed
ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Conversation
@jonkeane
@jonkeanejonkeane
commented
Jul 1, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Jul 1, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189
thisisnic
thisisnic
reviewed
Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R
Outdated

@thisisnicthisisnicJul 13, 2021•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?
@thisisnic
thisisnic
commented
Jul 13, 2021

Copy link


Copy Markdown

Member
Other than minor thing about typo (or phrasing) LGTM
nealrichardson
nealrichardson
reviewed
Jul 15, 2021
View reviewed changes
@nealrichardsonnealrichardson
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you
Comment threadr/R/metadata.R
Outdated

Comment threadr/R/metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.
Also:

Suggested change

 warning("Row-level metadata has been discarded")
 warning("Row-level metadata has been discarded", call.=FALSE)
Comment threadr/tests/testthat/test-metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):
> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
> 
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test
@jonkeane
jonkeaneforce-pushed
the
ARROW-13189-ds-row-metadata
branch
from
ab7f0d7 to
0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane
jonkeane
commented
Jul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.
@asfimportasfimport
mentioned this pull request
Oct 19, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
ARROW-13189: [R] Disable row-level metadata application on datasets by jonkeane · Pull Request #10646 · apache/arrow · GitHub
Skip to content
ARROW-13189: [R] Disable row-level metadata application on datasets - #10646
Closed
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Closed
ARROW-13189: [R] Disable row-level metadata application on datasets#10646
jonkeane wants to merge 5 commits into
apache:masterfrom 
jonkeane:ARROW-13189-ds-row-metadata
Conversation
@jonkeane
@jonkeanejonkeane
commented
Jul 1, 2021

Copy link


Copy Markdown

Member
 No description provided. 
@github-actions
github-actionsBot
commented
Jul 1, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13189
thisisnic
thisisnic
reviewed
Jul 13, 2021
View reviewed changes
Comment threadr/R/metadata.R
Outdated

@thisisnicthisisnicJul 13, 2021•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: looks like a typo where you say "this is apply"?
@thisisnic
thisisnic
commented
Jul 13, 2021

Copy link


Copy Markdown

Member
Other than minor thing about typo (or phrasing) LGTM
nealrichardson
nealrichardson
reviewed
Jul 15, 2021
View reviewed changes
@nealrichardsonnealrichardson
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes, though I don't understand this code all that well and defer to you
Comment threadr/R/metadata.R
Outdated

Comment threadr/R/metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this message deserve more explanation? Trying to think of what I would do if I saw that message.
Also:

Suggested change

 warning("Row-level metadata has been discarded")
 warning("Row-level metadata has been discarded", call.=FALSE)
Comment threadr/tests/testthat/test-metadata.R
Outdated

@nealrichardsonnealrichardsonJul 15, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I ds %>% select(part) %>% collect(), do I get the warning? I'd think I shouldn't.
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that works without warning (like it should as you say):
> ds %>% select(part) %>% collect()
# A tibble: 4 x 1
part
* <int>
1 1
2 1
3 2
4 3
> 
@jonkeanejonkeaneJul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a test that asserts that though, it's a quick + easy test
@jonkeane
jonkeaneforce-pushed
the
ARROW-13189-ds-row-metadata
branch
from
ab7f0d7 to
0569f3eCompareJuly 15, 2021 18:06
@jonkeane
use trace_back instead of stack_trace which has now been deprecat…
f9bc74d
…ed. Also warn/don't save row-level metadata with datasets.
@jonkeane
jonkeane
commented
Jul 15, 2021

Copy link


Copy Markdown

MemberAuthor
Ok, I've made a few changes (including avoiding the now deprecated call_stack()). I've also added this to prevent writing this metadata with datasets. I've expanded the warning messages a bit more. The messages themselves could be longer, though I think it might be better to have the longer explanation in NEWS and we can point to {sfarrow} there for saving sf data.
@asfimportasfimport
mentioned this pull request
Oct 19, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@thisisnicthisisnicthisisnic left review comments
@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees


No one assigned


Labels

Component: R

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeane@thisisnic@nealrichardson