Skip to content

ARROW-13200: [R] Add binding for case_when() - #10737

Closed
ianmcook wants to merge 8 commits into
apache:masterfrom
ianmcook:ARROW-13200
Closed

ARROW-13200: [R] Add binding for case_when()#10737
ianmcook wants to merge 8 commits into
apache:masterfrom
ianmcook:ARROW-13200

Conversation

@ianmcook

@ianmcookianmcook commented Jul 17, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Adds support for case_when() in dplyr verbs. I followed the example of dbplyr::case_when(), which is much simpler and more self-contained than dplyr::case_when().

@github-actions

github-actionsBot commented Jul 17, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-13200

@nealrichardson
nealrichardson self-requested a review July 17, 2021 14:52
@ianmcook
ianmcook marked this pull request as ready for review July 17, 2021 17:14
@ianmcook

ianmcook commented Jul 17, 2021

Copy link
Copy Markdown
MemberAuthor

Let's merge #10724 before we merge this. I will rebase and resolve the conflicts after #10724 is merged.

@ianmcook

ianmcook commented Jul 17, 2021

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-r-without-arrow test-r-minimal-build

@github-actions

github-actionsBot commented Jul 17, 2021

Copy link
Copy Markdown

Revision: db7c0d267b6dbc1c35d29d4d08aafcd7f99e2334

Submitted crossbow builds: ursacomputing/crossbow @ actions-610

TaskStatus
test-r-minimal-buildAzure
test-r-without-arrowAzure

ianmcook
ianmcook commented Jul 17, 2021
View reviewed changes
Comment threadr/R/dplyr-functions.R Outdated
ianmcook
ianmcook commented Jul 17, 2021
View reviewed changes
Comment threadr/R/dplyr-functions.R Outdated
nealrichardson
nealrichardson reviewed Jul 17, 2021
View reviewed changes
Comment threadr/R/dplyr-functions.R Outdated
nealrichardson
nealrichardson reviewed Jul 17, 2021
View reviewed changes
Comment threadr/tests/testthat/test-dplyr.R Outdated
@nealrichardson

nealrichardson commented Jul 17, 2021

Copy link
Copy Markdown
Member

I've merged the news PR, so after you rebase please add a bullet in the new dplyr functions section for this (noting any type limitations) and also note if_else there too (which I think doesn't have those same type limitations?)

nealrichardson
nealrichardson reviewed Jul 17, 2021
View reviewed changes
Comment threadr/src/compute.cpp Outdated
nealrichardson
nealrichardson approved these changes Jul 17, 2021
View reviewed changes

@nealrichardsonnealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@asfimportasfimport mentioned this pull request Jul 18, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ianmcook@nealrichardson