Uh oh!
There was an error while loading. Please reload this page.
ARROW-12944: [C++] String capitalize kernel - #10857
Closed
edponce wants to merge 8 commits into
Closed
Conversation
pitrou
requested changes
Aug 3, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
edponceforce-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
August 3, 2021 14:48
c1b73ae to
6ae88fdComparepitrou
reviewed
Aug 4, 2021
Uh oh!
There was an error while loading. Please reload this page.
pitrou
approved these changes
Aug 4, 2021
pitrouforce-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
August 4, 2021 12:12
18c4f01 to
9d7f298Comparepitrou
commented
Aug 4, 2021
Member
Rebased, will merge if green. |
edponceforce-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
August 4, 2021 12:36
9d7f298 to
4f82d0dCompareedponce
commented
Aug 4, 2021
ContributorAuthor
@pitrou I pushed a change after you rebased, so I will fix conflicts and re-push. |
pitrou
commented
Aug 4, 2021
Member
Hmm, another commit was lost then... |
pitrou
commented
Aug 4, 2021
Member
Recommend starting from 9d7f298 and then applying the buffer overflow fix. |
edponceforce-pushed
the
ARROW-12944-String-capitalize-kernel
branch
from
August 4, 2021 13:41
4f82d0d to
997919eCompareedponce
commented
Aug 5, 2021
ContributorAuthor
Some tests invoke the incorrect kernel (ASCII test uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds scalar compute functions for string capitalization, namely "ascii_capitalize" and "utf8_capitalize".