Uh oh!
There was an error while loading. Please reload this page.
ARROW-13544 [Java]: Remove APIs that have been deprecated for long (Changes to Vectors) - #10910
Closed
liyafan82 wants to merge 2 commits into
Closed
ARROW-13544 [Java]: Remove APIs that have been deprecated for long (Changes to Vectors)#10910liyafan82 wants to merge 2 commits into
liyafan82 wants to merge 2 commits into
Conversation
| @Override | ||
| public UnionVector promoteToUnion() { | ||
| UnionVector vector = new UnionVector("$data$", allocator, callBack); | ||
| UnionVector vector = new UnionVector("$data$", allocator, null, callBack); |
Contributor
There was a problem hiding this comment.
please comment null literal.
emkornfield
commented
Aug 17, 2021
Contributor
Generally looks good, it looks like a lot of null literals where added in, it would be nice to comment those. Thanks for the cleanup! |
liyafan82
commented
Aug 17, 2021
ContributorAuthor
Comments added. Please check. Thanks. |
liyafan82
commented
Aug 31, 2021
ContributorAuthor
@emkornfield Thanks for reviewing this PR. Do you have any more comments? |
emkornfield
commented
Sep 2, 2021
Contributor
Nope looks OK to me. |
emkornfield
commented
Sep 2, 2021
Contributor
+1 |
ViniciusSouzaRoque pushed a commit
to s1mbi0se/arrow
that referenced
this pull request
Oct 20, 2021
…hanges to Vectors) See https://issues.apache.org/jira/browse/ARROW-13544 According to the discussion in apache#10864 (comment), we want to split the task into multiple parts. This PR is for the changes related to vectors Closesapache#10910 from liyafan82/fly_0810_depv Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
…hanges to Vectors) See https://issues.apache.org/jira/browse/ARROW-13544 According to the discussion in apache#10864 (comment), we want to split the task into multiple parts. This PR is for the changes related to vectors Closesapache#10910 from liyafan82/fly_0810_depv Authored-by: liyafan82 <fan_li_ya@foxmail.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/ARROW-13544
According to the discussion in #10864 (comment), we want to split the task into multiple parts.
This PR is for the changes related to vectors