Uh oh!
There was an error while loading. Please reload this page.
ARROW-13995: [R] Bindings for join node - #11155
Conversation
df4c33f to
e947054Compare8cf93e6 to
ec85e9fCompareThere was a problem hiding this comment.
This is not a comment on this code, but it never occurred to me that it's a bit funny that by isn't tidy-evaled and must be character strings (in dplyr!)
There was a problem hiding this comment.
It makes sense for the by = c(col_x = "col_y") interface, but a bit(?) odd for by = "col" case
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
I can do this when I rebase, but should we have tests for the error handling as well (e.g. columns named but not in x or y, etc.)?
There was a problem hiding this comment.
Oh yeah, there are lots of missing tests, and these datasets aren't ideal for testing joins. We may want to just use the datasets that dplyr uses in its tests or something.
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
This is based on apache#11150. Among the issues observed: * Dictionary columns aren't allowed even in the left data, though you can first `Project` to remove them * Duplicate column names aren't allowed at all, even though there is a provision for deduping with a prefix Closesapache#11155 from nealrichardson/join-dplyr Lead-authored-by: Neal Richardson <neal.p.richardson@gmail.com> Co-authored-by: Jonathan Keane <jkeane@gmail.com> Signed-off-by: Jonathan Keane <jkeane@gmail.com>
This is based on #11150.
Among the issues observed:
Projectto remove them