Skip to content

ARROW-14070: [C++][CI] Remove support for VS2015 - #11211

Closed
bkietz wants to merge 2 commits into
apache:masterfrom
bkietz:14070-Remove-support-for-Visual
Closed

ARROW-14070: [C++][CI] Remove support for VS2015#11211
bkietz wants to merge 2 commits into
apache:masterfrom
bkietz:14070-Remove-support-for-Visual

Conversation

@bkietz

Copy link
Copy Markdown
Member

VS2015 is buggy and Microsoft has withdrawn documentation/bug reporting so it's time for us to drop support.

See mailing list discussion: https://lists.apache.org/thread.html/rff3d8e837aee2964b49733b39a34cffef7c5438dbf2e5c929e878fdf%40%3Cdev.arrow.apache.org%3E

@github-actions

Copy link
Copy Markdown

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this :-)

Comment threadappveyor.yml Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this one but switch to a newer VS? It also differs by not using conda packages for dependencies.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created https://issues.apache.org/jira/browse/ARROW-14075 to add vs2019 and non-conda jobs

Comment threadci/appveyor-cpp-setup.bat Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this useful?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC this causes an exit-with-error-code

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need exit /B 1 for that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice.

@pitrou

Copy link
Copy Markdown
Member

@github-actions crossbow submit win

@github-actions

Copy link
Copy Markdown

Revision: 6c96be131565277598667e6c8082b4878e5fa6bc

Submitted crossbow builds: ursacomputing/crossbow @ actions-853

TaskStatus
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
test-build-vcpkg-winGithub Actions
verify-rc-source-windowsGithub Actions
verify-rc-wheels-windowsGithub Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@kszucs

Copy link
Copy Markdown
Member

The verification tasks require additional prams and the vcpkg task is failing regardless of the PR (based on the nightly report).

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be some issues but overall I like this.

Comment threadcpp/src/gandiva/precompiled/CMakeLists.txt Outdated

@kszucskszucs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pitrou
pitrouforce-pushed the 14070-Remove-support-for-Visual branch from 366356b to 8e8bd9bCompareSeptember 29, 2021 10:27
@pitrou

Copy link
Copy Markdown
Member

Rebased, will merge if CI green.

ViniciusSouzaRoque pushed a commit to s1mbi0se/arrow that referenced this pull request Oct 20, 2021
VS2015 is buggy and Microsoft has withdrawn documentation/bug reporting so it's time for us to drop support.
See mailing list discussion: https://lists.apache.org/thread.html/rff3d8e837aee2964b49733b39a34cffef7c5438dbf2e5c929e878fdf%40%3Cdev.arrow.apache.org%3EClosesapache#11211 from bkietz/14070-Remove-support-for-Visual
Authored-by: Benjamin Kietzman <bengilgit@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@bkietz
bkietz deleted the 14070-Remove-support-for-Visual branch November 30, 2021 15:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bkietz@pitrou@kszucs@kou