Skip to content

ARROW-10898: [C++] Improve table sort performance - #11262

Closed
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-10898-table-merge-sort
Closed

ARROW-10898: [C++] Improve table sort performance#11262
pitrou wants to merge 1 commit into
apache:masterfrom
pitrou:ARROW-10898-table-merge-sort

Conversation

@pitrou

Copy link
Copy Markdown
Member

Use the same strategy as for chunked array sorting:

  • first sort each RecordBatch individually, taking advantage of data contiguity for fast indexing
  • then merge sorted batches recursively, using slower chunked indexing

Benchmarks show up to 200% speedups on some benchmark parameters, along with very minor regressions.

@github-actions

Copy link
Copy Markdown

Use the same strategy as for chunked array sorting:
- first sort each RecordBatch individually, taking advantage of
data contiguity for fast indexing
- then merge sorted batches recursively, using slower chunked
indexing
Benchmarks show up to 200% speedups on some benchmark parameters, along with very minor regressions.
@pitrou
pitrouforce-pushed the ARROW-10898-table-merge-sort branch from a24e0eb to f25bf77CompareSeptember 28, 2021 18:54
@pitrou

Copy link
Copy Markdown
MemberAuthor

@ursabot please benchmark

@ursabot

ursabot commented Sep 28, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 8dbe574 and contender = f25bf77. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@lidavidmlidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

kou
kou approved these changes Sep 28, 2021

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@pitrou
pitrou deleted the ARROW-10898-table-merge-sort branch September 29, 2021 07:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@pitrou@ursabot@kou@lidavidm