Skip to content

ARROW-14166: [C++] update vcpkg builtin baseline - #11266

Closed
coryan wants to merge 1 commit into
apache:masterfrom
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed

ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom
coryan:ARROW-14166-update-vcpkg-builtin-baseline

Conversation

@coryan

@coryancoryan commented Sep 29, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Sep 29, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166

@coryan
coryan marked this pull request as ready for review September 29, 2021 14:08
@coryan

coryan commented Sep 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.

@kou

kou commented Sep 29, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g nightly

@github-actions

github-actionsBot commented Sep 29, 2021

Copy link
Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c

Submitted crossbow builds: ursacomputing/crossbow @ actions-861

TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@kou

kou commented Sep 30, 2021

Copy link
Copy Markdown
Member

Umm, there are some failures... I'm not sure the failures are related to this change...

@ianmcook Could you confirm this change?

@coryan

coryan commented Sep 30, 2021

Copy link
Copy Markdown
ContributorAuthor

If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.

@ianmcook

ianmcook commented Oct 1, 2021

Copy link
Copy Markdown
Member

Thanks for working on this @coryan!

test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.

@ianmcook

ianmcook commented Oct 3, 2021•
edited
Loading

Copy link
Copy Markdown
Member

I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail

@coryan

coryan commented Oct 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?

@kou

kou commented Oct 5, 2021

Copy link
Copy Markdown
Member

@ianmcook Could you dig into the linker issue?

@ianmcook

ianmcook commented Oct 8, 2021

Copy link
Copy Markdown
Member

Jira for the linker error is ARROW-14260.

@coryan

coryan commented Oct 13, 2021

Copy link
Copy Markdown
ContributorAuthor

Is there something else I should do in this PR or can we merge it?

@kou

kou commented Oct 15, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-build-vcpkg-win

@github-actions

github-actionsBot commented Oct 15, 2021

Copy link
Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec

Submitted crossbow builds: ursacomputing/crossbow @ actions-971

TaskStatus
test-build-vcpkg-winGithub Actions

@coryan

coryan commented Oct 26, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Rebased, looks like there was a related change a few days ago.

@kou

kou commented Oct 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit test-build-vcpkg-win

@github-actions

github-actionsBot commented Oct 26, 2021

Copy link
Copy Markdown

Revision: 154c3af

Submitted crossbow builds: ursacomputing/crossbow @ actions-1051

TaskStatus
test-build-vcpkg-winGithub Actions

kou
kou approved these changes Oct 28, 2021
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@koukou closed this in 61be051Oct 28, 2021
@ursabot

ursabot commented Oct 28, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan
coryan deleted the ARROW-14166-update-vcpkg-builtin-baseline branch October 28, 2021 01:05
@asfimportasfimport mentioned this pull request Oct 28, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ARROW-14166: [C++] update vcpkg builtin baseline by coryan · Pull Request #11266 · apache/arrow · GitHub
Skip to content
ARROW-14166: [C++] update vcpkg builtin baseline - #11266
Closed
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed
ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Conversation
@coryan
@coryancoryan
commented
Sep 29, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166
@coryan
coryan
marked this pull request as ready for review
September 29, 2021 14:08
@coryan
coryan
commented
Sep 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.
@kou
kou
commented
Sep 29, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c
Submitted crossbow builds: ursacomputing/crossbow @ actions-861
TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Sep 30, 2021

Copy link


Copy Markdown

Member
Umm, there are some failures... I'm not sure the failures are related to this change...
@ianmcook Could you confirm this change?
@coryan
coryan
commented
Sep 30, 2021

Copy link


Copy Markdown

ContributorAuthor
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.
@ianmcook
ianmcook
commented
Oct 1, 2021

Copy link


Copy Markdown

Member
Thanks for working on this @coryan!
test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.
@ianmcook
ianmcook
commented
Oct 3, 2021•

edited

Loading

Copy link


Copy Markdown

Member
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail
@coryan
coryan
commented
Oct 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?
@kou
kou
commented
Oct 5, 2021

Copy link


Copy Markdown

Member
@ianmcook Could you dig into the linker issue?
@ianmcook
ianmcook
commented
Oct 8, 2021

Copy link


Copy Markdown

Member
Jira for the linker error is ARROW-14260.
@coryan
coryan
commented
Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Is there something else I should do in this PR or can we merge it?
@kou
kou
commented
Oct 15, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 15, 2021

Copy link


Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec
Submitted crossbow builds: ursacomputing/crossbow @ actions-971
TaskStatus
test-build-vcpkg-winGithub Actions
@coryan
coryan
commented
Oct 26, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased, looks like there was a related change a few days ago.
@kou
kou
commented
Oct 26, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

Revision: 154c3af
Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
TaskStatus
test-build-vcpkg-winGithub Actions
kou
kou
approved these changes
Oct 28, 2021
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@koukou
closed this
in
61be051Oct 28, 2021
@ursabot
ursabot
commented
Oct 28, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14166-update-vcpkg-builtin-baseline

branch
October 28, 2021 01:05
@asfimportasfimport
mentioned this pull request
Oct 28, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-14166: [C++] update vcpkg builtin baseline by coryan · Pull Request #11266 · apache/arrow · GitHub
Skip to content
ARROW-14166: [C++] update vcpkg builtin baseline - #11266
Closed
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed
ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Conversation
@coryan
@coryancoryan
commented
Sep 29, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166
@coryan
coryan
marked this pull request as ready for review
September 29, 2021 14:08
@coryan
coryan
commented
Sep 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.
@kou
kou
commented
Sep 29, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c
Submitted crossbow builds: ursacomputing/crossbow @ actions-861
TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Sep 30, 2021

Copy link


Copy Markdown

Member
Umm, there are some failures... I'm not sure the failures are related to this change...
@ianmcook Could you confirm this change?
@coryan
coryan
commented
Sep 30, 2021

Copy link


Copy Markdown

ContributorAuthor
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.
@ianmcook
ianmcook
commented
Oct 1, 2021

Copy link


Copy Markdown

Member
Thanks for working on this @coryan!
test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.
@ianmcook
ianmcook
commented
Oct 3, 2021•

edited

Loading

Copy link


Copy Markdown

Member
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail
@coryan
coryan
commented
Oct 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?
@kou
kou
commented
Oct 5, 2021

Copy link


Copy Markdown

Member
@ianmcook Could you dig into the linker issue?
@ianmcook
ianmcook
commented
Oct 8, 2021

Copy link


Copy Markdown

Member
Jira for the linker error is ARROW-14260.
@coryan
coryan
commented
Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Is there something else I should do in this PR or can we merge it?
@kou
kou
commented
Oct 15, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 15, 2021

Copy link


Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec
Submitted crossbow builds: ursacomputing/crossbow @ actions-971
TaskStatus
test-build-vcpkg-winGithub Actions
@coryan
coryan
commented
Oct 26, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased, looks like there was a related change a few days ago.
@kou
kou
commented
Oct 26, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

Revision: 154c3af
Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
TaskStatus
test-build-vcpkg-winGithub Actions
kou
kou
approved these changes
Oct 28, 2021
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@koukou
closed this
in
61be051Oct 28, 2021
@ursabot
ursabot
commented
Oct 28, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14166-update-vcpkg-builtin-baseline

branch
October 28, 2021 01:05
@asfimportasfimport
mentioned this pull request
Oct 28, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-14166: [C++] update vcpkg builtin baseline by coryan · Pull Request #11266 · apache/arrow · GitHub
Skip to content
ARROW-14166: [C++] update vcpkg builtin baseline - #11266
Closed
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed
ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Conversation
@coryan
@coryancoryan
commented
Sep 29, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166
@coryan
coryan
marked this pull request as ready for review
September 29, 2021 14:08
@coryan
coryan
commented
Sep 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.
@kou
kou
commented
Sep 29, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c
Submitted crossbow builds: ursacomputing/crossbow @ actions-861
TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Sep 30, 2021

Copy link


Copy Markdown

Member
Umm, there are some failures... I'm not sure the failures are related to this change...
@ianmcook Could you confirm this change?
@coryan
coryan
commented
Sep 30, 2021

Copy link


Copy Markdown

ContributorAuthor
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.
@ianmcook
ianmcook
commented
Oct 1, 2021

Copy link


Copy Markdown

Member
Thanks for working on this @coryan!
test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.
@ianmcook
ianmcook
commented
Oct 3, 2021•

edited

Loading

Copy link


Copy Markdown

Member
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail
@coryan
coryan
commented
Oct 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?
@kou
kou
commented
Oct 5, 2021

Copy link


Copy Markdown

Member
@ianmcook Could you dig into the linker issue?
@ianmcook
ianmcook
commented
Oct 8, 2021

Copy link


Copy Markdown

Member
Jira for the linker error is ARROW-14260.
@coryan
coryan
commented
Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Is there something else I should do in this PR or can we merge it?
@kou
kou
commented
Oct 15, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 15, 2021

Copy link


Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec
Submitted crossbow builds: ursacomputing/crossbow @ actions-971
TaskStatus
test-build-vcpkg-winGithub Actions
@coryan
coryan
commented
Oct 26, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased, looks like there was a related change a few days ago.
@kou
kou
commented
Oct 26, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

Revision: 154c3af
Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
TaskStatus
test-build-vcpkg-winGithub Actions
kou
kou
approved these changes
Oct 28, 2021
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@koukou
closed this
in
61be051Oct 28, 2021
@ursabot
ursabot
commented
Oct 28, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14166-update-vcpkg-builtin-baseline

branch
October 28, 2021 01:05
@asfimportasfimport
mentioned this pull request
Oct 28, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ARROW-14166: [C++] update vcpkg builtin baseline by coryan · Pull Request #11266 · apache/arrow · GitHub
Skip to content
ARROW-14166: [C++] update vcpkg builtin baseline - #11266
Closed
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed
ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Conversation
@coryan
@coryancoryan
commented
Sep 29, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166
@coryan
coryan
marked this pull request as ready for review
September 29, 2021 14:08
@coryan
coryan
commented
Sep 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.
@kou
kou
commented
Sep 29, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c
Submitted crossbow builds: ursacomputing/crossbow @ actions-861
TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Sep 30, 2021

Copy link


Copy Markdown

Member
Umm, there are some failures... I'm not sure the failures are related to this change...
@ianmcook Could you confirm this change?
@coryan
coryan
commented
Sep 30, 2021

Copy link


Copy Markdown

ContributorAuthor
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.
@ianmcook
ianmcook
commented
Oct 1, 2021

Copy link


Copy Markdown

Member
Thanks for working on this @coryan!
test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.
@ianmcook
ianmcook
commented
Oct 3, 2021•

edited

Loading

Copy link


Copy Markdown

Member
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail
@coryan
coryan
commented
Oct 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?
@kou
kou
commented
Oct 5, 2021

Copy link


Copy Markdown

Member
@ianmcook Could you dig into the linker issue?
@ianmcook
ianmcook
commented
Oct 8, 2021

Copy link


Copy Markdown

Member
Jira for the linker error is ARROW-14260.
@coryan
coryan
commented
Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Is there something else I should do in this PR or can we merge it?
@kou
kou
commented
Oct 15, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 15, 2021

Copy link


Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec
Submitted crossbow builds: ursacomputing/crossbow @ actions-971
TaskStatus
test-build-vcpkg-winGithub Actions
@coryan
coryan
commented
Oct 26, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased, looks like there was a related change a few days ago.
@kou
kou
commented
Oct 26, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

Revision: 154c3af
Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
TaskStatus
test-build-vcpkg-winGithub Actions
kou
kou
approved these changes
Oct 28, 2021
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@koukou
closed this
in
61be051Oct 28, 2021
@ursabot
ursabot
commented
Oct 28, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14166-update-vcpkg-builtin-baseline

branch
October 28, 2021 01:05
@asfimportasfimport
mentioned this pull request
Oct 28, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-14166: [C++] update vcpkg builtin baseline by coryan · Pull Request #11266 · apache/arrow · GitHub
Skip to content
ARROW-14166: [C++] update vcpkg builtin baseline - #11266
Closed
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed
ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Conversation
@coryan
@coryancoryan
commented
Sep 29, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166
@coryan
coryan
marked this pull request as ready for review
September 29, 2021 14:08
@coryan
coryan
commented
Sep 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.
@kou
kou
commented
Sep 29, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c
Submitted crossbow builds: ursacomputing/crossbow @ actions-861
TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Sep 30, 2021

Copy link


Copy Markdown

Member
Umm, there are some failures... I'm not sure the failures are related to this change...
@ianmcook Could you confirm this change?
@coryan
coryan
commented
Sep 30, 2021

Copy link


Copy Markdown

ContributorAuthor
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.
@ianmcook
ianmcook
commented
Oct 1, 2021

Copy link


Copy Markdown

Member
Thanks for working on this @coryan!
test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.
@ianmcook
ianmcook
commented
Oct 3, 2021•

edited

Loading

Copy link


Copy Markdown

Member
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail
@coryan
coryan
commented
Oct 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?
@kou
kou
commented
Oct 5, 2021

Copy link


Copy Markdown

Member
@ianmcook Could you dig into the linker issue?
@ianmcook
ianmcook
commented
Oct 8, 2021

Copy link


Copy Markdown

Member
Jira for the linker error is ARROW-14260.
@coryan
coryan
commented
Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Is there something else I should do in this PR or can we merge it?
@kou
kou
commented
Oct 15, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 15, 2021

Copy link


Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec
Submitted crossbow builds: ursacomputing/crossbow @ actions-971
TaskStatus
test-build-vcpkg-winGithub Actions
@coryan
coryan
commented
Oct 26, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased, looks like there was a related change a few days ago.
@kou
kou
commented
Oct 26, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

Revision: 154c3af
Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
TaskStatus
test-build-vcpkg-winGithub Actions
kou
kou
approved these changes
Oct 28, 2021
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@koukou
closed this
in
61be051Oct 28, 2021
@ursabot
ursabot
commented
Oct 28, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14166-update-vcpkg-builtin-baseline

branch
October 28, 2021 01:05
@asfimportasfimport
mentioned this pull request
Oct 28, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
ARROW-14166: [C++] update vcpkg builtin baseline by coryan · Pull Request #11266 · apache/arrow · GitHub
Skip to content
ARROW-14166: [C++] update vcpkg builtin baseline - #11266
Closed
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Closed
ARROW-14166: [C++] update vcpkg builtin baseline#11266
coryan wants to merge 1 commit into
apache:masterfrom 
coryan:ARROW-14166-update-vcpkg-builtin-baseline
Conversation
@coryan
@coryancoryan
commented
Sep 29, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14166
@coryan
coryan
marked this pull request as ready for review
September 29, 2021 14:08
@coryan
coryan
commented
Sep 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Tested locally with archery docker run python-wheel-manylinux-2014. The CI failure looks like a timeout, if there is something I can do to avoid the timeout please let me know.
@kou
kou
commented
Sep 29, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit -g nightly
@github-actions
github-actionsBot
commented
Sep 29, 2021

Copy link


Copy Markdown

Revision: f84f7331a210ca8f1a3ce7be648027a0b930096c
Submitted crossbow builds: ursacomputing/crossbow @ actions-861
TaskStatus
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-dask-latestGithub Actions
test-conda-python-3.7-dask-masterGithub Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-branch-3.0Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-masterGithub Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-big-sur-py38-arm64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@kou
kou
commented
Sep 30, 2021

Copy link


Copy Markdown

Member
Umm, there are some failures... I'm not sure the failures are related to this change...
@ianmcook Could you confirm this change?
@coryan
coryan
commented
Sep 30, 2021

Copy link


Copy Markdown

ContributorAuthor
If you think rebasing or running some tests locally can help troubleshoot this I am happy to do so.
@ianmcook
ianmcook
commented
Oct 1, 2021

Copy link


Copy Markdown

Member
Thanks for working on this @coryan!
test-build-vcpkg-win first started failing in the nightly Crossbow job on September 10. I have been away for some of the time since then and haven't had a chance to dig in and determine the cause. I'll try to find some time today or tomorrow to do that. We should try to get that test to pass before merging this.
@ianmcook
ianmcook
commented
Oct 3, 2021•

edited

Loading

Copy link


Copy Markdown

Member
I opened ARROW-14208 to fix the issue that's causing test-build-vcpkg-win to fail
@coryan
coryan
commented
Oct 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to pick the fixes for ARROW-14208, though it seems that there is a separate link problem that we should wait for too?
@kou
kou
commented
Oct 5, 2021

Copy link


Copy Markdown

Member
@ianmcook Could you dig into the linker issue?
@ianmcook
ianmcook
commented
Oct 8, 2021

Copy link


Copy Markdown

Member
Jira for the linker error is ARROW-14260.
@coryan
coryan
commented
Oct 13, 2021

Copy link


Copy Markdown

ContributorAuthor
Is there something else I should do in this PR or can we merge it?
@kou
kou
commented
Oct 15, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 15, 2021

Copy link


Copy Markdown

Revision: db56ecb6d2b213b0b1931d1735c0c1f24f607aec
Submitted crossbow builds: ursacomputing/crossbow @ actions-971
TaskStatus
test-build-vcpkg-winGithub Actions
@coryan
coryan
commented
Oct 26, 2021•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Rebased, looks like there was a related change a few days ago.
@kou
kou
commented
Oct 26, 2021

Copy link


Copy Markdown

Member
@github-actions crossbow submit test-build-vcpkg-win
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

Revision: 154c3af
Submitted crossbow builds: ursacomputing/crossbow @ actions-1051
TaskStatus
test-build-vcpkg-winGithub Actions
kou
kou
approved these changes
Oct 28, 2021
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@koukou
closed this
in
61be051Oct 28, 2021
@ursabot
ursabot
commented
Oct 28, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 4c2a8dd and contender = 61be051. 61be051 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️1.03% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.45% ⬆️0.0%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14166-update-vcpkg-builtin-baseline

branch
October 28, 2021 01:05
@asfimportasfimport
mentioned this pull request
Oct 28, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@coryan@kou@ianmcook@ursabot