Skip to content

ARROW-14167: [C++][R] Directly support dictionaries in coalesce - #11272

Closed
lidavidm wants to merge 8 commits into
apache:masterfrom
lidavidm:arrow-14167
Closed

ARROW-14167: [C++][R] Directly support dictionaries in coalesce#11272
lidavidm wants to merge 8 commits into
apache:masterfrom
lidavidm:arrow-14167

Conversation

@lidavidm

@lidavidmlidavidm commented Sep 29, 2021

Copy link
Copy Markdown
Member

This was omitted from ARROW-13390. Note that even after this, there's work for ARROW-14105 to unify the type promotion rules and make them apply to dictionary indices/values as well. Contains some changes from ARROW-13358 and also updates case_when's promotion rules a bit.

@github-actions

github-actionsBot commented Sep 29, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14167

@github-actions

github-actionsBot commented Sep 29, 2021

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidmlidavidm mentioned this pull request Sep 29, 2021
Closed
@pitrou

pitrou commented Oct 4, 2021

Copy link
Copy Markdown
Member

Of course, this needs rebasing now :-)

@lidavidm
lidavidmforce-pushed the arrow-14167 branch 2 times, most recently from b3f22ff to 2442c35CompareOctober 5, 2021 15:17
@lidavidm

lidavidm commented Oct 5, 2021

Copy link
Copy Markdown
MemberAuthor

Rebased (looks like MacOS/Travis tests are failing because of Homebrew/thirdparty dependencies)

@ianmcook

ianmcook commented Nov 9, 2021

Copy link
Copy Markdown
Member

I pushed an addition to the R tests that verifies that this works from the R bindings.

@ianmcookianmcook changed the title ARROW-14167: [C++] Directly support dictionaries in coalesceARROW-14167: [C++][R] Directly support dictionaries in coalesceNov 9, 2021
@lidavidm

lidavidm commented Nov 9, 2021

Copy link
Copy Markdown
MemberAuthor

Great, thanks Ian!

pitrou
pitrou approved these changes Nov 10, 2021
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thank you!

@ursabot

ursabot commented Nov 10, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = bb776d8 and contender = 575a437. 575a437 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.53%] ursa-i9-9960x
[Finished ⬇️0.13% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@lidavidm
lidavidm deleted the arrow-14167 branch November 10, 2021 14:11
@asfimportasfimport mentioned this pull request Nov 11, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: C++Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lidavidm@pitrou@ianmcook@ursabot