Skip to content

ARROW-14197: [C++][Compute] Fixing wrong buffer size in GrouperFastImpl - #11335

Closed
michalursa wants to merge 1 commit into
apache:masterfrom
michalursa:ARROW-14197-tpch-hang
Closed

ARROW-14197: [C++][Compute] Fixing wrong buffer size in GrouperFastImpl#11335
michalursa wants to merge 1 commit into
apache:masterfrom
michalursa:ARROW-14197-tpch-hang

Conversation

@michalursa

@michalursamichalursa commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Fixing wrong buffer size in GrouperFastImpl (introduced in recent refactoring of SwissTable that introduced "find" method).
Also adding markers at the start and end of each temporary vector to check buffer overruns in the future.

@github-actions

github-actionsBot commented Oct 6, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14197

@github-actions

github-actionsBot commented Oct 6, 2021

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@michalursa
michalursaforce-pushed the ARROW-14197-tpch-hang branch from 0190eb9 to f429b93CompareOctober 6, 2021 05:28
@pitrou

pitrou commented Oct 6, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g cpp

@github-actions

github-actionsBot commented Oct 6, 2021

Copy link
Copy Markdown

Revision: f429b93eaf9958fc74af93ebc787254a3fdb16d2

Submitted crossbow builds: ursacomputing/crossbow @ actions-895

TaskStatus
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-debian-11-cppGithub Actions
test-fedora-33-cppGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions

bkietz
bkietz requested changes Oct 7, 2021
View reviewed changes

@bkietzbkietz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, modulo a naming nit and a comment

Comment threadcpp/src/arrow/compute/exec/util.h Outdated
Comment threadcpp/src/arrow/compute/exec/util.h Outdated
@michalursa
michalursaforce-pushed the ARROW-14197-tpch-hang branch from f429b93 to 1702c85CompareOctober 7, 2021 20:51
@michalursa
michalursa requested a review from bkietzOctober 7, 2021 23:06
@ursabot

ursabot commented Oct 12, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 4f0ac50 and contender = 5f80ddc. 5f80ddc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.36% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️2.78% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@asfimportasfimport mentioned this pull request Oct 13, 2021
Closed
@felipecrvfelipecrv mentioned this pull request May 16, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkietzbkietzAwaiting requested review from bkietz
1 more reviewer
@felipeblazingfelipeblazingfelipeblazing approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michalursa@pitrou@ursabot@bkietz@felipeblazing