Skip to content

ARROW-14283: [CI][C++] Use LLVM 12 on macOS GHA builds - #11379

Closed
pitrou wants to merge 2 commits into
apache:masterfrom
pitrou:ARROW-14283-mac-os-gha
Closed

ARROW-14283: [CI][C++] Use LLVM 12 on macOS GHA builds#11379
pitrou wants to merge 2 commits into
apache:masterfrom
pitrou:ARROW-14283-mac-os-gha

Conversation

@pitrou

@pitroupitrou commented Oct 11, 2021

Copy link
Copy Markdown
Member

This is a workaround. Real fix is ARROW-14265/#11374.

Workaround failure to find LLVM during the CMake config step.
@pitrou
pitrou requested review from kou and xhochyOctober 11, 2021 14:38
@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou

kou commented Oct 11, 2021

Copy link
Copy Markdown
Member

We can use the following as workaround of this:

diff --git a/cpp/Brewfile b/cpp/Brewfile
index 78ee5e64c..a96f786fb 100644
--- a/cpp/Brewfile+++ b/cpp/Brewfile@@ -25,7 +25,7 @@ brew "flatbuffers"
brew "git"
brew "glog"
brew "grpc"
-brew "llvm"+brew "llvm@12"
brew "llvm@8"
brew "lz4"
brew "minio"

@pitrou

Copy link
Copy Markdown
MemberAuthor

@kou Feel free to push it here :-)

@koukou changed the title ARROW-14283: [CI][C++] Disable Gandiva on macOS GHA buildsARROW-14283: [CI][C++] Use LLVM 12 on macOS GHA buildsOct 12, 2021
kou
kou approved these changes Oct 12, 2021

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

MinGW failure is unrelated.

@koukou closed this in fd58656Oct 12, 2021
@ursabot

ursabot commented Oct 12, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = b01a30a and contender = fd58656. fd58656 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@pitrou
pitrou deleted the ARROW-14283-mac-os-gha branch October 12, 2021 08:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou@kou@ursabot