ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550

Closed
coryan wants to merge 3 commits into
apache:masterfrom
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed

ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes

Conversation

@coryan

@coryancoryan commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Oct 26, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346

@coryan
coryan marked this pull request as ready for review October 26, 2021 21:54
@kszucs
kszucs requested a review from pitrouOctober 27, 2021 11:31
@coryan

coryan commented Oct 29, 2021

Copy link
Copy Markdown
ContributorAuthor

Rebased to resolve conflicts.

pitrou
pitrou reviewed Nov 1, 2021
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.

Comment threadcpp/src/arrow/filesystem/gcsfs.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

Comment threadcpp/src/arrow/filesystem/gcsfs.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.

Comment threadcpp/src/arrow/filesystem/gcsfs.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:

ARROW_GCS_RETURN_NOT_OK(stream.last_status());

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.

Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:

https://cloud.google.com/storage/docs/json_api/v1/objects

It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷

I have changed them, I can change them back.

@pitroupitrouNov 4, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.

As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.

Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:

https://cloud.google.com/storage/docs/metadata#custom-metadata

Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc Outdated

@pitroupitrouNov 1, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.

@coryancoryanNov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@coryan

coryan commented Nov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

PTAL

pitrou
pitrou approved these changes Nov 8, 2021
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !

@pitroupitrou closed this in 2eafc60Nov 8, 2021
@ursabot

ursabot commented Nov 8, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan
coryan deleted the ARROW-14346-implement-GcsFileSystem-streaming-writes branch November 8, 2021 15:24
@asfimportasfimport mentioned this pull request Nov 9, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream - #11550
Closed
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Closed
ARROW-14346: [C++] Implement GcsFileSystem::OpenOutputStream#11550
coryan wants to merge 3 commits into
apache:masterfrom 
coryan:ARROW-14346-implement-GcsFileSystem-streaming-writes
Conversation
@coryan
@coryancoryan
commented
Oct 26, 2021

Copy link


Copy Markdown

Contributor
 No description provided. 
@github-actions
github-actionsBot
commented
Oct 26, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14346
@coryan
coryan
marked this pull request as ready for review
October 26, 2021 21:54
@kszucs
kszucs
requested a review
from pitrouOctober 27, 2021 11:31
@coryan
coryan
commented
Oct 29, 2021

Copy link


Copy Markdown

ContributorAuthor
Rebased to resolve conflicts.
pitrou
pitrou
reviewed
Nov 1, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @coryan . Here are some comments.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears tell_ is never updated anywhere. Should you do it in Write perhaps?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does last_status also clear the error status or is it sticky? If it's sticky, then a failed Write would also return an error when calling Close?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sticky. And yes, a failed Write() will make subsequent Close() fail. It is unadvisable to finalize a stream that failed, you don't know what is its state.
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to define a macro that would allow you to write:
ARROW_GCS_RETURN_NOT_OK(stream.last_status());
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can write Result<gcs::EncryptionKey>
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is absl already an include-time dependency of GCS?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Some Abseil types are exposed in the public API for google-cloud-cpp.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a particular reason for using this casing? The S3 implementation uses "Cache-Control", "Content-Type", etc., so I'd rather keep the same exact naming rather than reinvent another.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the names of the fields in the GCS metadata:
https://cloud.google.com/storage/docs/json_api/v1/objects
It seems odd to make them match the protocol headers over HTTP (and the S3 API at that), 🤷
I have changed them, I can change them back.
@pitroupitrouNov 4, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the concern here is to have a common vocabulary where possible. If the user can spell {"Content-Type": "text/html"} regardless of the filesystem type, it's better than having to special-case the metadata key name.
As for the exact spelling, well, S3 has the precedence here since it was implemented first :-) The fact that the names may also match HTTP header names actually makes them well-known to users, so that's not a problem IMHO.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but why not std::unordered_map?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done.
Comment threadcpp/src/arrow/filesystem/gcsfs_internal.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to allow inserting arbitrary metadata strings? Will GCS balk if the user throws some unrecognized metadata keys here?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GCS accepts (mostly) arbitrary metadata keys:
https://cloud.google.com/storage/docs/metadata#custom-metadata
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps choose those string sizes so that they are not multiples of the underlying buffer size?
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
Comment threadcpp/src/arrow/filesystem/gcsfs_test.cc
Outdated

@pitroupitrouNov 1, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: buffer should never be null in this context. If it is, it's a bug in Read.
@coryancoryanNov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.
@coryan
coryan
commented
Nov 4, 2021

Copy link


Copy Markdown

ContributorAuthor
PTAL
pitrou
pitrou
approved these changes
Nov 8, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the update @coryan !
@pitroupitrou
closed this
in
2eafc60Nov 8, 2021
@ursabot
ursabot
commented
Nov 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 1420544 and contender = 2eafc60. 2eafc60 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.67% ⬆️0.04%] ursa-thinkcentre-m75q

Supported benchmarks:

ursa-i9-9960x: langs = Python, R, JavaScript

ursa-thinkcentre-m75q: langs = C++, Java

ec2-t3-xlarge-us-east-2: cloud = True
@coryan
coryan
deleted the

ARROW-14346-implement-GcsFileSystem-streaming-writes

branch
November 8, 2021 15:24
@asfimportasfimport
mentioned this pull request
Nov 9, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou