') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ARROW-14171: [C++][Python][Packaging] Upgrade VCPKG version and add google-cloud-cpp dependency by coryan · Pull Request #11569 · apache/arrow · GitHub
Skip to content

ARROW-14171: [C++][Python][Packaging] Upgrade VCPKG version and add google-cloud-cpp dependency - #11569

Closed
coryan wants to merge 33 commits into
apache:masterfrom
coryan:ARROW-14171-add-google-cloud-cpp-package
Closed

ARROW-14171: [C++][Python][Packaging] Upgrade VCPKG version and add google-cloud-cpp dependency#11569
coryan wants to merge 33 commits into
apache:masterfrom
coryan:ARROW-14171-add-google-cloud-cpp-package

Conversation

@coryan

@coryancoryan commented Oct 28, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Oct 28, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14171

@coryan
coryan marked this pull request as ready for review October 28, 2021 17:48
@kou

kou commented Oct 28, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g nightly

@github-actions

github-actionsBot commented Oct 28, 2021

Copy link
Copy Markdown

Revision: 7f69cf410b42194a7fffb4687835a08c4bf3c3f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-1059

TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
amazon-linux-2-amd64Github Actions
centos-7-amd64Github Actions
centos-8-amd64Github Actions
centos-8-arm64TravisCI
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py36-arm64Azure
conda-linux-gcc-py36-cpu-r40Azure
conda-linux-gcc-py36-cudaAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py36-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2017-py36-r40Azure
conda-win-vs2017-py37-r41Azure
conda-win-vs2017-py38Azure
conda-win-vs2017-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
debian-buster-amd64Github Actions
debian-buster-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.6Github Actions
test-conda-python-3.6-pandas-0.23Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-11-cppGithub Actions
test-debian-11-go-1.15Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-33-cppGithub Actions
test-fedora-33-python-3Azure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-autoAzure
test-r-depsource-systemGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-3.6-bionicAzure
test-r-rstudio-r-base-3.6-centos7-devtoolset-8Azure
test-r-rstudio-r-base-3.6-centos8Azure
test-r-rstudio-r-base-3.6-opensuse15Azure
test-r-rstudio-r-base-3.6-opensuse42Azure
test-r-ubuntu-21.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-python-3Azure
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-14Github Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.10-docsAzure
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-hirsute-amd64Github Actions
ubuntu-hirsute-arm64TravisCI
ubuntu-impish-amd64Github Actions
ubuntu-impish-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@coryan

coryan commented Nov 2, 2021

Copy link
Copy Markdown
ContributorAuthor

Ping? Is there something else I need to do here?

@pitrou
pitrou requested a review from kszucsNovember 3, 2021 12:34
@kou

kou commented Nov 4, 2021

Copy link
Copy Markdown
Member

It seems that this is a problem.

https://github.com/ursacomputing/crossbow/runs/4039103923?check_suite_focus=true#step:6:1189

#12 14.69 Package google-cloud-cpp does not have a storage feature

@coryan
ARROW-14171: [C++] add google-cloud-cpp to vcpkg
b7bb816
@coryan
Revent changes to osx Jinja template
8b6755d
I probably do not understand how these are used, probably something for
later.
@coryan

coryan commented Nov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

I see. The code checks out version 2021.04.30:

arrow/.env

Line 75 in faf8b82

VCPKG="2021.04.30"

That version does not include the storage feature, neither does the latest tag at 2021.05.12.

How do you feel about pinning vcpkg to a specific SHA, but not to a tag?

@kou

kou commented Nov 4, 2021

Copy link
Copy Markdown
Member

How do you feel about pinning vcpkg to a specific SHA, but not to a tag?

@ianmcook@kszucs What do you think about this?

@kszucs

kszucs commented Nov 4, 2021

Copy link
Copy Markdown
Member

We used to pin specific SHAs beforehand, so it's fine.

@coryan

coryan commented Nov 4, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks, I have updated this PR accordingly. I also sent ursacomputing/crossbow#6 for review, I am not sure which one should be merged first, please let me know if I should help with that.

@kszucs

kszucs commented Nov 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Thanks! Since it affects the build cache we should wait for the 6.0.1 patch release with both of the PRs.

(technically we could already merge the crossbow PR because the vcpkg version is included in the cache key, but the github actions cache eviction policy may remove the previous artifacts)

@coryancoryan mentioned this pull request Nov 22, 2021
Merged
@kszucs

kszucs commented Nov 22, 2021

Copy link
Copy Markdown
Member

Merged the crossbow PR. I'm going to rebuild and push the windows docker images for the windows wheels then we can submit the crossbow jobs here.

@kszucs

kszucs commented Nov 23, 2021

Copy link
Copy Markdown
Member

After fixing the vcpkg/ports.patch I'm getting a vcpkg dependency problem on windows:

✖ REPO=ghcr.io/ursacomputing/arrow PYTHON=3.10 archery docker build --using-docker-cli python-wheel-windows-vs2017
Error response from daemon: manifest unknown
docker pull ghcr.io/ursacomputing/arrow:python-3.10-wheel-windows-vs2017-vcpkg-9675ab15def74a0b96d954bddc7ddabb42c92452 exited with non-zero exit code 1
Sending build context to Docker daemon 453.1kB
Step 1/19 : FROM abrarov/msvc-2017:2.10.0
---> 48bb8164f545
Step 2/19 : RUN choco install --no-progress -r -y cmake --installargs 'ADD_CMAKE_TO_PATH=System' && choco install --no-progress -r -y gzip wget ninja
---> Using cache
---> 84da6558371c
Step 3/19 : RUN setx path "%path%;C:\Program Files\Git\usr\bin"
---> Using cache
---> 744f355e6df4
Step 4/19 : ARG vcpkg
---> Using cache
---> 6fd7cae10c08
Step 5/19 : RUN git clone https://github.com/Microsoft/vcpkg && vcpkg\bootstrap-vcpkg.bat -disableMetrics && setx PATH "%PATH%;C:\vcpkg" && git -C vcpkg checkout %vcpkg%
---> Using cache
---> a85f4b3090f6
Step 6/19 : COPY ci/vcpkg/*.patch ci/vcpkg/*windows*.cmake arrow/ci/vcpkg/
---> Using cache
---> cdc9fbfb7e6e
Step 7/19 : RUN cd vcpkg && git apply --ignore-whitespace C:/arrow/ci/vcpkg/ports.patch
---> Using cache
---> c93972ad92dc
Step 8/19 : ARG build_type=release
---> Using cache
---> c130e80c70b8
Step 9/19 : ENV CMAKE_BUILD_TYPE=${build_type} VCPKG_OVERLAY_TRIPLETS=C:\\arrow\\ci\\vcpkg VCPKG_DEFAULT_TRIPLET=x64-windows-static-md-${build_type} VCPKG_FEATURE_FLAGS=-manifests
---> Using cache
---> e7a18a9e6535
Step 10/19 : RUN vcpkg install --clean-after-build abseil aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer] boost-filesystem boost-multiprecision boost-system brotli bzip2 c-ares curl flatbuffers gflags glog google-cloud-cpp[core,storage] grpc lz4 openssl orc protobuf rapidjson re2 snappy thrift utf8proc zlib zstd
---> Running in 3c89420370c9
Computing installation plan...
Error: aws-checksums[core] is only supported on '!arm & !windows'
The command 'cmd /S /C vcpkg install --clean-after-build abseil aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer] boost-filesystem boost-multiprecision boost-system brotli bzip2 c-ares curl flatbuffers gflags glog google-cloud-cpp[core,storage] grpc lz4 openssl orc protobuf rapidjson re2 snappy thrift utf8proc zlib zstd' returned a non-zero code: 1
Error: docker build --build-arg BUILDKIT_INLINE_CACHE=1 --build-arg python=3.10 --build-arg vcpkg=9675ab15def74a0b96d954bddc7ddabb42c92452 -f ci/docker/python-wheel-windows-vs2017.dockerfile -t ghcr.io/ursacomputing/arrow:python-3.10-wheel-windows-vs2017-vcpkg-9675ab15def74a0b96d954bddc7ddabb42c92452 /Users/kszucs/Workspace/arrow exited with non-zero exit code 1

It has been already resolved upstream, so I pinned the HEAD commit.

@kszucskszucs mentioned this pull request Nov 24, 2021
Merged
@kszucs

kszucs commented Nov 24, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Nov 24, 2021

Copy link
Copy Markdown

Revision: 47e8935

Submitted crossbow builds: ursacomputing/crossbow @ actions-1170

TaskStatus
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@kszucs

kszucs commented Nov 24, 2021•
edited
Loading

Copy link
Copy Markdown
Member

New changes:

  • bumped the vcpkg version to make the aws-sdk-cpp compile on windows
  • updated to use the install_vcpkg.sh script everywhere (including the windows docker images)
  • removed the duplicated vcpkg versions across the build configs, now it uses VCPKG version from .env

Still, We have several problems here:

  1. CMake 3.22.0 has a regression causing issue with AWSSDKConfig.cmake. We need to pin 3.21.4 both on macOS and manylinux.
  2. Manylinux2010 doesn't have realpath so we need to switch to readlink -f in the install_vcpkg.sh script.
  3. The vcpkg installer now downloads a prebuilt binary instead of compiling the vcpkg tool itself locally but the binary links with >glibc 2.14 and the manylinux2010 image has glibc=2.12. I patched the bootstrap.sh script to force build vcpkg but getting many ambiguous calls errors during compilation. @pitrou perhaps it would be the right time to drop the EOL manylinux2010 packages.
  4. The aws-sdk-cpp packages are restricted to non-arm architectures despite that earlier versions used to work. I assume patching the port files with a new constraint would work.

@kszucskszucs mentioned this pull request Nov 25, 2021
Closed
@kszucs

kszucs commented Nov 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit wheel-macos-big-sur-*-universal2

@github-actions

github-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown

Revision: c9bfce9

Submitted crossbow builds: ursacomputing/crossbow @ actions-1201

TaskStatus
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions

@kszucs

kszucs commented Nov 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@kszucs

kszucs commented Nov 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown

Revision: f8c7af4

Submitted crossbow builds: ursacomputing/crossbow @ actions-1202

TaskStatus
wheel-macos-big-sur-cp39-universal2Github Actions

@github-actions

github-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown

Revision: f8c7af4

Submitted crossbow builds: ursacomputing/crossbow @ actions-1203

TaskStatus
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@kszucs

kszucs commented Nov 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@github-actions

github-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown

Revision: 0662793

Submitted crossbow builds: ursacomputing/crossbow @ actions-1205

TaskStatus
wheel-macos-big-sur-cp39-universal2Github Actions

@kszucs

kszucs commented Nov 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit wheel-macos-big-sur-cp39-universal2

@github-actions

github-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown

Revision: 283d7a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-1206

TaskStatus
wheel-macos-big-sur-cp39-universal2Github Actions

@kszucs

kszucs commented Nov 26, 2021

Copy link
Copy Markdown
Member

@github-actions crossbow submit -g wheel

@github-actions

github-actionsBot commented Nov 26, 2021

Copy link
Copy Markdown

Revision: 283d7a8

Submitted crossbow builds: ursacomputing/crossbow @ actions-1207

TaskStatus
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp36-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp36-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp36-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp36-amd64Github Actions
wheel-manylinux2014-cp36-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp36-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@coryan

coryan commented Nov 26, 2021

Copy link
Copy Markdown
ContributorAuthor

@coryan we don't yet have python bindings for GCS, right?

If you mean in Arrow, then no, they do not exist yet. I had no plans to create them either.

@pitrou

pitrou commented Nov 26, 2021

Copy link
Copy Markdown
Member

If you mean in Arrow, then no, they do not exist yet. I had no plans to create them either.

That's something that other contributors can do :-)

@kszucs

kszucs commented Nov 29, 2021

Copy link
Copy Markdown
Member

Added a note about enabling the GCS feature in the wheels for https://issues.apache.org/jira/browse/ARROW-14892

@pitrou this should be ready for review then

pitrou
pitrou reviewed Nov 29, 2021
View reviewed changes
Comment threadci/docker/python-wheel-manylinux-201x.dockerfile
Comment threadci/scripts/install_glibc.sh Outdated
pitrou
pitrou reviewed Nov 30, 2021
View reviewed changes
Comment threadci/docker/python-wheel-manylinux-201x.dockerfile
vcpkg install --clean-after-build \
abseil \
aws-sdk-cpp[config,cognito-identity,core,identity-management,s3,sts,transfer] \
boost-filesystem \

@pitroupitrouNov 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we still need boost-filesystem here? AFAIR the dependency is only for unit tests.

@kszucskszucsNov 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to create a follow-up to remove it.

@kszucskszucsNov 30, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://issues.apache.org/jira/browse/ARROW-14928

@kszucskszucs closed this in 2233ac5Dec 1, 2021
@ursabot

ursabot commented Dec 1, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 736a69e and contender = 2233ac5. 2233ac5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.13%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@coryan
coryan deleted the ARROW-14171-add-google-cloud-cpp-package branch December 1, 2021 18:36
@asfimportasfimport mentioned this pull request Dec 2, 2021
Closed
@asfimportasfimport mentioned this pull request Jul 4, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou left review comments
@kszucskszucskszucs approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@coryan@kou@kszucs@pitrou@ursabot