ARROW-13643: [C++][Compute] Implement outer join with support for residual predicates

[save-buffer]

Implements residual predicates on hash join

[github-actions]

https://issues.apache.org/jira/browse/ARROW-13643

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[save-buffer]

The CI failure seems to be a failure with failing to download python 3.1 (https://discuss.python.org/t/disappearing-macos-packages-on-python-org/11737), which is unrelated to this PR.

[bkietz]

Thanks for doing this! I'm still reading this PR, but I've got a few minor comments now

[westonpace]

Looks pretty good. I'm surprised this only required one additional test as there is a fair amount of nuance here but it is possible that some of these situations are being covered by the existing tests.

[save-buffer]

The failures seem to be due to conda having a bad time:

UserAgent: aws-sdk-cpp/1.8.74/S3/Linux/5.11.0-1020-azure x86_64 GCC/7.5.0
Error: mkdir /tmp/s3fs-test-4m9eos07/bucket/somefile/: file exists (*fs.PathError)
4: cmd/api-errors.go:2082:cmd.toAPIErrorCode()
3: cmd/api-errors.go:2107:cmd.toAPIError()
2: cmd/object-handlers.go:1801:cmd.objectAPIHandlers.PutObjectHandler()
1: net/http/server.go:2046:http.HandlerFunc.ServeHTTP()

Don't think it's related to me. I'll try rebasing in a couple days and maybe the checks will pass.

[westonpace]

Looks good, just a few nits from me.

[westonpace]

@bkietz did you want to look over this one more time? Otherwise I think we can merge.

[save-buffer]

[ RUN ] TestArrowReadDeltaEncoding.DeltaByteArray
unknown file: Failure
C++ exception with description "IOError: Failed to open local file '/arrow/cpp/submodules/parquet-testing/data/delta_byte_array.parquet'. Detail: [errno 2] No such file or directory" thrown in the test body.

These failures don't appear to be me.

[lidavidm]

[ RUN ] TestArrowReadDeltaEncoding.DeltaByteArray
unknown file: Failure
C++ exception with description "IOError: Failed to open local file '/arrow/cpp/submodules/parquet-testing/data/delta_byte_array.parquet'. Detail: [errno 2] No such file or directory" thrown in the test body.

These failures don't appear to be me.

Hmm, it seems this PR modifies the parquet-testing submodule - perhaps it needs to be rebased/something happened during the last rebase?

[save-buffer]

Yeah that seems like what happened. I guess I still need some practice with rebasing 😅 I went with the nuclear option and squashed my commits and removed the change to the testing directory, so hopefully it'll be good now.

[lidavidm]

Ok, looks like these last two failures/timeouts are not related. Thanks for the updates!

[ursabot]

Benchmark runs are scheduled for baseline = 72f7fbe and contender = 4913352. 4913352 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.53% ⬆️0.22%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True