Skip to content

ARROW-13886 [R] Expand documentation for decimal() - #11758

Closed
dragosmg wants to merge 11 commits into
apache:masterfrom
dragosmg:ARROW-13886_decimal_docs
Closed

ARROW-13886 [R] Expand documentation for decimal()#11758
dragosmg wants to merge 11 commits into
apache:masterfrom
dragosmg:ARROW-13886_decimal_docs

Conversation

@dragosmg

@dragosmgdragosmg commented Nov 22, 2021

Copy link
Copy Markdown
Contributor

First attempt at this. Will be followed by:

  • opening Jira tickets to:
    • deprecate decimal()
    • implement decimal128() and decimal256()
  • expand unit tests both for data types and Arrays

Tickets generated:

@github-actions

Copy link
Copy Markdown

Comment threadr/R/type.R Outdated
Comment threadr/R/type.R Outdated
Comment threadr/R/type.R Outdated
Comment threadr/R/type.R Outdated
Comment threadr/tests/testthat/test-data-type.R Outdated

@thisisnicthisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few pedantic changes but otherwise looks good. Won't approve yet as I think you're still making changes.

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looking good so far, a few questions / comments

Comment threadr/R/type.R
Comment threadr/R/type.R Outdated
Comment threadr/tests/testthat/test-data-type.R Outdated

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good — a few small comments

Comment threadr/R/type.R
Comment threadr/tests/testthat/test-data-type.R Outdated
@dragosmg

Copy link
Copy Markdown
ContributorAuthor

Raised a Jira to improve the error messaging and reverted to use the error messages as surfaced from the C++ code

Comment threadr/R/type.R
@ursabot

ursabot commented Nov 27, 2021

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 35b3567 and contender = d722f50. d722f50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] ursa-i9-9960x
[Finished ⬇️0.44% ⬆️0.0%] ursa-thinkcentre-m75q
Supported benchmarks:
ursa-i9-9960x: langs = Python, R, JavaScript
ursa-thinkcentre-m75q: langs = C++, Java
ec2-t3-xlarge-us-east-2: cloud = True

@dragosmg
dragosmg deleted the ARROW-13886_decimal_docs branch December 6, 2021 16:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@dragosmg@ursabot@jonkeane@pitrou@thisisnic