Uh oh!
There was an error while loading. Please reload this page.
ARROW-13886 [R] Expand documentation for decimal() - #11758
Conversation
…on` and `scale` + docs + updated unit tests
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
thisisnic
left a comment
There was a problem hiding this comment.
A few pedantic changes but otherwise looks good. Won't approve yet as I think you're still making changes.
jonkeane
left a comment
There was a problem hiding this comment.
Thanks for this, looking good so far, a few questions / comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jonkeane
left a comment
There was a problem hiding this comment.
Looking good — a few small comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…-13886_decimal_docs
dragosmg
commented
Nov 24, 2021
Raised a Jira to improve the error messaging and reverted to use the error messages as surfaced from the C++ code |
Uh oh!
There was an error while loading. Please reload this page.
Benchmark runs are scheduled for baseline = 35b3567 and contender = d722f50. d722f50 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
First attempt at this. Will be followed by:
decimal()decimal128()anddecimal256()ArraysTickets generated:
decimal128()- https://issues.apache.org/jira/browse/ARROW-14843decimal256()- https://issues.apache.org/jira/browse/ARROW-14844Decimal128Type&Decimal256Typein the C++ code - https://issues.apache.org/jira/browse/ARROW-14842