Uh oh!
There was an error while loading. Please reload this page.
ARROW-14914: [C++] gcsfs will not implement DeleteRootDirContents - #11829
Closed
coryan wants to merge 1 commit into
Closed
ARROW-14914: [C++] gcsfs will not implement DeleteRootDirContents#11829coryan wants to merge 1 commit into
coryan wants to merge 1 commit into
Conversation
The function is too dangerous for GCS. Leave it unimplemented, with a message that explains why, and add a test.
coryan
marked this pull request as ready for review
December 1, 2021 15:17
coryan
commented
Dec 1, 2021
ContributorAuthor
The |
pitrou
commented
Dec 2, 2021
Member
Indeed! |
Benchmark runs are scheduled for baseline = b8431fb and contender = 55ebeb3. 55ebeb3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is too dangerous for GCS. Leave it unimplemented, with a
message that explains why, and add a test.