Skip to content

ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842

Closed
coryan wants to merge 2 commits into
apache:masterfrom
coryan:ARROW-14917-gcsfs-create-dir
Closed

ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom
coryan:ARROW-14917-gcsfs-create-dir

Conversation

@coryan

@coryancoryan commented Dec 2, 2021

Copy link
Copy Markdown
Contributor

This PR implements GcsFileSystem::CreateDir. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.

@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions

github-actionsBot commented Dec 2, 2021

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917

@coryan
coryan marked this pull request as ready for review December 2, 2021 22:21
@coryan

coryan commented Dec 4, 2021

Copy link
Copy Markdown
ContributorAuthor

The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.

@pitroupitrou changed the title ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou reviewed Dec 7, 2021
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.

Comment threadcpp/src/arrow/filesystem/gcsfs.h Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.h Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.h Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.h Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.h Outdated
/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does

@pitroupitrouDec 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?

@coryancoryanDec 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.

Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷

@pitroupitrouDec 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.

@coryancoryanDec 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.

Comment threadcpp/src/arrow/filesystem/gcsfs.h Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.cc Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.cc Outdated
Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan

coryan commented Dec 7, 2021

Copy link
Copy Markdown
ContributorAuthor

Please take another look.

@pitroupitrou closed this in 01186fcDec 7, 2021
@ursabot

ursabot commented Dec 7, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Scheduled] ursa-i9-9960x
[Scheduled] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@coryan
coryan deleted the ARROW-14917-gcsfs-create-dir branch December 7, 2021 19:58
@ursabot

ursabot commented Dec 8, 2021•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@asfimportasfimport mentioned this pull request Dec 8, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir by coryan · Pull Request #11842 · apache/arrow · GitHub
Skip to content
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842
Closed
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Closed
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Conversation
@coryan
@coryancoryan
commented
Dec 2, 2021

Copy link


Copy Markdown

Contributor
This PR implements GcsFileSystem::CreateDir. I also reviewed the

documentation for the class, since now the implementation of the class,

particularly how directories are emulated, is more than just notes and

ideas.
@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions
github-actionsBot
commented
Dec 2, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917
@coryan
coryan
marked this pull request as ready for review
December 2, 2021 22:21
@coryan
coryan
commented
Dec 4, 2021

Copy link


Copy Markdown

ContributorAuthor
The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.
@pitroupitrou
changed the title
ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou
reviewed
Dec 7, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.
Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan
coryan
commented
Dec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Please take another look.
@pitroupitrou
closed this
in
01186fcDec 7, 2021
@ursabot
ursabot
commented
Dec 7, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Scheduled] ursa-i9-9960x

[Scheduled] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@coryan
coryan
deleted the

ARROW-14917-gcsfs-create-dir

branch
December 7, 2021 19:58
@ursabot
ursabot
commented
Dec 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@asfimportasfimport
mentioned this pull request
Dec 8, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir by coryan · Pull Request #11842 · apache/arrow · GitHub
Skip to content
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842
Closed
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Closed
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Conversation
@coryan
@coryancoryan
commented
Dec 2, 2021

Copy link


Copy Markdown

Contributor
This PR implements GcsFileSystem::CreateDir. I also reviewed the

documentation for the class, since now the implementation of the class,

particularly how directories are emulated, is more than just notes and

ideas.
@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions
github-actionsBot
commented
Dec 2, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917
@coryan
coryan
marked this pull request as ready for review
December 2, 2021 22:21
@coryan
coryan
commented
Dec 4, 2021

Copy link


Copy Markdown

ContributorAuthor
The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.
@pitroupitrou
changed the title
ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou
reviewed
Dec 7, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.
Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan
coryan
commented
Dec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Please take another look.
@pitroupitrou
closed this
in
01186fcDec 7, 2021
@ursabot
ursabot
commented
Dec 7, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Scheduled] ursa-i9-9960x

[Scheduled] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@coryan
coryan
deleted the

ARROW-14917-gcsfs-create-dir

branch
December 7, 2021 19:58
@ursabot
ursabot
commented
Dec 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@asfimportasfimport
mentioned this pull request
Dec 8, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir by coryan · Pull Request #11842 · apache/arrow · GitHub
Skip to content
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842
Closed
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Closed
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Conversation
@coryan
@coryancoryan
commented
Dec 2, 2021

Copy link


Copy Markdown

Contributor
This PR implements GcsFileSystem::CreateDir. I also reviewed the

documentation for the class, since now the implementation of the class,

particularly how directories are emulated, is more than just notes and

ideas.
@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions
github-actionsBot
commented
Dec 2, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917
@coryan
coryan
marked this pull request as ready for review
December 2, 2021 22:21
@coryan
coryan
commented
Dec 4, 2021

Copy link


Copy Markdown

ContributorAuthor
The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.
@pitroupitrou
changed the title
ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou
reviewed
Dec 7, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.
Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan
coryan
commented
Dec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Please take another look.
@pitroupitrou
closed this
in
01186fcDec 7, 2021
@ursabot
ursabot
commented
Dec 7, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Scheduled] ursa-i9-9960x

[Scheduled] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@coryan
coryan
deleted the

ARROW-14917-gcsfs-create-dir

branch
December 7, 2021 19:58
@ursabot
ursabot
commented
Dec 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@asfimportasfimport
mentioned this pull request
Dec 8, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir by coryan · Pull Request #11842 · apache/arrow · GitHub
Skip to content
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842
Closed
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Closed
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Conversation
@coryan
@coryancoryan
commented
Dec 2, 2021

Copy link


Copy Markdown

Contributor
This PR implements GcsFileSystem::CreateDir. I also reviewed the

documentation for the class, since now the implementation of the class,

particularly how directories are emulated, is more than just notes and

ideas.
@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions
github-actionsBot
commented
Dec 2, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917
@coryan
coryan
marked this pull request as ready for review
December 2, 2021 22:21
@coryan
coryan
commented
Dec 4, 2021

Copy link


Copy Markdown

ContributorAuthor
The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.
@pitroupitrou
changed the title
ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou
reviewed
Dec 7, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.
Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan
coryan
commented
Dec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Please take another look.
@pitroupitrou
closed this
in
01186fcDec 7, 2021
@ursabot
ursabot
commented
Dec 7, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Scheduled] ursa-i9-9960x

[Scheduled] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@coryan
coryan
deleted the

ARROW-14917-gcsfs-create-dir

branch
December 7, 2021 19:58
@ursabot
ursabot
commented
Dec 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@asfimportasfimport
mentioned this pull request
Dec 8, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir by coryan · Pull Request #11842 · apache/arrow · GitHub
Skip to content
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842
Closed
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Closed
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Conversation
@coryan
@coryancoryan
commented
Dec 2, 2021

Copy link


Copy Markdown

Contributor
This PR implements GcsFileSystem::CreateDir. I also reviewed the

documentation for the class, since now the implementation of the class,

particularly how directories are emulated, is more than just notes and

ideas.
@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions
github-actionsBot
commented
Dec 2, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917
@coryan
coryan
marked this pull request as ready for review
December 2, 2021 22:21
@coryan
coryan
commented
Dec 4, 2021

Copy link


Copy Markdown

ContributorAuthor
The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.
@pitroupitrou
changed the title
ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou
reviewed
Dec 7, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.
Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan
coryan
commented
Dec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Please take another look.
@pitroupitrou
closed this
in
01186fcDec 7, 2021
@ursabot
ursabot
commented
Dec 7, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Scheduled] ursa-i9-9960x

[Scheduled] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@coryan
coryan
deleted the

ARROW-14917-gcsfs-create-dir

branch
December 7, 2021 19:58
@ursabot
ursabot
commented
Dec 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@asfimportasfimport
mentioned this pull request
Dec 8, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir by coryan · Pull Request #11842 · apache/arrow · GitHub
Skip to content
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir - #11842
Closed
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Closed
ARROW-14917: [C++] Implement GcsFileSystem::CreateDir#11842
coryan wants to merge 2 commits into
apache:masterfrom 
coryan:ARROW-14917-gcsfs-create-dir
Conversation
@coryan
@coryancoryan
commented
Dec 2, 2021

Copy link


Copy Markdown

Contributor
This PR implements GcsFileSystem::CreateDir. I also reviewed the

documentation for the class, since now the implementation of the class,

particularly how directories are emulated, is more than just notes and

ideas.
@coryan
ARROW-14917: [C++] GcsFileSystem can create directories
df24c4b
This PR implements `GcsFileSystem::CreateDir`. I also reviewed the
documentation for the class, since now the implementation of the class,
particularly how directories are emulated, is more than just notes and
ideas.
@github-actions
github-actionsBot
commented
Dec 2, 2021

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14917
@coryan
coryan
marked this pull request as ready for review
December 2, 2021 22:21
@coryan
coryan
commented
Dec 4, 2021

Copy link


Copy Markdown

ContributorAuthor
The failure on R / AMD64 Windows R RTools 40 seems unrelated, please take a look.
@pitroupitrou
changed the title
ARROW-14917: [C++] GcsFileSystem can create directoriesARROW-14917: [C++] Implement GcsFileSystem::CreateDirDec 7, 2021
pitrou
pitrou
reviewed
Dec 7, 2021
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. A couple questions and suggestions below.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

/// directory.
/// - The class creates marker objects for a directory, using a trailing slash in the
/// marker names. For debugging purposes, the metadata and contents of these marker
/// objects indicate that they are markers created by this class. The class does
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there any de facto standard for directory metadata markers?
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of? The UI in for Google Cloud creates empty objects ending with /. The command-line utility does no such thing (e.g. gsutil cp -r deep-directory/ gs://my-bucket/foo would not create these markers). The client libraries do not create them either. Whether that amounts to a de facto standard, I cannot say.
Frankly the use of "folder emulation" causes more harm than good. It creates the impression that some things should work (e.g. directory renames, directory permissions, efficient non-recursive listing) when they don't. And the markers are sort of useless. If you want to list objects non-recursively, the API has native support for including any matching prefixes in the results, without the need for these markers 🤷
@pitroupitrouDec 7, 2021

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, my question was about the custom metadata you added to these markers.
@coryancoryanDec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhhh. No, the UI does not create any metadata, but ignores it too. I think the metadata is harmless and useful for debugging.
Comment threadcpp/src/arrow/filesystem/gcsfs.h
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
Outdated

Comment threadcpp/src/arrow/filesystem/gcsfs.cc
@coryan
coryan
commented
Dec 7, 2021

Copy link


Copy Markdown

ContributorAuthor
Please take another look.
@pitroupitrou
closed this
in
01186fcDec 7, 2021
@ursabot
ursabot
commented
Dec 7, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Scheduled] ursa-i9-9960x

[Scheduled] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@coryan
coryan
deleted the

ARROW-14917-gcsfs-create-dir

branch
December 7, 2021 19:58
@ursabot
ursabot
commented
Dec 8, 2021•

edited

Loading

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = 77722d9 and contender = 01186fc. 01186fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️1.48% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.22% ⬆️0.09%] ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@asfimportasfimport
mentioned this pull request
Dec 8, 2021

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@pitroupitroupitrou approved these changes

Assignees


No one assigned


Labels

Component: C++

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@coryan@ursabot@pitrou