Uh oh!
There was an error while loading. Please reload this page.
ARROW-15187: [Java][FlightRPC] Fix pom.xml for Flight integration tests - #12021
Closed
lidavidm wants to merge 2 commits into
Closed
ARROW-15187: [Java][FlightRPC] Fix pom.xml for Flight integration tests#12021lidavidm wants to merge 2 commits into
lidavidm wants to merge 2 commits into
Conversation
lidavidm
commented
Dec 22, 2021
MemberAuthor
cc @rafael-telles this should fix the issues in #12013. |
lidavidm
commented
Dec 22, 2021
MemberAuthor
There appears to be a Java test failure, possibly related to here in the logs: https://github.com/apache/arrow/runs/4607408784?check_suite_focus=true#step:6:10774, @rafael-telles do you have an idea of what's going on there? |
rafael-telles
commented
Dec 22, 2021
Contributor
Thanks @lidavidm ! Taking a look |
rafael-telles
commented
Dec 22, 2021
Contributor
It seems to be related to JNI, I am trying to reproduce locally. |
rafael-telles
commented
Dec 22, 2021
Contributor
@lidavidm , trying to understand what is happening here yet. Found this in the logs: This means that for some reason the parameters on a prepared statement are not being bound. I tried running the tests in a loop in case they were flaky but it didn't fail. Can we try applying this patch to see if anything pops up? diff --git a/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java b/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java
index c1ff92a379..069d59edd4 100644
--- a/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java+++ b/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlClient.java@@ -543,6 +543,7 @@ public class FlightSqlClient implements AutoCloseable {
listener.putNext();
listener.completed();
+ listener.getResult();
}
return client.getInfo(descriptor, options);
diff --git a/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java b/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java
index 634343c236..90a2aaf100 100644
--- a/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java+++ b/java/flight/flight-sql/src/test/java/org/apache/arrow/flight/sql/example/FlightSqlExample.java@@ -1270,7 +1270,10 @@ public class FlightSqlExample implements FlightSqlProducer, AutoCloseable {
}
} catch (SQLException e) {
- ackStream.onError(e);+ ackStream.onError(CallStatus.INTERNAL+ .withDescription("Failed to bind parameters: " + e.getMessage())+ .withCause(e)+ .toRuntimeException());
return;
}
ackStream.onCompleted(); |
rafael-telles
commented
Dec 22, 2021
Contributor
Actually the issue may be because it was missing that call to |
lidavidm
commented
Dec 22, 2021
MemberAuthor
Thanks, giving it a spin now. |
lidavidm
commented
Dec 22, 2021
MemberAuthor
Things look good now. Thanks for the quick fix @rafael-telles! |
lidavidm added a commit
that referenced
this pull request
Dec 22, 2021
Closes#12021 from lidavidm/flight-sql-pom Lead-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: David Li <li.davidm96@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
lidavidm pushed a commit
that referenced
this pull request
Dec 23, 2021
Implement Flight SQL in C++ and Java, and add the protocol definitions. This is a combination of multiple pull requests, merged into one branch before merging into master. Closes#10906 (ARROW-12922). Closes#11507 (ARROW-14421). Closes#11989 (ARROW-15112). Closes#12021 (ARROW-15187). Closes#12035 (ARROW-15198). Closes#12013 from apache/flight-sql Lead-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> Co-authored-by: James Duong <duong.james@gmail.com> Co-authored-by: Jose Almeida <almeidajcr90@gmail.com> Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Kyle Porter <kporter@dremio.com> Co-authored-by: Ryan Nicholson <rnicholson@dremio.com> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: tifflhl <tiffanylamhl@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
Implement Flight SQL in C++ and Java, and add the protocol definitions. This is a combination of multiple pull requests, merged into one branch before merging into master. Closesapache#10906 (ARROW-12922). Closesapache#11507 (ARROW-14421). Closesapache#11989 (ARROW-15112). Closesapache#12021 (ARROW-15187). Closesapache#12035 (ARROW-15198). Closesapache#12013 from apache/flight-sql Lead-authored-by: Rafael Telles <rafael@telles.dev> Co-authored-by: Abner Eduardo Ferreira <abenaru@protonmail.ch> Co-authored-by: James Duong <duong.james@gmail.com> Co-authored-by: Jose Almeida <almeidajcr90@gmail.com> Co-authored-by: Juscelino Junior <juscelinojunior@id.uff.br> Co-authored-by: Kyle Porter <kporter@dremio.com> Co-authored-by: Ryan Nicholson <rnicholson@dremio.com> Co-authored-by: Vinicius Fraga <sxvinifp@gmail.com> Co-authored-by: tifflhl <tiffanylamhl@gmail.com> Signed-off-by: David Li <li.davidm96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.