ARROW-15366: [Docs] Automate incrementing of package version for R and non-R version switchers

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D

[thisisnic]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-15366

[github-actions]

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

[jorisvandenbossche]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

[thisisnic]

Can you print an example of what json file the scripts outputs eg for the 7.0 release?

Certainly can. For the main docs, you manually add the dev version in the JS, right?

[
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

[thisisnic]

For the main docs, you manually add the dev version in the JS, right?

Ah, no, it would actually be good this is handled by the script as well. I added it manually last week directly in the hosted sources (apache/arrow-site#177) to get the dropdown working for the new nightly docs that were added (originally when adding the dropdown, we didn't yet have dev docs). But I should actually have ported that back to the main version of the json file in the apache/arrow repo)

Just pushed a commit which now results in this; is this what you'd expect? I also noticed that dev has no / at the end - does it matter? I construct URLs a bit differently in the R version.

[
{
"name": "8.0 (dev)",
"version": "dev"
},
{
"name": "7.0 (stable)",
"version": ""
},
{
"name": "6.0",
"version": "6.0/"
},
{
"name": "5.0",
"version": "5.0/"
},
{
"name": "4.0",
"version": "4.0/"
},
{
"name": "3.0",
"version": "3.0/"
},
{
"name": "2.0",
"version": "2.0/"
},
{
"name": "1.0",
"version": "1.0/"
}
]

[jorisvandenbossche]

Yes, that looks good!

[thisisnic]

Thanks for the feedback and suggestions here @kou !

Now entirely stuck again on test failures - the CI is showing differences between the expected line in one of the json files and the line that is there.

I've tried removing it entirely in 1 PR (see CI failure here: https://github.com/apache/arrow/runs/5040927092?check_suite_focus=true#step:6:403) and then copying and pasting the annotated "missing" line into the tests in a subsequent PR (see CI failure here: https://github.com/apache/arrow/runs/5040977997?check_suite_focus=true#step:6:405) but it's still showing up as not matching.

I've copied and pasted the two lines and done a diff on them and there's no difference, so I don't know what a sensible next step is here.

[kou]

+1

I've fixed the test failures. I've also fixed versions.json generation when "X.Y (dev)" exists.

[kou]

I've also add missing trailing "/" to dev version.

[ursabot]

Benchmark runs are scheduled for baseline = c89e67d and contender = 360252b. 360252b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.26% ⬆️0.09%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

[thisisnic]

Thanks for finishing off this PR @kou, I was getting pretty frustrated with it, so your help here is much appreciated! :D