ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone

r/src/type_infer.cpp

-Original file line number
+Diff line change
@@ Expand Up @@
  } else if (Rf_inherits(x, "POSIXct")) {
  auto tzone_sexp = Rf_getAttrib(x, symbols::tzone);
  if (Rf_isNull(tzone_sexp)) {
- return timestamp(TimeUnit::MICRO);
+ auto systzone_sexp = cpp11::package("base")["Sys.timezone"];
+ return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0)));
  } else {
  return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0)));
  }
@@ Expand All @@
  if (Rf_inherits(x, "POSIXct")) {
  auto tzone_sexp = Rf_getAttrib(x, symbols::tzone);
  if (Rf_isNull(tzone_sexp)) {
- return timestamp(TimeUnit::MICRO);
+ auto systzone_sexp = cpp11::package("base")["Sys.timezone"];
+ return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0)));
  } else {
  return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0)));
  }
@@ Expand Down @@

r/tests/testthat/test-Array.R

-Original file line number
+Diff line change
@@ Expand Up / @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { @@
  expect_array_roundtrip(times2, timestamp("us", "US/Eastern"))
 })
-test_that("array supports POSIXct without timezone", {
- # Make sure timezone is not set
+test_that("array uses local timezone for POSIXct without timezone", {
  withr::with_envvar(c(TZ = ""), {
  times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10
- expect_array_roundtrip(times, timestamp("us", ""))
+ expect_equal(attr(times, "tzone"), NULL)
+ expect_array_roundtrip(times, timestamp("us", Sys.timezone()))
  # Also test the INTSXP code path
  skip("Ingest_POSIXct only implemented for REALSXP")
  times_int <- as.integer(times)
  attributes(times_int) <- attributes(times)
  expect_array_roundtrip(times_int, timestamp("us", ""))
  })
+ # If there is a timezone set, we record that
+ withr::with_timezone("Pacific/Marquesas", {
+ times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10
+ expect_equal(attr(times, "tzone"), "Pacific/Marquesas")
+ expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas"))
+ times_with_tz <- strptime(
+ "2019-02-03 12:34:56",
+ format = "%Y-%m-%d %H:%M:%S",
+ tz = "Asia/Katmandu") + 1:10
+ expect_equal(attr(times, "tzone"), "Asia/Katmandu")
+ expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu"))
+ })
+ # and although the TZ is NULL in R, we set it to the Sys.timezone()
+ withr::with_timezone(NA, {
+ times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10
+ expect_equal(attr(times, "tzone"), NULL)
+ expect_array_roundtrip(times, timestamp("us", Sys.timezone()))
+ })
 })
 test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", {
@@ Expand Down @@

r/tests/testthat/test-dplyr-funcs-datetime.R

-Original file line number
+Diff line change
@@ Expand Up / @@ -651,7 +651,6 @@ test_that("extract yday from date", { @@
 })
 test_that("leap_year mirror lubridate", {
  compare_dplyr_binding(
  .input %>%
  mutate(x = leap_year(date)) %>%
@@ Expand DownExpand Up / @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { @@
  ))
  )
  )
 })
 test_that("am/pm mirror lubridate", {
@@ Expand All / @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { @@
  ),
  format = "%Y-%m-%d %H:%M:%S"
  )
  )
  )
 })
 test_that("extract tz", {
@@ Expand Down @@

blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone#12240 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 56 commits into apache:master from dragosmg:timestampts_missing_timezone Conversation 77 Commits 56 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-14442: [R] fix behaviour when converting timestamps with "" as tzone #12240 Show file tree Hide file tree Changes from all commits Commits Show all changes 56 commits Select commit Hold shift + click to select a range eaf2fe9 added failing tests for timestamps dragosmg Jan 24, 2022d7fee58 a more robust test dragosmg Jan 24, 20229f6e2ba added with and without tz examples dragosmg Jan 25, 2022eba6e74 add the timezone if missing dragosmg Jan 25, 2022ec5e3a3 simplify unit test dragosmg Jan 26, 20222dd042a import rlang::inform dragosmg Jan 26, 20224cf3f4a add rlang::import to namespace dragosmg Jan 26, 20223d9534e account for POSIXct vectors without the `"tzone"` attribute dragosmg Jan 26, 2022f38a293 use `missing()` instead of `is.null()` to check for a missing attribute dragosmg Jan 26, 20220238aa5 add a test for message and do not use `missing()` to check for missin… dragosmg Jan 26, 20221a5fe71 use `any()` instead of `|` when looking for a missing `"tzone"` attri… dragosmg Jan 26, 20222a2065a remove tests for array from POSIXct without timezone dragosmg Jan 26, 202269df927 no longer inform dragosmg Jan 26, 2022135af60 remove message expectation dragosmg Jan 26, 2022ea4ef87 remove inaccurate comment dragosmg Jan 26, 2022d9aa10a additional unit tests for POSIXct -> array dragosmg Jan 26, 20220bd4eab switch test to `"Pacific/Marquesas"` as improbable timezone dragosmg Jan 26, 2022e1b1199 remove handling of missing or empty tzone from Array dragosmg Feb 1, 20225466d39 changed rare timezone in tests to `"Pacific/Marquesas"` dragosmg Feb 1, 20222742681 added systzone symbol dragosmg Feb 1, 2022a1540dc update the definition of `InferArrowTypeFromVector` dragosmg Feb 1, 202205ebbb9 update the type infer from `REALSXP` too dragosmg Feb 1, 2022463bce3 found what looks to be the right incantation for calling R functionality dragosmg Feb 1, 2022388ff7e stop going through `symbols::` for `Sys.timezone()` dragosmg Feb 1, 202279460d1 call `Sys.timezone()` directly dragosmg Feb 1, 20226b27059 testing `TZ = NA` and `TZ = NULL` both result in a `NULL` `"tzone"` a… dragosmg Feb 2, 20226a633b9 skip 1 test on windows dragosmg Feb 4, 202209f3382 skip test 2 on windows dragosmg Feb 4, 20225d455a9 skip test 3 on windows dragosmg Feb 4, 20221816861 skip test 4 & 5 on windows dragosmg Feb 4, 2022bf5b374 skip tests 6, 7, 8, 9 & 10 on windows dragosmg Feb 4, 2022f9552f4 skip tests 11, 12, 13, and 14 on windows dragosmg Feb 4, 2022b0ffa4f checking to see if `ignore_attr` helps when comparing objects dragosmg Feb 4, 202268ccb24 ignore attributes only on windows dragosmg Feb 4, 20228bac047 one more ignore attributes on windows dragosmg Feb 4, 2022e3f6a5b defined and used `on_windows()` to selectively ignore attributes in e… dragosmg Feb 4, 202228d193f ignoring attributes for some more of the failing tests dragosmg Feb 4, 2022528647a some more attributes ignored dragosmg Feb 4, 20225638c6b ignoring more attribute checks on windows dragosmg Feb 4, 2022166c708 un-skip tests on win dragosmg Feb 7, 20226ca5a4e ignore attributes on windows for yday extractions dragosmg Feb 8, 202241b580f added a bunch of TODOs related to ARROW-13168 dragosmg Feb 22, 2022daac293 trying something dragosmg Feb 22, 20220415048 skip 1 test + datetime column OS aware dragosmg Feb 22, 2022d543415 try Jon's suggestion dragosmg Feb 22, 20223343026 some cleanup dragosmg Mar 30, 2022fa510ed more cleanup dragosmg Mar 30, 2022d9d1d15 one more dragosmg Mar 30, 2022f472103 another one dragosmg Mar 30, 2022c071d07 Merge branch 'master' into timestampts_missing_timezone dragosmg Mar 30, 2022876c483 removed the `on_windows()` skip helper dragosmg Mar 31, 20225903fb2 use `withr::with_timezone()` dragosmg Mar 31, 2022de58c8d erroring with `with_timezone("" ...)` instead of `with_envvar(c(TZ = … dragosmg Apr 1, 2022e31bf0a add test with a different timezone dragosmg Apr 1, 2022e5039a8 removed `rlang::inform()` import dragosmg Apr 4, 2022fb19ce8 switched back to `withr::with_envvar(c(TZ = ""))` instead of `withr::… dragosmg Apr 4, 2022 File filter Filter by extension Filter by extension .R (2) .cpp (1) All 2 file types selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/src/type_infer.cpp type_infer.cpp r/tests/testthat/test-Array.R test-Array.R r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R There are no files selected for viewing 6 changes: 4 additions & 2 deletions 6 r/src/type_infer.cpp Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -72,7 +72,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<INTSXP>(SEXP x) { } else if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. Comment threaddragosmg marked this conversation as resolved. Outdated Uh oh! There was an error while loading. Please reload this page. return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand All @@ -88,7 +89,8 @@ std::shared_ptr<arrow::DataType> InferArrowTypeFromVector<REALSXP>(SEXP x) { if (Rf_inherits(x, "POSIXct")) { auto tzone_sexp = Rf_getAttrib(x, symbols::tzone); if (Rf_isNull(tzone_sexp)) { return timestamp(TimeUnit::MICRO); auto systzone_sexp = cpp11::package("base")["Sys.timezone"]; return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(systzone_sexp(), 0))); } else { return timestamp(TimeUnit::MICRO, CHAR(STRING_ELT(tzone_sexp, 0))); } Expand Down 27 changes: 24 additions & 3 deletions 27 r/tests/testthat/test-Array.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -260,18 +260,39 @@ test_that("array supports POSIXct (ARROW-3340)", { expect_array_roundtrip(times2, timestamp("us", "US/Eastern")) }) test_that("array supports POSIXct without timezone", { # Make sure timezone is not set test_that("array uses local timezone for POSIXct without timezone", { withr::with_envvar(c(TZ = ""), { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_array_roundtrip(times, timestamp("us", "")) expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) # Also test the INTSXP code path skip("Ingest_POSIXct only implemented for REALSXP") times_int <- as.integer(times) attributes(times_int) <- attributes(times) expect_array_roundtrip(times_int, timestamp("us", "")) }) # If there is a timezone set, we record that withr::with_timezone("Pacific/Marquesas", { Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), "Pacific/Marquesas") expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas")) Comment threaddragosmg marked this conversation as resolved. Uh oh! There was an error while loading. Please reload this page. times_with_tz <- strptime( "2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S", tz = "Asia/Katmandu") + 1:10 expect_equal(attr(times, "tzone"), "Asia/Katmandu") expect_array_roundtrip(times, timestamp("us", "Asia/Katmandu")) }) # and although the TZ is NULL in R, we set it to the Sys.timezone() withr::with_timezone(NA, { times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") + 1:10 expect_equal(attr(times, "tzone"), NULL) expect_array_roundtrip(times, timestamp("us", Sys.timezone())) }) }) test_that("Timezone handling in Arrow roundtrip (ARROW-3543)", { Expand Down 4 changes: 0 additions & 4 deletions 4 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -651,7 +651,6 @@ test_that("extract yday from date", { }) test_that("leap_year mirror lubridate", { compare_dplyr_binding( .input %>% mutate(x = leap_year(date)) %>% Expand DownExpand Up @@ -679,7 +678,6 @@ test_that("leap_year mirror lubridate", { )) ) ) }) test_that("am/pm mirror lubridate", { Expand All @@ -699,10 +697,8 @@ test_that("am/pm mirror lubridate", { ), format = "%Y-%m-%d %H:%M:%S" ) ) ) }) test_that("extract tz", { Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time.