Skip to content

ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS - #12342

Closed
sreeharihegden wants to merge 5 commits into
apache:masterfrom
mathworks:ARROW-15195
Closed

ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS#12342
sreeharihegden wants to merge 5 commits into
apache:masterfrom
mathworks:ARROW-15195

Conversation

@sreeharihegden

@sreeharihegdensreeharihegden commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

Overview

This Pull Request:

  • Enables building of the MATLAB Interface C++ code, running of the C++ tests, and running of the MATLAB tests using GitHub Actions on a macos-latest VM.
  • This is also updating the old version v0 of matlab-actions/setup-matlab enabled for ubuntu-latest VM to the lastest v1matlab-actions/setup-matlab.

Implementation

This implementation uses matlab-actions to automatically install MATLAB into a GitHub Actions Linux and Mac VM.

We are using the most updated version: v1matlab-actions/setup-matlab to enable the CI for Mac.

Here are the steps we require to build and run tests on Mac:

  • Check out the repository
  • Install ninja using the brew command
  • Install MATLAB using matlab-actions/setup-matlab@v1
  • Build MATLAB using the existing matlab_build.sh script in ci/scripts
  • Set the MATLABPATH environment variable to the MATLAB Interface to Apache Arrow installation directory
  • Run MATLAB tests in the folder matlab/test using matlab-actions/run-tests@v1

Testing

  1. The GitHub Actions workflows passed successfully with no errors in this Job.
  2. All C++ test results and MATLAB test results can be viewed in the workflow logs.

Future Directions

Enable support for Windows: matlab-actions/setup-matlab@v1 supports Windows now. We are working on enabling this for the MATLAB Arrow interface.

Notes

Thank you, Fiona @lafiona, for helping me with this pull request to submit the changes for matlab.yml.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou

kou commented Feb 6, 2022

Copy link
Copy Markdown
Member

I've merged #12004. Could you rebase on master?

@sreeharihegdensreeharihegden changed the title ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOS [WIP]ARROW-15195: [MATLAB] Enable GitHub Actions CI for MATLAB Interface on macOSFeb 7, 2022
@sreeharihegden
sreeharihegden marked this pull request as ready for review February 7, 2022 20:31
Comment thread.github/workflows/matlab.yml Outdated
@kou

kou commented Feb 8, 2022

Copy link
Copy Markdown
Member

Could you remove "Notes 1." from the description?

sreeharihegdenand others added 2 commits February 8, 2022 12:00
I will do another commit to remove 'matlab' from 'matlab-macos'.
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@sreeharihegden

Copy link
Copy Markdown
ContributorAuthor

Could you remove "Notes 1." from the description?

Thank you, @kou, for the feedback.
I have made the necessary changes to the job ids in matlab.yml as well as updated "Notes" here as suggested.

kou
kou approved these changes Feb 8, 2022

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@koukou closed this in ac2d8ffFeb 8, 2022
@ursabot

ursabot commented Feb 8, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 09c8554 and contender = ac2d8ff. ac2d8ff is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.09% ⬆️0.04%] test-mac-arm
[Finished ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.39% ⬆️0.04%] ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kevingurney
kevingurney deleted the ARROW-15195 branch August 21, 2023 18:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sreeharihegden@kou@ursabot