ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rok wants to merge 1 commit into from
Closed

ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator #12370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src/arrow/compute/api_scalar.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down
12 changes: 12 additions & 0 deletions cpp/src/arrow/compute/api_scalar.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
AssumeTimezoneOptions options,
ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down
11 changes: 11 additions & 0 deletions cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
year_month_day);
CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
ASSERT_RAISES(Invalid,
IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
auto day_of_year =
"[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
std::string is_dst =
"[false, false, false, false, false, false, false, false, false, false, false, "
"false, false, false, false, false, null]";
auto iso_year =
"[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
"2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
auto day_of_year =
"[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
std::string is_dst =
"[false, true, false, false, true, true, true, true, true, true, true, true, "
"true, true, true, true, null]";
auto iso_year =
"[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
"2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
year_month_day);
CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
ASSERT_RAISES(Invalid, Week(timestamp_array));
ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down
51 changes: 50 additions & 1 deletion cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
}
};

template <template <typename...> class Op, typename Duration, typename InType,
typename OutType>
struct DaylightSavingsExtractor
: public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
const auto& timezone = GetInputTimezone(batch.values[0]);
if (timezone.empty()) {
return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
}
ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
using ExecTemplate = Op<Duration>;
auto op = ExecTemplate(nullptr, tz);
applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
op};
return kernel.Exec(ctx, batch, out);
}
};

template <template <typename...> class Op, typename Duration, typename InType,
typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
}
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
: tz_(tz) {}

template <typename T, typename Arg0>
T Call(KernelContext*, Arg0 arg, Status*) const {
return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
}

const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
"AssumeTimezoneOptions",
/*options_required=*/true};

const FunctionDoc is_dst_doc{
"Extracts if currently observing daylight savings",
("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
"offset in the given timezone.\n"
"Null values emit null.\n"
"An error is returned if the values do not have a defined timezone."),
{"values"}};

const FunctionDoc floor_temporal_doc{
"Round temporal values down to nearest multiple of specified time unit",
("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
&assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

auto is_dst =
UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
&is_dst_doc);
DCHECK_OK(registry->AddFunction(std::move(is_dst)));

// Temporal rounding functions
static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down
2 changes: 2 additions & 0 deletions docs/source/cpp/compute.rst
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator#12370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Closed

rok
wants to merge
1
commit into

from

 Closed


ARROW-14827: [C++] Temporal component extraction function for extracting dst indicator
#12370
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 1 addition & 0 deletions
cpp/src/arrow/compute/api_scalar.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -773,6 +773,7 @@ SCALAR_EAGER_UNARY(Day, "day")
SCALAR_EAGER_UNARY(DayOfYear, "day_of_year")
SCALAR_EAGER_UNARY(Hour, "hour")
SCALAR_EAGER_UNARY(YearMonthDay, "year_month_day")
SCALAR_EAGER_UNARY(IsDaylightSavings, "is_dst")
SCALAR_EAGER_UNARY(ISOCalendar, "iso_calendar")
SCALAR_EAGER_UNARY(ISOWeek, "iso_week")
SCALAR_EAGER_UNARY(ISOYear, "iso_year")
Expand Down

12 changes: 12 additions & 0 deletions
cpp/src/arrow/compute/api_scalar.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1374,6 +1374,18 @@ ARROW_EXPORT Result<Datum> AssumeTimezone(const Datum& values,
 AssumeTimezoneOptions options,
 ExecContext* ctx = NULLPTR);

/// \brief IsDaylightSavings extracts if currently observing daylight savings for each
/// element of `values`
///
/// \param[in] values input to extract daylight savings indicator from
/// \param[in] ctx the function execution context, optional
/// \return the resulting datum
///
/// \since 8.0.0
/// \note API not yet finalized
ARROW_EXPORT Result<Datum> IsDaylightSavings(const Datum& values,
 ExecContext* ctx = NULLPTR);

/// \brief Finds either the FIRST, LAST, or ALL items with a key that matches the given
/// query key in a map.
///
Expand Down

11 changes: 11 additions & 0 deletions
cpp/src/arrow/compute/kernels/scalar_temporal_test.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -475,6 +475,8 @@ TEST_F(ScalarTemporalTest, TestTemporalComponentExtractionWithDifferentUnits) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 ASSERT_RAISES(Invalid,
 IsDaylightSavings(ArrayFromJSON(unit, times_seconds_precision)));
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -570,6 +572,9 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 auto day_of_week = "[2, 1, 5, 1, 1, 0, 6, 2, 3, 5, 6, 5, 5, 5, 6, 5, null]";
 auto day_of_year =
 "[365, 60, 365, 137, 365, 364, 363, 364, 365, 2, 3, 365, 365, 362, 363, 365, null]";
 std::string is_dst =
 "[false, false, false, false, false, false, false, false, false, false, false, "
 "false, false, false, false, false, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2019, 2009, 2009, 2009, 2009, 2005, 2005, "
 "2008, 2008, 2011, null]";
Expand DownExpand Up@@ -604,6 +609,7 @@ TEST_F(ScalarTemporalTest, TestZoned1) {
 CheckScalarUnary("year_month_day", ArrayFromJSON(unit, times), year_month_day);
 CheckScalarUnary("day_of_week", unit, times, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times, int64(), us_week);
Expand DownExpand Up@@ -644,6 +650,9 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 auto day_of_week = "[3, 2, 6, 2, 2, 1, 0, 3, 4, 6, 0, 6, 5, 6, 0, 6, null]";
 auto day_of_year =
 "[1, 61, 1, 138, 1, 365, 364, 365, 1, 3, 4, 1, 365, 363, 364, 1, null]";
 std::string is_dst =
 "[false, true, false, false, true, true, true, true, true, true, true, true, "
 "true, true, true, true, null]";
 auto iso_year =
 "[1970, 2000, 1898, 2033, 2020, 2020, 2020, 2009, 2009, 2009, 2010, 2005, 2005, "
 "2008, 2009, 2011, null]";
Expand DownExpand Up@@ -679,6 +688,7 @@ TEST_F(ScalarTemporalTest, TestZoned2) {
 year_month_day);
 CheckScalarUnary("day_of_week", unit, times_seconds_precision, int64(), day_of_week);
 CheckScalarUnary("day_of_year", unit, times_seconds_precision, int64(), day_of_year);
 CheckScalarUnary("is_dst", unit, times_seconds_precision, boolean(), is_dst);
 CheckScalarUnary("iso_year", unit, times_seconds_precision, int64(), iso_year);
 CheckScalarUnary("iso_week", unit, times_seconds_precision, int64(), iso_week);
 CheckScalarUnary("us_week", unit, times_seconds_precision, int64(), us_week);
Expand DownExpand Up@@ -710,6 +720,7 @@ TEST_F(ScalarTemporalTest, TestNonexistentTimezone) {
 ASSERT_RAISES(Invalid, YearMonthDay(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfWeek(timestamp_array));
 ASSERT_RAISES(Invalid, DayOfYear(timestamp_array));
 ASSERT_RAISES(Invalid, IsDaylightSavings(timestamp_array));
 ASSERT_RAISES(Invalid, ISOYear(timestamp_array));
 ASSERT_RAISES(Invalid, Week(timestamp_array));
 ASSERT_RAISES(Invalid, ISOCalendar(timestamp_array));
Expand Down

51 changes: 50 additions & 1 deletion
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -48,7 +48,6 @@ using arrow_vendored::date::Monday;
using arrow_vendored::date::months;
using arrow_vendored::date::round;
using arrow_vendored::date::Sunday;
using arrow_vendored::date::sys_days;
using arrow_vendored::date::sys_time;
using arrow_vendored::date::trunc;
using arrow_vendored::date::weekday;
Expand DownExpand Up@@ -133,6 +132,26 @@ struct AssumeTimezoneExtractor
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct DaylightSavingsExtractor
 : public TemporalComponentExtractBase<Op, Duration, InType, OutType> {
 using Base = TemporalComponentExtractBase<Op, Duration, InType, OutType>;

 static Status Exec(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
 const auto& timezone = GetInputTimezone(batch.values[0]);
 if (timezone.empty()) {
 return Status::Invalid("Timestamps have no timezone. Cannot determine DST.");
 }
 ARROW_ASSIGN_OR_RAISE(auto tz, LocateZone(timezone));
 using ExecTemplate = Op<Duration>;
 auto op = ExecTemplate(nullptr, tz);
 applicator::ScalarUnaryNotNullStateful<OutType, TimestampType, ExecTemplate> kernel{
 op};
 return kernel.Exec(ctx, batch, out);
 }
};

template <template <typename...> class Op, typename Duration, typename InType,
 typename OutType>
struct TemporalComponentExtractWeek
Expand DownExpand Up@@ -603,6 +622,22 @@ struct Nanosecond {
 }
};

// ----------------------------------------------------------------------
// Extract if currently observing daylight savings

template <typename Duration>
struct IsDaylightSavings {
 explicit IsDaylightSavings(const FunctionOptions* options, const time_zone* tz)
 : tz_(tz) {}

 template <typename T, typename Arg0>
 T Call(KernelContext*, Arg0 arg, Status*) const {
 return tz_->get_info(sys_time<Duration>{Duration{arg}}).save.count() != 0;
 }

 const time_zone* tz_;
};

// ----------------------------------------------------------------------
// Round temporal values to given frequency

Expand DownExpand Up@@ -1444,6 +1479,14 @@ const FunctionDoc assume_timezone_doc{
 "AssumeTimezoneOptions",
 /*options_required=*/true};

const FunctionDoc is_dst_doc{
 "Extracts if currently observing daylight savings",
 ("IsDaylightSavings returns true if a timestamp has a daylight saving\n"
 "offset in the given timezone.\n"
 "Null values emit null.\n"
 "An error is returned if the values do not have a defined timezone."),
 {"values"}};

const FunctionDoc floor_temporal_doc{
 "Round temporal values down to nearest multiple of specified time unit",
 ("Null values emit null.\n"
Expand DownExpand Up@@ -1607,6 +1650,12 @@ void RegisterScalarTemporalUnary(FunctionRegistry* registry) {
 &assume_timezone_doc, nullptr, AssumeTimezoneState::Init);
 DCHECK_OK(registry->AddFunction(std::move(assume_timezone)));

 auto is_dst =
 UnaryTemporalFactory<IsDaylightSavings, DaylightSavingsExtractor,
 BooleanType>::Make<WithTimestamps>("is_dst", boolean(),
 &is_dst_doc);
 DCHECK_OK(registry->AddFunction(std::move(is_dst)));

 // Temporal rounding functions
 static const auto default_round_temporal_options = RoundTemporalOptions::Defaults();
 auto floor_temporal = UnaryTemporalFactory<FloorTemporal, TemporalComponentExtractRound,
Expand Down

2 changes: 2 additions & 0 deletions
docs/source/cpp/compute.rst

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -1382,6 +1382,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| hour | Unary | Timestamp, Time | Int64 | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| is_dst | Unary | Timestamp | Boolean | | |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_week | Unary | Temporal | Int64 | | \(2) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_year | Unary | Temporal | Int64 | | \(2) |
Expand Down