') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); ARROW-15877: [C++] Add a C++ query testing tool by westonpace · Pull Request #12586 · apache/arrow · GitHub
Skip to content

ARROW-15877: [C++] Add a C++ query testing tool - #12586

Closed
westonpace wants to merge 12 commits into
apache:masterfrom
westonpace:feature/ARROW-15877--query-testing-tool
Closed

ARROW-15877: [C++] Add a C++ query testing tool#12586
westonpace wants to merge 12 commits into
apache:masterfrom
westonpace:feature/ARROW-15877--query-testing-tool

Conversation

@westonpace

@westonpacewestonpace commented Mar 9, 2022

Copy link
Copy Markdown
Member

This PR is based on #12537 and will need to remain in draft until that is merged. In addition, I'd like to fit in a few more builtin queries in this initial PR.

This PR creates a standalone query testing executable query_tester.

The tool takes a number of command line options today:

Usage: query_tester [options] query Positional arguments:
query name of the query to run [required]
Optional arguments:
-h --help shows help message and exits
-v --version prints version information and exits
--num-iterations [default: 1]
--cpu-threads size to use for the CPU thread pool, default controlled by Arrow
--io-threads size to use for the I/O thread pool, default controlled by Arrow
--validate if set the program will validate the query results [default: false] (not yet implemented)

The tool will first look for a Substrait query in the queries folder (there is an example of TPC-H Q1 in JSON format). At the moment this isn't very useful as our Substrait support is very limited.

The tool will then look for builtin queries, I'd like to add support for all of the TPC-H builtin queries.

There is a datasets folder that is also created. In the future I'd like to add support for downloading remote datasets to this folder.

The current output simply prints a few statistics:

(conbench3) pace@pace-desktop:~/dev/arrow/dev/qtester/debug-build$ ./query_tester tpch-1 --num-iterations 10
Average Duration: 1.19292s (+/- 0.00569406s)
Average Output Rows/S: 3.35311rps
Average Output Bytes/S: 409.08bps

Note that Output Rows/S and Output Bytes/S is not very useful for TPC-H queries (which aggregate most of their data so they have very little output for the amount of work done). I've prototyped adding a much more exhaustive breakdown of time spent by intercepting OT events but I'd like to save that work for a future PR.

@github-actions

github-actionsBot commented Mar 9, 2022

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@westonpacewestonpace changed the title Feature/arrow 15877 query testing toolARROW-15877: [C++] Add a C++ query testing toolMar 9, 2022
@github-actions

github-actionsBot commented Mar 9, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-15877

joosthooz
joosthooz reviewed Mar 10, 2022
View reviewed changes
Comment threadcpp/src/arrow/compute/exec/tpch_benchmark.cc
namespace compute
{

std::shared_ptr<ExecPlan> Plan_Q1(AsyncGenerator<util::optional<ExecBatch>> &sink_gen, int scale_factor)

@joosthoozjoosthoozMar 10, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is almost identical to tpch1() in builtin_queries.cc

@westonpacewestonpaceMar 10, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I created tpch1() by leveraging this. Once the PR adding tpch_benchmark.cc merges I will update this PR to remove tpch_benchmark.cc in favor of this (or perhaps keep the benchmark but link to builtin queries).

@sanjibansgsanjibansg mentioned this pull request Mar 25, 2022
Closed
westonpace pushed a commit that referenced this pull request Mar 30, 2022
@sanjibansg@westonpace
ARROW-15994: [C++] Back out taskify changes
756f2b7
This PR modifies the `SubmitTask` and `Finish` methods of MapNode in `ExecPlan` to avoid scheduling extra thread tasks.
Performed the TPC-H Benchmark developed in PR #12537 with and without the changes.
```
TPC-H Benchmark (With Extra Thread Tasks)
-------------------------------------------------------------------
Benchmark Time CPU Iterations
-------------------------------------------------------------------
BM_Tpch_Q1/ScaleFactor:1 95035633 ns 178700 ns 100
TPC-H Benchmark (Without Extra Thread Tasks)
-------------------------------------------------------------------
Benchmark Time CPU Iterations
-------------------------------------------------------------------
BM_Tpch_Q1/ScaleFactor:1 91511754 ns 182060 ns 100
```
Also, tested with the Query Tester as proposed in PR #12586
```
With Thread Tasks (batch size = 4096)
./query_tester tpch-1
Average Duration: 0.106694s (+/- 0s)
Average Output Rows/S: 37.4902rps
Average Output Bytes/S: 4573.81bps
Without Thread Tasks (batch size = 4096)
./query_tester tpch-1
Average Duration: 0.104658s (+/- 0s)
Average Output Rows/S: 38.2198rps
Average Output Bytes/S: 4662.82bps
```
Closes#12720 from sanjibansg/thread_tasks
Authored-by: Sanjiban Sengupta <sanjiban.sg@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
@asfimportasfimport mentioned this pull request Jul 22, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@joosthoozjoosthoozjoosthooz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@westonpace@joosthooz@save-buffer@jonkeane