ARROW-14943: [R] Bindings for lubridate's ddays, dhours, dminutes, dmonths, dweeks, dyears

[AlenkaF]

No description provided.

[github-actions]

https://issues.apache.org/jira/browse/ARROW-14943

[AlenkaF]

This PR should be updated to use as.difftime when #12506 is merged.

[AlenkaF]

Left the bindings as were and decided not to use as.difftime after talking to Dragos about it.

[paleolimbot]

This looks great! Thank you! I just suggested a few changes to match the style of other default arguments in this file.

[AlenkaF]

Thanks for reviewing @paleolimbot! I should have noticed I was still in Python land ... 🤦‍♀️ :)

[AlenkaF]

I added the text to the News.md in #12855.

Also got quite some linter corrections when running make style (to the code not changed by me). Didn't want to add confusion so didn't commit the changes. I could run it again on master and make a minor PR for it?

[paleolimbot]

All good! I'm new to how development in the arrow R package works, but I think style changes that are outside the scope of the function that is getting added/modified should be a separate PR. I've never used make style because it doesn't run on my computer...in ggplot2 we did restyling one PR at a time (rather than running a restyle on the whole package since that has a heavy git change footprint).

[amol-]

@AlenkaF there seem to be a few failing tests on windows, are they related to the PR?

[AlenkaF]

Oh, yes, they are related. Will have a look, thanks!

[dragosmg]

Looking good. One small suggestion. Thanks for tackling the cyclomatic complexity.

[dragosmg]

LGTM. Thanks for all the work! @thisisnic@jonkeane would you mind having a look and merging?

[thisisnic]

Comments resolved, tests pass, and values used match those in lubridate, so looks good to me!

[ursabot]

Benchmark runs are scheduled for baseline = a63ee07 and contender = 69c28de. 69c28de is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.97% ⬆️0.04%] test-mac-arm
[Finished ⬇️0.71% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️2.76% ⬆️0.26%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/514|69c28de8 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/501|69c28de8 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/500|69c28de8 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/511|69c28de8 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/513|a63ee07f ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/500|a63ee07f test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/499|a63ee07f ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/510|a63ee07f ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java