Skip to content

ARROW-16026: [C++] Add support for the serial executor to expose an async generator as an iterable - #12712

Closed
westonpace wants to merge 4 commits into
apache:masterfrom
westonpace:feature/ARROW-16026--async-generator-to-iterator
Closed

ARROW-16026: [C++] Add support for the serial executor to expose an async generator as an iterable#12712
westonpace wants to merge 4 commits into
apache:masterfrom
westonpace:feature/ARROW-16026--async-generator-to-iterator

Conversation

@westonpace

@westonpacewestonpace commented Mar 25, 2022

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actionsBot commented Mar 25, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16026

@westonpace
westonpace marked this pull request as draft March 25, 2022 02:59
@westonpace

westonpace commented Mar 25, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

This is based on ARROW-15968 / #12662 and will remain in draft until that PR has merged.
This is needed to enable ARROW-15732 / #12468

@westonpace
westonpaceforce-pushed the feature/ARROW-16026--async-generator-to-iterator branch from 2655a67 to b5e4863CompareMarch 25, 2022 22:02
@westonpace
westonpace marked this pull request as ready for review March 25, 2022 22:03
@lidavidm

lidavidm commented Mar 28, 2022

Copy link
Copy Markdown
Member

arrow-s3fs-test failure is unrelated, see ARROW-16043. It seems the Python test_write_dataset_s3 failure is similar.

pitrou
pitrou reviewed Mar 28, 2022
View reviewed changes
Comment threadcpp/src/arrow/util/thread_pool.h Outdated
Comment threadcpp/src/arrow/util/thread_pool.h
Comment threadcpp/src/arrow/testing/async_test_util.h Outdated
Comment threadcpp/src/arrow/util/thread_pool_test.cc Outdated
Comment threadcpp/src/arrow/util/thread_pool_test.cc Outdated
@ursabot

ursabot commented Mar 29, 2022•
edited
Loading

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = d7fbf52 and contender = b56c0d8. b56c0d8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️1.34% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.3% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/410|b56c0d8e ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/396|b56c0d8e test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/396|b56c0d8e ursa-i9-9960x>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/406|b56c0d8e ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/409|d7fbf526 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/395|d7fbf526 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/395|d7fbf526 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/405|d7fbf526 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitroupitroupitrou left review comments
@lidavidmlidavidmlidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@westonpace@lidavidm@ursabot@pitrou