Skip to content

ARROW-14944 [R] Implement lubridate::make_difftime() - #12757

Closed
dragosmg wants to merge 21 commits into
apache:masterfrom
dragosmg:lubridate_make_difftime
Closed

ARROW-14944 [R] Implement lubridate::make_difftime()#12757
dragosmg wants to merge 21 commits into
apache:masterfrom
dragosmg:lubridate_make_difftime

Conversation

@dragosmg

@dragosmgdragosmg commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actionsBot commented Mar 30, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-14944

@github-actions

github-actionsBot commented Mar 30, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@dragosmg
dragosmg marked this pull request as ready for review April 1, 2022 14:46
@thisisnic
thisisnic self-requested a review April 5, 2022 12:21
thisisnic
thisisnic reviewed Apr 5, 2022
View reviewed changes

@thisisnicthisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just a few tweaks.

Comment threadr/R/dplyr-funcs-datetime.R
Comment threadr/R/dplyr-funcs-datetime.R
Comment threadr/R/dplyr-funcs-datetime.R Outdated
@dragosmg

dragosmg commented Apr 13, 2022

Copy link
Copy Markdown
ContributorAuthor

@thisisnic thanks. I think this is ready for another look.

thisisnic
thisisnic approved these changes Apr 13, 2022
View reviewed changes

@thisisnicthisisnic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates - looks good!

@thisisnic

thisisnic commented Apr 14, 2022

Copy link
Copy Markdown
Member

@jonkeane Please could you give this a skim over before I merge it?

@thisisnic
thisisnic requested a review from jonkeaneApril 14, 2022 12:21
jonkeane
jonkeane requested changes Apr 18, 2022
View reviewed changes

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, a few comments + suggestions

Comment threadr/tests/testthat/test-dplyr-funcs-datetime.R
Comment threadr/R/dplyr-funcs-datetime.R Outdated
Comment threadr/R/dplyr-funcs-datetime.R
Comment threadr/R/dplyr-funcs-datetime.R Outdated
Comment threadr/tests/testthat/test-dplyr-funcs-datetime.R
@dragosmg
dragosmg requested a review from jonkeaneApril 20, 2022 09:44
@dragosmg

dragosmg commented Apr 20, 2022

Copy link
Copy Markdown
ContributorAuthor

@jonkeane mind having another look over?

jonkeane
jonkeane approved these changes Apr 20, 2022
View reviewed changes

@jonkeanejonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@ursabot

ursabot commented Apr 22, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = 1f43abc and contender = 7ae86de. 7ae86de is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.17% ⬆️0.12%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.92% ⬆️0.17%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/558|7ae86de8 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/546|7ae86de8 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/544|7ae86de8 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/556|7ae86de8 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/557|1f43abc9 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/545|1f43abc9 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/543|1f43abc9 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/555|1f43abc9 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@dragosmg
dragosmg deleted the lubridate_make_difftime branch April 26, 2022 09:31
This was referenced Apr 22, 2022
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonkeanejonkeanejonkeane approved these changes
@thisisnicthisisnicthisisnic approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dragosmg@thisisnic@ursabot@jonkeane