ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows by dragosmg · Pull Request #12883 · apache/arrow

r/tests/testthat/test-dplyr-funcs-datetime.R

-Original file line number
+Diff line change
@@ Expand Up / @@ -841,8 +841,6 @@ test_that("month() supports integer input", { @@
  test_df_month
  )
- skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
  compare_dplyr_binding(
  .input %>%
  # R returns ordered factor whereas Arrow returns character
@@ Expand DownExpand Up @@
 })
 test_that("date works in arrow", {
- # https://issues.apache.org/jira/browse/ARROW-13168
- skip_on_os("windows")
  # this date is specific since lubridate::date() is different from base::as.Date()
  # since as.Date returns the UTC date and date() doesn't
  test_df <- tibble(
@@ Expand DownExpand Up / @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { @@
  ignore_attr = TRUE
  )
- skip_on_os("windows")
  test_df_with_tz <- tibble(
  time1 = as.POSIXct(
  c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"),
@@ Expand Down @@

r/tests/testthat/test-dplyr-funcs-type.R

-Original file line number
+Diff line change
@@ Expand Up / @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { @@
  fixed = TRUE
  )
  # we do not support as.Date() with double/ float (error surfaced from C++)
  # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798
  expect_error(
@@ Expand DownExpand Up / @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { @@
 })
 test_that("format date/time", {
- skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+ # locale issues
+ # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done
+ if (tolower(Sys.info()[["sysname"]]) == "windows") {
+ withr::local_locale(LC_TIME = "C")
+ }
  # In 3.4 the lack of tzone attribute causes spurious failures
  skip_if_r_version("3.4.4")
@@ Expand Down @@

blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time. , 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Skip to contentNavigation Menu Sign inAppearance settings AI CODE CREATIONGitHub CopilotWrite better code with AI GitHub Copilot appDirect agents from issue to merge MCP RegistryIntegrate external tools DEVELOPER WORKFLOWSActionsAutomate any workflow CodespacesInstant dev environments IssuesPlan and track work Code ReviewManage code changes Code QualityEnforce quality at merge APPLICATION SECURITYGitHub Advanced SecurityFind and fix vulnerabilities Code securitySecure your code as you build Secret protectionStop leaks before they start EXPLOREWhy GitHub Documentation Blog Changelog Marketplace View all features BY COMPANY SIZEEnterprises Small and medium teams Startups Nonprofits BY USE CASEApp Modernization DevSecOps DevOps CI/CD View all use cases BY INDUSTRYHealthcare Financial services Manufacturing Government View all industries View all solutions EXPLORE BY TOPICAI Software Development DevOps Security View all topics EXPLORE BY TYPECustomer stories Events & webinars Ebooks & reports Business insights GitHub Skills SUPPORT & SERVICESDocumentation Customer support Community forum Trust center Partners View all resources COMMUNITYGitHub SponsorsFund open source developers PROGRAMSSecurity Lab Maintainer Community GitHub Stars Archive Program REPOSITORIESTopics Trending Collections ENTERPRISE SOLUTIONSEnterprise platformAI-powered developer platform AVAILABLE ADD-ONSGitHub Advanced SecurityEnterprise-grade security features Copilot for BusinessEnterprise-grade AI features Premium SupportEnterprise-grade 24/7 support Pricing Sign in Sign upAppearance settings You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert Uh oh! There was an error while loading. Please reload this page. apache /arrowPublic Notifications You must be signed in to change notification settings Fork 4.3k Star 17.1k Code Issues2.2k Pull requests399 Discussions Actions Projects Security and quality0 Insights Additional navigation options Code Issues Pull requests Discussions Actions Projects Security and quality Insights ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows#12883 New issue Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community. Sign up for GitHub By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails. Already on GitHub? Sign in to your account Closed dragosmg wants to merge 24 commits into apache:master from dragosmg:datetime_unit_testing_cleanup Conversation 10 Commits 24 Checks 0 Files changed Uh oh! There was an error while loading. Please reload this page. Closed ARROW-16073: [R] clean-up date time unit testing once tzdb is available on Windows #12883 Show file tree Hide file tree Changes from all commits Commits Show all changes 24 commits Select commit Hold shift + click to select a range fe207df un-skipped some of the tests on windows dragosmg Apr 14, 20228d6f015 2nd pass dragosmg Apr 14, 2022658b716 trying something out dragosmg Apr 14, 2022fc7dfb6 test dragosmg Apr 21, 202206ba19e removed `%B` from `formats` dragosmg Apr 26, 202271b8ecb tidy-up after rebase dragosmg Apr 26, 2022830eabd removed empty row dragosmg Apr 26, 20222ad706e removed `"%b"` from formats dragosmg Apr 26, 20222720ae4 removed `"%a"` & `"%A"` dragosmg Apr 26, 202254672d7 park the formats skipped on Windows dragosmg Apr 26, 2022797e4d7 move `"%p"` to `formats_skipped_on_windows` dragosmg Apr 26, 20225d62368 skipping the `"%x"` & `"%X"` formats on Windows dragosmg Apr 26, 2022f63a2ef test without formats dragosmg Apr 26, 2022ed9b1f5 one more test dragosmg Apr 26, 20223119eb1 another test dragosmg Apr 27, 2022d3abcc3 another one dragosmg Apr 27, 2022e87733b skip all tests with `format` dragosmg Apr 27, 2022633f682 typo dragosmg Apr 28, 2022f637567 removed commented-out `skip_on_os()` calls dragosmg Apr 28, 2022b758c82 added link to ARROW-13133 dragosmg Apr 28, 2022521b3c1 set locale on windows to `"C"` dragosmg Apr 28, 202279a9ac0 test dragosmg Apr 28, 20223f27ba7 refer to the correct Jira dragosmg Apr 28, 2022c3b9c2b minor change dragosmg Apr 28, 2022 File filter Filter by extension Filter by extension .R (2) All 1 file type selected Viewed files Clear filters Conversations Failed to load comments. Loading Uh oh! There was an error while loading. Please reload this page. Jump to Jump to file Failed to load files. Loading Uh oh! There was an error while loading. Please reload this page. Diff view Unified Split Hide whitespace Diff view Unified Split Hide whitespace r/tests/testthat/test-dplyr-funcs-datetime.R test-dplyr-funcs-datetime.R r/tests/testthat/test-dplyr-funcs-type.R test-dplyr-funcs-type.R There are no files selected for viewing 5 changes: 0 additions & 5 deletions 5 r/tests/testthat/test-dplyr-funcs-datetime.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -841,8 +841,6 @@ test_that("month() supports integer input", { test_df_month ) skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 compare_dplyr_binding( .input %>% # R returns ordered factor whereas Arrow returns character Expand DownExpand Up @@ -904,8 +902,6 @@ test_that("month() errors with double input and returns NA with int outside 1:12 }) test_that("date works in arrow", { # https://issues.apache.org/jira/browse/ARROW-13168 skip_on_os("windows") # this date is specific since lubridate::date() is different from base::as.Date() # since as.Date returns the UTC date and date() doesn't test_df <- tibble( Expand DownExpand Up @@ -1123,7 +1119,6 @@ test_that("difftime works correctly", { ignore_attr = TRUE ) skip_on_os("windows") test_df_with_tz <- tibble( time1 = as.POSIXct( c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31"), Expand Down 7 changes: 5 additions & 2 deletions 7 r/tests/testthat/test-dplyr-funcs-type.R Show comments View file Open in desktop Original file line number Diff line number Diff line change Expand Up @@ -873,7 +873,6 @@ test_that("`as.Date()` and `as_date()`", { fixed = TRUE ) # we do not support as.Date() with double/ float (error surfaced from C++) # TODO revisit after https://issues.apache.org/jira/browse/ARROW-15798 expect_error( Expand DownExpand Up @@ -958,7 +957,11 @@ test_that("`as_datetime()`", { }) test_that("format date/time", { skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168 # locale issues # TODO revisit after https://issues.apache.org/jira/browse/ARROW-16399 is done if (tolower(Sys.info()[["sysname"]]) == "windows") { withr::local_locale(LC_TIME = "C") } # In 3.4 the lack of tzone attribute causes spurious failures skip_if_r_version("3.4.4") Expand Down Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. Footer © 2026 GitHub, Inc. Footer navigation Terms Privacy Security Status Community Docs Contact You can’t perform that action at this time.