Skip to content

ARROW-16205: [C++][FlightRPC] Don't use constexpr std::initializer_list - #12903

Closed
lidavidm wants to merge 1 commit into
apache:masterfrom
lidavidm:arrow-16205
Closed

ARROW-16205: [C++][FlightRPC] Don't use constexpr std::initializer_list#12903
lidavidm wants to merge 1 commit into
apache:masterfrom
lidavidm:arrow-16205

Conversation

@lidavidm

Copy link
Copy Markdown
Member

To fix a build error on Clang.

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ Ticket has no components in JIRA, make sure you assign one.

@lidavidm

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit verify-rc-source-cpp-macos-*

@github-actions

Copy link
Copy Markdown

Revision: 2dc7c3c

Submitted crossbow builds: ursacomputing/crossbow @ actions-1866

TaskStatus
verify-rc-source-cpp-macos-amd64Github Actions
verify-rc-source-cpp-macos-arm64Github Actions
verify-rc-source-cpp-macos-conda-amd64Github Actions

kou
kou approved these changes Apr 16, 2022

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@koukou closed this in 83dda5cApr 16, 2022
@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = d36b2b3 and contender = 83dda5c. 83dda5c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.38% ⬆️0.13%] test-mac-arm
[Failed ⬇️0.36% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/523|83dda5c3 ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/510|83dda5c3 test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/509|83dda5c3 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/520|83dda5c3 ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/522|d36b2b33 ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/509|d36b2b33 test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/508|d36b2b33 ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/519|d36b2b33 ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@lidavidm
lidavidm deleted the arrow-16205 branch April 18, 2022 11:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lidavidm@ursabot@kou