Uh oh!
There was an error while loading. Please reload this page.
ARROW-15936 [Ruby] Add test for Arrow::DictionaryArray#raw_records - #12904
ARROW-15936 [Ruby] Add test for Arrow::DictionaryArray#raw_records#12904okadakk wants to merge 1 commit into
Conversation
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Umm. This dictionary isn't a dictionary.
For example, Arrow::NullArray.new(records.flatten) in build(Arrow::NullArray.new(records.flatten), records) isn't a dictionary.
How about something like the following?
defbuild_record_batch(array)dictionary=array.dictionary_encodeschema=Arrow::Schema.new(column: dictionary.value_data_type)Arrow::RecordBatch.new(schema,array.length,[dictionary])endtarget=build(Arrow::NullArray.new(records.collect(&:first)))okadakk
commented
May 19, 2022
thanks! Sorry for the late reaction... |
kou
commented
May 19, 2022
No problem! But please mention me when a pull request can be reviewed again. |
ursabot
commented
May 19, 2022
Benchmark runs are scheduled for baseline = dc39f83 and contender = 79810a5. 79810a5 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
I added test for Arrow::DictionaryArray#raw_records.