Skip to content

ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18 - #12990

Closed
davisusanibar wants to merge 2 commits into
apache:masterfrom
davisusanibar:java-ARROW-16292
Closed

ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18#12990
davisusanibar wants to merge 2 commits into
apache:masterfrom
davisusanibar:java-ARROW-16292

Conversation

@davisusanibar

@davisusanibardavisusanibar commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

Related to #12941 (comment)

@github-actions

github-actionsBot commented Apr 25, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16292

@github-actions

github-actionsBot commented Apr 25, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@davisusanibardavisusanibar mentioned this pull request Apr 25, 2022
Closed
lidavidm
lidavidm reviewed Apr 25, 2022
View reviewed changes
Comment threaddocs/source/java/install.rst Outdated
Comment threaddocs/source/java/install.rst Outdated
Comment threaddocs/source/java/install.rst Outdated
Comment threaddocs/source/java/install.rst
Comment on lines +126 to +130
Environment variables: To execute your Arrow Java main code.

.. code-block::

_JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" mvn exec:java -Dexec.mainClass="YourMainCode"

@lidavidmlidavidmApr 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be configured in pom.xml somehow?

@davisusanibardavisusanibarApr 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhmm, let me figure out if there are some plugins available, but, initially I could say no way to do that.

@davisusanibardavisusanibarApr 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lidavidm, I didn't find a plugin to configure environment variable as needed on the pom.xml directly.

@davisusanibardavisusanibarApr 25, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a exec-maven-plugin but not able to pass argLine needed

@lidavidmlidavidmApr 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good

@davisusanibar@lidavidm
Apply suggestions from code review
cdac91f
Co-authored-by: David Li <li.davidm96@gmail.com>
@ursabot

ursabot commented May 2, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = cb41e06 and contender = d464425. d464425 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.04% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] d4644254 ec2-t3-xlarge-us-east-2
[Finished] d4644254 test-mac-arm
[Finished] d4644254 ursa-i9-9960x
[Finished] d4644254 ursa-thinkcentre-m75q
[Finished] cb41e069 ec2-t3-xlarge-us-east-2
[Finished] cb41e069 test-mac-arm
[Finished] cb41e069 ursa-i9-9960x
[Finished] cb41e069 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davisusanibar@ursabot@lidavidm