Skip to content

MINOR: Fix wrongly redefining pytestmark for parquet encryption tests - #13189

Merged
jorisvandenbossche merged 1 commit into
apache:masterfrom
raulcd:fix-wrong-dataset-mark-definition
May 18, 2022
Merged

MINOR: Fix wrongly redefining pytestmark for parquet encryption tests#13189
jorisvandenbossche merged 1 commit into
apache:masterfrom
raulcd:fix-wrong-dataset-mark-definition

Conversation

@raulcd

@raulcdraulcd commented May 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This PR should correctly skip the tests and fix the failures introduced by #13147 (comment) on the following builds:

@raulcd

raulcd commented May 18, 2022

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit test-conda-python-*-pandas-latest

@github-actions

github-actionsBot commented May 18, 2022

Copy link
Copy Markdown

Revision: 39bcec3

Submitted crossbow builds: ursacomputing/crossbow @ actions-2112

TaskStatus
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions

jorisvandenbossche referenced this pull request May 18, 2022
@raulcd@jorisvandenbossche
ARROW-16548: [Python] Add pytest.mark.parquet to all tests under test…
c032290
…s/parquet package
The implementation marks all the individual tests that are on this structure with the parquet dataset mark correctly.
Closes#13147 from raulcd/ARROW-16548
Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@raulcd
raulcd marked this pull request as ready for review May 18, 2022 15:23
@raulcd

raulcd commented May 18, 2022

Copy link
Copy Markdown
MemberAuthor

@jorisvandenbossche this is now correctly skipping the tests, see the builds passing now and the tests skipped:

 opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_read SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_read_wrong_key SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_read_no_decryption_config SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_read_metadata_no_decryption_config SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_read_schema_no_decryption_config SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_no_col_key SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_specific_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_factory_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_kms_factory_type_error SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_encryption_configuration SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_decryption_configuration SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_kms_configuration SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_read_plain_footer_single_wrapping SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_write_external SKIPPED [ 97%]
opt/conda/envs/arrow/lib/python3.7/site-packages/pyarrow/tests/parquet/test_encryption.py::test_encrypted_parquet_loop SKIPPED [ 97%]

@jorisvandenbossche
jorisvandenbossche merged commit 3df2e05 into apache:masterMay 18, 2022
@jorisvandenbossche

jorisvandenbossche commented May 18, 2022

Copy link
Copy Markdown
Member

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorisvandenbosschejorisvandenbosschejorisvandenbossche approved these changes

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@raulcd@jorisvandenbossche