Skip to content

ARROW-16643: [C++] Fix warnings for clang-14 - #13225

Closed
wesm wants to merge 1 commit into
apache:masterfrom
wesm:ARROW-16643
Closed

ARROW-16643: [C++] Fix warnings for clang-14#13225
wesm wants to merge 1 commit into
apache:masterfrom
wesm:ARROW-16643

Conversation

@wesm

@wesmwesm commented May 24, 2022

Copy link
Copy Markdown
Member

The following code in arrow/util/small_vector_benchmark.cc generates -Wreturn-stack-address in clang-14. It might be better to fix but suppressing for now:

template <typename Vector>
ARROW_NOINLINE int64_t ConsumeVector(Vector v) {
return reinterpret_cast<intptr_t>(v.data());
}
template <typename Vector>
ARROW_NOINLINE int64_t IngestVector(const Vector& v) {
return reinterpret_cast<intptr_t>(v.data());
}

@github-actions

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidmlidavidm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed https://issues.apache.org/jira/browse/ARROW-16644 so we don't forget about the suppression.

@lidavidm

Copy link
Copy Markdown
Member

That AppVeyor issue should be fixed by #13191

@ursabot

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = dd84c0f and contender = 7adda73. 7adda73 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.39% ⬆️1.87%] test-mac-arm
[Failed ⬇️0.74% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.32% ⬆️1.89%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7adda73d ec2-t3-xlarge-us-east-2
[Failed] 7adda73d test-mac-arm
[Failed] 7adda73d ursa-i9-9960x
[Finished] 7adda73d ursa-thinkcentre-m75q
[Finished] dd84c0f6 ec2-t3-xlarge-us-east-2
[Failed] dd84c0f6 test-mac-arm
[Failed] dd84c0f6 ursa-i9-9960x
[Finished] dd84c0f6 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@wesm
wesm deleted the ARROW-16643 branch May 24, 2022 23:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wesm@lidavidm@ursabot