Skip to content

ARROW-16668: [CI] Add Substrait support to python wheels - #13239

Merged
kou merged 2 commits into
apache:masterfrom
raulcd:ARROW-16668
May 26, 2022
Merged

ARROW-16668: [CI] Add Substrait support to python wheels#13239
kou merged 2 commits into
apache:masterfrom
raulcd:ARROW-16668

Conversation

@raulcd

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-*

@github-actions

Copy link
Copy Markdown

Revision: f480ce2

Submitted crossbow builds: ursacomputing/crossbow @ actions-eeaf16b68f

TaskStatus
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-macos-mavericks-cp310-amd64Github Actions
wheel-macos-mavericks-cp37-amd64Github Actions
wheel-macos-mavericks-cp38-amd64Github Actions
wheel-macos-mavericks-cp39-amd64Github Actions
wheel-manylinux2010-cp310-amd64Github Actions
wheel-manylinux2010-cp37-amd64Github Actions
wheel-manylinux2010-cp38-amd64Github Actions
wheel-manylinux2010-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@raulcd

Copy link
Copy Markdown
MemberAuthor

@github-actions crossbow submit wheel-windows-*

@github-actions

Copy link
Copy Markdown

Revision: f719c6e

Submitted crossbow builds: ursacomputing/crossbow @ actions-f320088931

TaskStatus
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@raulcd
raulcd marked this pull request as ready for review May 26, 2022 18:40
@raulcd

Copy link
Copy Markdown
MemberAuthor

@kou@kszucs if you have some time, let me know what do you think of this PR. We were not adding substrait, neither testing it, to our Python wheels previously.

@kszucskszucs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raulcd!

kou
kou approved these changes May 26, 2022

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit f3e09b9 into apache:masterMay 26, 2022
@kou

kou commented May 30, 2022

Copy link
Copy Markdown
Member

@raulcd This broke our doctest. Could you confirm this?

https://github.com/apache/arrow/runs/6615749316?check_suite_focus=true#step:6:5590

_______________________ [doctest] pyarrow.lib.Table.join _______________________
4663 ... 'year': [2020, 2022, 2019]})
4664 >>> df2 = pd.DataFrame({'id': [3, 4],
4665 ... 'n_legs': [5, 100],
4666 ... 'animal': ["Brittle stars", "Centipede"]})
4667 >>> t1 = pa.Table.from_pandas(df1)
4668 >>> t2 = pa.Table.from_pandas(df2)
4669 4670 Left outer join:
4671 4672 >>> t1.join(t2, 'id')
Differences (unified diff with -expected +actual):
@@ -2,9 +2,9 @@
id: int64
year: int64
+animal: string
n_legs: int64
-animal: string
----
id: [[3,1,2]]
year: [[2019,2020,2022]]
+animal: [["Brittle stars",null,null]]
n_legs: [[5,null,null]]
-animal: [["Brittle stars",null,null]]

@raulcd

Copy link
Copy Markdown
MemberAuthor

@AlenkaF@jorisvandenbossche Do you know if the output order for these doctests should be deterministic? I can see the errors on master started when we merged this PR as @kou is pointing out but that PR is supposed to only add substrait to our wheels when they are being built but has nothing to do on the job that builds documentation and runs doctests.

@AlenkaF

Copy link
Copy Markdown
Member

Oh, this test gave me trouble locally also. If I ran it twice in case of error, the error disappeared.
I am sure this is not connected to this PR but to this one: #13204.

Will research and fix the issue. Thanks Raul for the ping!

@AlenkaF

Copy link
Copy Markdown
Member

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@raulcd@kou@AlenkaF@kszucs