Uh oh!
There was an error while loading. Please reload this page.
ARROW-16941: [Java][Dataset] Update more jni_util.h paths - #13503
Merged
Conversation
This is a follow-up of apache#13481. We also need to update jni_util.h path in java/dataset/src/main/cpp/jni_util_test.cc. Removing "./" is needless but it's redundant.
kou
commented
Jul 4, 2022
MemberAuthor
Cc: @lwhite1 |
lidavidm
approved these changes
Jul 4, 2022
lidavidm
left a comment
Member
There was a problem hiding this comment.
Thanks for catching this, Kou (would have thought CI tests this, does it not?)
kou
commented
Jul 4, 2022
MemberAuthor
It seems that we don't have a job that uses |
kou
commented
Jul 4, 2022
MemberAuthor
Should we also add the following change to this pull request? diff --git a/ci/docker/linux-apt-jni.dockerfile b/ci/docker/linux-apt-jni.dockerfile
index 6673b001d7..be6562eae6 100644
--- a/ci/docker/linux-apt-jni.dockerfile+++ b/ci/docker/linux-apt-jni.dockerfile@@ -69,7 +69,7 @@ ARG cmake=3.11.4
RUN wget -nv -O - https://github.com/Kitware/CMake/releases/download/v${cmake}/cmake-${cmake}-Linux-x86_64.tar.gz | tar -xzf - -C /opt
ENV PATH=/opt/cmake-${cmake}-Linux-x86_64/bin:$PATH
-ENV ARROW_BUILD_TESTS=OFF \+ENV ARROW_BUILD_TESTS=ON \
ARROW_DATASET=ON \
ARROW_FLIGHT=OFF \
ARROW_GANDIVA_JAVA=ON \ |
lidavidm
commented
Jul 4, 2022
Member
Yes, let's make sure at least one CI job covers this. |
kou
commented
Jul 5, 2022
MemberAuthor
OK. I enable it. |
kou
commented
Jul 5, 2022
MemberAuthor
+1 |
drin pushed a commit
to drin/arrow
that referenced
this pull request
Jul 5, 2022
This is a follow-up of apache#13481. We also need to update jni_util.h path in java/dataset/src/main/cpp/jni_util_test.cc. Removing "./" is needless but it's redundant. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
This is a follow-up of apache#13481. We also need to update jni_util.h path in java/dataset/src/main/cpp/jni_util_test.cc. Removing "./" is needless but it's redundant. Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #13481.
We also need to update jni_util.h path in
java/dataset/src/main/cpp/jni_util_test.cc.
Removing "./" is needless but it's redundant.