ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516

Merged
pitrou merged 13 commits into
apache:masterfrom
rok:ARROW-16981
Sep 21, 2022
Merged

ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom
rok:ARROW-16981

Conversation

@rok

@rokrok commented Jul 5, 2022

Copy link
Copy Markdown
Member

This is to resolve ARROW-16981.

@github-actions

github-actionsBot commented Jul 5, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981

@github-actions

github-actionsBot commented Jul 5, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

lidavidm
lidavidm reviewed Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc Outdated
Comment threadcpp/src/arrow/memory_pool.h Outdated
pitrou
pitrou reviewed Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h Outdated
Comment threadcpp/src/arrow/memory_pool.h Outdated
Comment threadcpp/src/arrow/memory_pool.h Outdated
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc Outdated
@rok
rokforce-pushed the ARROW-16981 branch 2 times, most recently from b58b1d9 to 3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm reviewed Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc Outdated
Comment threadcpp/src/arrow/memory_pool.h Outdated
@rok
rok marked this pull request as ready for review September 8, 2022 20:04
@rok
rokforce-pushed the ARROW-16981 branch 2 times, most recently from 9dac9b4 to 307063dCompareSeptember 8, 2022 20:29
@rok

rok commented Sep 9, 2022

Copy link
Copy Markdown
MemberAuthor

@pitrou any idea why is overloading not allowed? It builds and works ok locally.

@lidavidm

lidavidm commented Sep 9, 2022

Copy link
Copy Markdown
Member

presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)

pitrou
pitrou reviewed Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h Outdated
pitrou
pitrou reviewed Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h Outdated
pitrou
pitrou reviewed Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h Outdated
@rok
rokforce-pushed the ARROW-16981 branch 3 times, most recently from 2224027 to d1b68edCompareSeptember 9, 2022 21:20
@rok

rok commented Sep 9, 2022

Copy link
Copy Markdown
MemberAuthor

Do we want Python binding for these as well?

@pitrou

pitrou commented Sep 10, 2022

Copy link
Copy Markdown
Member

I don't know, why not? Can be a separate JIRA, though.

@rok

rok commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

Added ARROW-17685 for the Python wrapper.

@rok
rokforce-pushed the ARROW-16981 branch 6 times, most recently from 1df8c26 to f06e125CompareSeptember 15, 2022 13:51
rok
rok commented Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h Outdated
rok
rok commented Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h Outdated
benibus
benibus reviewed Sep 20, 2022
View reviewed changes

@benibusbenibus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.

Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.

Comment threadcpp/src/arrow/memory_pool.h Outdated
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc Outdated
Comment threadcpp/src/arrow/memory_pool.cc Outdated
Comment threadcpp/src/arrow/memory_pool_test.cc Outdated
@rok

rok commented Sep 20, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.

This looks good to me! Thanks a lot @benibus !

Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.

Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.

I've also linted and rebased.

@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok requested a review from pitrouSeptember 20, 2022 10:22
pitrou
pitrou requested changes Sep 21, 2022
View reviewed changes

@pitroupitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc Outdated
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc Outdated
auto cb_wrapper = [](void* opaque, const char* str) {
(*static_cast<std::function<void(const char*)>*>(opaque))(str);
};
if (write_cb) {

@pitroupitrouSep 21, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.

@rokrokSep 21, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?

Comment threadcpp/src/arrow/memory_pool_test.cc Outdated
Comment threadcpp/src/arrow/memory_pool_test.cc Outdated
rokand others added 2 commits September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok

rok commented Sep 21, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Thanks for the review @pitrou! I've addressed your points.

@pitrou
pitrou merged commit 8d11e3d into apache:masterSep 21, 2022
@pitrou

pitrou commented Sep 21, 2022

Copy link
Copy Markdown
Member

Thanks a lot @rok and @benibus !

@rok

rok commented Sep 21, 2022

Copy link
Copy Markdown
MemberAuthor

Thank you @pitrou & @benibus! :)

@ursabot

ursabot commented Sep 21, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2
[Failed] 8d11e3dd test-mac-arm
[Failed] 8d11e3dd ursa-i9-9960x
[Finished] 8d11e3dd ursa-thinkcentre-m75q
[Finished] bd433c01 ec2-t3-xlarge-us-east-2
[Finished] bd433c01 test-mac-arm
[Failed] bd433c01 ursa-i9-9960x
[Finished] bd433c01 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport mentioned this pull request Sep 21, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes
+1 more reviewer
@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++Component: FlightRPC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-16981: [C++] Expose jemalloc statistics for logging - #13516
Merged
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Sep 21, 2022
Merged
ARROW-16981: [C++] Expose jemalloc statistics for logging#13516
pitrou merged 13 commits into
apache:masterfrom 
rok:ARROW-16981
Conversation
@rok
@rokrok
commented
Jul 5, 2022

Copy link


Copy Markdown

Member
This is to resolve ARROW-16981.
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16981
@github-actions
github-actionsBot
commented
Jul 5, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
lidavidm
lidavidm
reviewed
Jul 5, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Jul 11, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
b58b1d9 to
3ccabc3CompareSeptember 5, 2022 19:51
lidavidm
lidavidm
reviewed
Sep 6, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rok
marked this pull request as ready for review
September 8, 2022 20:04
@rok
rokforce-pushed
the
ARROW-16981
branch
2 times, most recently
from
9dac9b4 to
307063dCompareSeptember 8, 2022 20:29
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
@pitrou any idea why is overloading not allowed? It builds and works ok locally.
@lidavidm
lidavidm
commented
Sep 9, 2022

Copy link


Copy Markdown

Member
presumably because uint64_t and size_t are actually the same type on those platforms (also, we use raw pointers for out parameters, not references, typically)
pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

pitrou
pitrou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

@rok
rokforce-pushed
the
ARROW-16981
branch
3 times, most recently
from
2224027 to
d1b68edCompareSeptember 9, 2022 21:20
@rok
rok
commented
Sep 9, 2022

Copy link


Copy Markdown

MemberAuthor
Do we want Python binding for these as well?
@pitrou
pitrou
commented
Sep 10, 2022

Copy link


Copy Markdown

Member
I don't know, why not? Can be a separate JIRA, though.
@rok
rok
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Added ARROW-17685 for the Python wrapper.
@rok
rokforce-pushed
the
ARROW-16981
branch
6 times, most recently
from
1df8c26 to
f06e125CompareSeptember 15, 2022 13:51
rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/sql/types.h
Outdated

rok
rok
commented
Sep 17, 2022
View reviewed changes
Comment threadcpp/src/arrow/memory_pool.h
Outdated

benibus
benibus
reviewed
Sep 20, 2022
View reviewed changes
@benibusbenibus
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Comment threadcpp/src/arrow/memory_pool.h
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

@rok
rok
commented
Sep 20, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Here are some potential changes for implementing the callback API with std::function, which uses closures instead of a client-provided void*. I updated the relevant tests as well.
This looks good to me! Thanks a lot @benibus !
Hopefully this is the correct method of suggesting patches... the github diffs appear to be against the base branch, not the latest commit.
Well this was pretty nice for me but maybe extra work for you :). I added you as a collaborator to my fork in case you'd want to push more changes to this branch and avoid the UI.
I've also linted and rebased.
@rok@benibus
Apply suggestions from code review
1af3ef5
Co-authored-by: Ben Harkins <60872452+benibus@users.noreply.github.com>
@rok
rok
requested a review
from pitrouSeptember 20, 2022 10:22
pitrou
pitrou
requested changes
Sep 21, 2022
View reviewed changes
@pitroupitrou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some further comments below, but looks good on the principle.
Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_jemalloc.cc
Outdated

 auto cb_wrapper = [](void* opaque, const char* str) {
 (*static_cast<std::function<void(const char*)>*>(opaque))(str);
 };
 if (write_cb) {
@pitroupitrouSep 21, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? I think the caller should make sure that write_cb is initialized.
@rokrokSep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not but not sure. I removed it for now. @benibus do you think this would be needed?
Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

Comment threadcpp/src/arrow/memory_pool_test.cc
Outdated

rokand others
added 2 commits
September 21, 2022 13:01
@rok@pitrou
Update cpp/src/arrow/memory_pool_test.cc
5c2eefc
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
@rok
Review feedback
8f3b32f
@rok
rok
commented
Sep 21, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Thanks for the review @pitrou! I've addressed your points.
@pitrou
pitrou
merged commit 8d11e3d
into
apache:masterSep 21, 2022
@pitrou
pitrou
commented
Sep 21, 2022

Copy link


Copy Markdown

Member
Thanks a lot @rok and @benibus !
@rok
rok
commented
Sep 21, 2022

Copy link


Copy Markdown

MemberAuthor
Thank you @pitrou & @benibus! :)
@ursabot
ursabot
commented
Sep 21, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = bd433c0 and contender = 8d11e3d. 8d11e3d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.14% ⬆️0.1%] test-mac-arm

[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x

[Finished ⬇️0.78% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 8d11e3dd ec2-t3-xlarge-us-east-2

[Failed] 8d11e3dd test-mac-arm

[Failed] 8d11e3dd ursa-i9-9960x

[Finished] 8d11e3dd ursa-thinkcentre-m75q

[Finished] bd433c01 ec2-t3-xlarge-us-east-2

[Finished] bd433c01 test-mac-arm

[Failed] bd433c01 ursa-i9-9960x

[Finished] bd433c01 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@rok@zagto
ARROW-16981: [C++] Expose jemalloc statistics for logging (apache#13516)
93f37b7
This is to resolve [ARROW-16981](https://issues.apache.org/jira/browse/ARROW-16981).
Lead-authored-by: Rok <rok@mihevc.org>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@asfimportasfimport
mentioned this pull request
Sep 21, 2022

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lidavidmlidavidmlidavidm left review comments
@pitroupitroupitrou approved these changes

+1 more reviewer

@benibusbenibusbenibus left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: FlightRPC

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@rok@lidavidm@pitrou@ursabot@benibus