Uh oh!
There was an error while loading. Please reload this page.
ARROW-16879: [R][CI] Test R GCS bindings with testbench - #13542
Conversation
wjones127
commented
Jul 11, 2022
Tests seem to be failing right now because of a difference in how GCS and S3 handle paths: library(arrow)
#> #> Attaching package: 'arrow'#> The following object is masked from 'package:utils':#> #> timestampexample_data<- arrow_table(x=Array$create(c(1, 2, 3)))
testbench_port<- Sys.getenv("TESTBENCH_PORT", "9001")
fs<-GcsFileSystem$create(
endpoint_override= sprintf("localhost:%s", testbench_port),
retry_limit_seconds=1,
scheme="http",
anonymous=TRUE# Will fail to resolve host name if anonymous isn't TRUE
)
fs$CreateDir("test")
write_parquet(example_data, fs$path("test/test.parquet"))
write_parquet(example_data, fs$path("test/test.parquet/"))
# GCS seems to handle them as separate pathsfs$ls("test")
#> [1] "test/test.parquet" "test/test.parquet"minio_key<- Sys.getenv("MINIO_ACCESS_KEY", "minioadmin")
minio_secret<- Sys.getenv("MINIO_SECRET_KEY", "minioadmin")
minio_port<- Sys.getenv("MINIO_PORT", "9000")
fs<-S3FileSystem$create(
access_key=minio_key,
secret_key=minio_secret,
scheme="http",
endpoint_override= paste0("localhost:", minio_port),
allow_bucket_creation=TRUE,
allow_bucket_deletion=TRUE
)
fs$CreateDir("test")
write_parquet(example_data, fs$path("test/test.parquet"))
write_parquet(example_data, fs$path("test/test.parquet/"))
# S3 implementation seems to remove the last slashfs$ls("test")
#> [1] "test/test.parquet"Created on 2022-07-11 by the reprex package (v2.0.1) |
7c3bc5d to
8710059Comparewjones127
commented
Jul 12, 2022
I've included the change set from #13577. The C++ changes will go away when I rebase after merging that PR. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f059ed4 to
c4fd663Compare
nealrichardson
left a comment
There was a problem hiding this comment.
This is really cool, thanks for doing this.
Uh oh!
There was an error while loading. Please reload this page.
paleolimbot
left a comment
There was a problem hiding this comment.
Just a few notes! Looks great!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
609a166 to
66c3c84Compare66c3c84 to
f107de9CompareUh oh!
There was an error while loading. Please reload this page.
8fe2c67 to
b42042aCompare
nealrichardson
left a comment
There was a problem hiding this comment.
CI failure is unrelated, will merge
ursabot
commented
Oct 4, 2022
Benchmark runs are scheduled for baseline = 4660180 and contender = b7f9dfc. b7f9dfc is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
This PR:
GcsFileSystem$create()(andgs_bucket()introducted in ARROW-16887: [R][Docs] Update Filesystem Vignette for GCS #13601), but not URIs.