Uh oh!
There was an error while loading. Please reload this page.
ARROW-16757: [C++][FOLLOWUP] Fix mingw32 RTools 4.0 build by removing usage of alignas - #13557
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
I added some checks to prevent the filter implementations from running in the 0-length chunked array cases, and a different filter test started failing: test_that("[ accepts Arrays and otherwise handles bad input", {
vec<-11:20a<-Array$create(vec)
ind<- c(9, 3, 5)
expect_error(
a[Array$create(ind)],
"Cannot extract rows with an Array of type double"
)
expect_as_vector(a[Array$create(ind-1, type= int8())], vec[ind])
expect_as_vector(a[Array$create(ind-1, type= uint8())], vec[ind])
expect_as_vector(a[ChunkedArray$create(8, 2, 4, type= uint8())], vec[ind])
filt<- seq_along(vec) %in%ind
expect_as_vector(a[Array$create(filt)], vec[filt])
expect_error(
a["string"],
"Cannot extract rows with an object of class character"
)
})It segfaults on This is good because it's a normal array being filtered, but I'm still perplexed why #13521 would have caused this. |
wesm
commented
Jul 9, 2022
@nealrichardson@wjones127@pitrou@paleolimbot so bizarrely, I had mistakenly used |
Using
alignas(64)(instead ofalignas(8)) seemed to break this build.