ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991

Merged
pitrou merged 2 commits into
apache:masterfrom
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged

ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom
pitrou:ARROW-17545-cpp17

Conversation

@pitrou

@pitroupitrou commented Aug 29, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This PR switches our build system to require C++17 instead of C++11.

Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.

@github-actions

github-actionsBot commented Aug 29, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545

@github-actions

github-actionsBot commented Aug 29, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@TomAugspurgerTomAugspurger mentioned this pull request Aug 29, 2022
Closed
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

pitrou commented Aug 29, 2022

Copy link
Copy Markdown
MemberAuthor

@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?

@pitrou

pitrou commented Aug 29, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The packaging jobs fail at the "upload artifacts" step with a weird error:

archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47

@raulcd Do you know where that might come from?

@raulcd

raulcd commented Aug 29, 2022

Copy link
Copy Markdown
Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47

@raulcd Do you know where that might come from?

I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:

>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex

@pitrou

pitrou commented Aug 29, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?

I did not use anything, I let archery crossbow submit use its own defaults.

@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou mentioned this pull request Aug 29, 2022
Merged
@pitrou

This comment was marked as outdated.

Sign in to view
@kou

kou commented Aug 29, 2022

Copy link
Copy Markdown
Member

@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?

Sure. The following patch will work:

diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

pitrou commented Aug 30, 2022

Copy link
Copy Markdown
MemberAuthor

@kou The CentOS 7 patched build now fails with:

error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097

Would you like to suggest or push a fix?

@kou

kou commented Aug 30, 2022

Copy link
Copy Markdown
Member

Oh, sorry. I'll push a fix to this branch later.

@pitroupitrou mentioned this pull request Aug 30, 2022
Merged
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

pitrou commented Sep 8, 2022

Copy link
Copy Markdown
MemberAuthor

(rebased)

@pitrou

pitrou commented Sep 8, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.

kou
kou approved these changes Sep 9, 2022
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Comment thread.github/workflows/r.yml Outdated
Comment threadcpp/src/gandiva/CMakeLists.txt Outdated
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

pitrou commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

Revision: fb53ff7

Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20

TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions

@pitrou

pitrou commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.

It seems like this was fixed in the meantime (on git master?).

@pitrou

pitrou commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).

@pitrou

pitrou commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

Revision: 24a9099

Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21

TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure

@pitrou

pitrou commented Sep 12, 2022

Copy link
Copy Markdown
MemberAuthor

I will merge if CI turns out as green as can be hoped given the current failures on git master.

@h-vetinari

h-vetinari commented Sep 12, 2022

Copy link
Copy Markdown
Contributor

@pitrou, just FYI, you might be interested in #14102

@pitrou
pitrou merged commit 9d65981 into apache:masterSep 13, 2022
@pitrou
pitrou deleted the ARROW-17545-cpp17 branch September 13, 2022 06:40
@ursabot

ursabot commented Sep 13, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm
[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x
[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 9d659810 ec2-t3-xlarge-us-east-2
[Failed] 9d659810 test-mac-arm
[Failed] 9d659810 ursa-i9-9960x
[Finished] 9d659810 ursa-thinkcentre-m75q
[Finished] c9844f05 ec2-t3-xlarge-us-east-2
[Failed] c9844f05 test-mac-arm
[Failed] c9844f05 ursa-i9-9960x
[Finished] c9844f05 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot

ursabot commented Sep 13, 2022

Copy link
Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@h-vetinarih-vetinari mentioned this pull request Sep 17, 2022
Merged
zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd mentioned this pull request Dec 15, 2022
Closed
@raulcdraulcd mentioned this pull request Dec 22, 2023
Closed
3 tasks
@koukou mentioned this pull request Dec 16, 2024
Merged
@raulcdraulcd mentioned this pull request Apr 29, 2025
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes
+1 more reviewer
@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 - #13991
Merged
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Sep 13, 2022
Merged
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11#13991
pitrou merged 2 commits into
apache:masterfrom 
pitrou:ARROW-17545-cpp17
Conversation
@pitrou
@pitroupitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

Member
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17545
@github-actions
github-actionsBot
commented
Aug 29, 2022

Copy link


Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.
@TomAugspurgerTomAugspurger
mentioned this pull request
Aug 29, 2022
 Closed

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 29, 2022

Copy link


Copy Markdown

MemberAuthor
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
The packaging jobs fail at the "upload artifacts" step with a weird error:
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
@raulcd
raulcd
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
archery.crossbow.core.CrossbowError: Unable to parse the github owner and repository from the repository's remote url 'https://github.com/ursacomputing/crossbow/'

https://github.com/ursacomputing/crossbow/runs/8075587016?check_suite_focus=true#step:11:47
@raulcd Do you know where that might come from?
I am not entirely sure why the remote is different but on a successful nightly job https://github.com/ursacomputing/crossbow/runs/8066802928?check_suite_focus=true#step:11:4 the archery command uses: --queue-remote https://github.com/ursacomputing/crossbow  but on your job --queue-remote https://github.com/ursacomputing/crossbow/ making the regex to select the user repo fail:
>>> remote_url = "https://github.com/ursacomputing/crossbow"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m
<re.Match object; span=(0, 41), match='https://github.com/ursacomputing/crossbow'>
>>> remote_url = "https://github.com/ursacomputing/crossbow/"
>>> m = re.match(r'.*\/([^\/]+)\/([^\/\.]+)(\.git)?$', remote_url)
>>> m

Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs? We probably should improve the regex
@pitrou
pitrou
commented
Aug 29, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Did you use https://github.com/ursacomputing/crossbow/ on the --queue-remote when submitting the jobs?
I did not use anything, I let archery crossbow submit use its own defaults.
@pitrou

This comment was marked as outdated.

Sign in to view
@pitroupitrou
mentioned this pull request
Aug 29, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@kou
kou
commented
Aug 29, 2022

Copy link


Copy Markdown

Member
@kou It seems the centos-7-amd64 job uses gcc 4.8.5, should we switch to the devtoolset instead?
Sure. The following patch will work:
diff --git a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile
index 04e74012f9..1da8e0fb79 100644
--- a/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile+++ b/dev/tasks/linux-packages/apache-arrow/yum/centos-7/Dockerfile@@ -18,13 +18,20 @@
ARG FROM=centos:7
FROM ${FROM}
+ENV \+ SCL=devtoolset-11+
ARG DEBUG
RUN \
quiet=$([ "${DEBUG}" = "yes" ] || echo "--quiet") && \
yum update -y ${quiet} && \
- yum install -y ${quiet} epel-release && \
yum install -y ${quiet} \
+ centos-release-scl-rh \+ epel-release && \+ yum install -y ${quiet} \+ ${SCL}-gcc-c++ \+ ${SCL}-make \
bison \
boost169-devel \
brotli-devel \
@@ -33,7 +40,6 @@ RUN \
cmake3 \
curl-devel \
flex \
- gcc-c++ \
gflags-devel \
git \
glog-devel \
@@ -42,7 +48,6 @@ RUN \
json-devel \
libzstd-devel \
lz4-devel \
- make \
ninja-build \
openssl-devel \
pkg-config \
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Aug 30, 2022

Copy link


Copy Markdown

MemberAuthor
@kou The CentOS 7 patched build now fails with:
error: Failed build dependencies:
gcc-c++ is needed by arrow-10.0.0.dev145-1.el7.x86_64

https://github.com/ursacomputing/crossbow/runs/8088068865?check_suite_focus=true#step:6:2097
Would you like to suggest or push a fix?
@kou
kou
commented
Aug 30, 2022

Copy link


Copy Markdown

Member
Oh, sorry. I'll push a fix to this branch later.
@pitroupitrou
mentioned this pull request
Aug 30, 2022
 Merged

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 8, 2022

Copy link


Copy Markdown

MemberAuthor
(rebased)
@pitrou
pitrou
commented
Sep 8, 2022•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
kou
kou
approved these changes
Sep 9, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
Comment thread.github/workflows/r.yml
Outdated

Comment threadcpp/src/gandiva/CMakeLists.txt
Outdated

@pitrou

This comment was marked as outdated.

Sign in to view
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: fb53ff7
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-20
TaskStatus
almalinux-8-amd64Github Actions
almalinux-8-arm64TravisCI
almalinux-9-amd64Github Actions
almalinux-9-arm64TravisCI
amazon-linux-2-amd64Github Actions
amazon-linux-2-arm64TravisCI
centos-7-amd64Github Actions
centos-8-stream-amd64Github Actions
centos-8-stream-arm64TravisCI
centos-9-stream-amd64Github Actions
centos-9-stream-arm64TravisCI
conan-maximumGithub Actions
conan-minimumGithub Actions
conda-cleanAzure
conda-linux-gcc-py310-arm64Azure
conda-linux-gcc-py310-cpuAzure
conda-linux-gcc-py310-cudaAzure
conda-linux-gcc-py310-ppc64leAzure
conda-linux-gcc-py37-arm64Azure
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-linux-gcc-py37-cudaAzure
conda-linux-gcc-py37-ppc64leAzure
conda-linux-gcc-py38-arm64Azure
conda-linux-gcc-py38-cpuAzure
conda-linux-gcc-py38-cudaAzure
conda-linux-gcc-py38-ppc64leAzure
conda-linux-gcc-py39-arm64Azure
conda-linux-gcc-py39-cpuAzure
conda-linux-gcc-py39-cudaAzure
conda-linux-gcc-py39-ppc64leAzure
conda-osx-arm64-clang-py310Azure
conda-osx-arm64-clang-py38Azure
conda-osx-arm64-clang-py39Azure
conda-osx-clang-py310Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-osx-clang-py38Azure
conda-osx-clang-py39Azure
conda-win-vs2019-py310Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
conda-win-vs2019-py38Azure
conda-win-vs2019-py39Azure
debian-bookworm-amd64Github Actions
debian-bookworm-arm64TravisCI
debian-bullseye-amd64Github Actions
debian-bullseye-arm64TravisCI
example-cpp-minimal-build-staticGithub Actions
example-cpp-minimal-build-static-system-dependencyGithub Actions
example-python-minimal-build-fedora-condaGithub Actions
example-python-minimal-build-ubuntu-venvGithub Actions
homebrew-cppGithub Actions
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
java-jarsGithub Actions
nugetGithub Actions
python-sdistGithub Actions
r-binary-packagesGithub Actions
test-alpine-linux-cppGithub Actions
test-build-cpp-fuzzGithub Actions
test-build-vcpkg-winGithub Actions
test-conda-cppGithub Actions
test-conda-cpp-valgrindAzure
test-conda-python-3.10Github Actions
test-conda-python-3.7Github Actions
test-conda-python-3.7-hdfs-2.9.2Github Actions
test-conda-python-3.7-hdfs-3.2.1Github Actions
test-conda-python-3.7-kartothek-latestGithub Actions
test-conda-python-3.7-kartothek-masterGithub Actions
test-conda-python-3.7-pandas-0.24Github Actions
test-conda-python-3.7-pandas-latestGithub Actions
test-conda-python-3.7-spark-v3.1.2Github Actions
test-conda-python-3.8Github Actions
test-conda-python-3.8-hypothesisGithub Actions
test-conda-python-3.8-pandas-latestGithub Actions
test-conda-python-3.8-pandas-nightlyGithub Actions
test-conda-python-3.8-spark-v3.2.0Github Actions
test-conda-python-3.9Github Actions
test-conda-python-3.9-dask-latestGithub Actions
test-conda-python-3.9-dask-masterGithub Actions
test-conda-python-3.9-pandas-masterGithub Actions
test-conda-python-3.9-spark-masterGithub Actions
test-debian-10-cpp-amd64Github Actions
test-debian-10-cpp-i386Github Actions
test-debian-11-cpp-amd64Github Actions
test-debian-11-cpp-i386Github Actions
test-debian-11-go-1.17Azure
test-debian-11-python-3Azure
test-debian-c-glibGithub Actions
test-debian-rubyGithub Actions
test-fedora-35-cppGithub Actions
test-fedora-35-python-3Azure
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-skyhook-integrationGithub Actions
test-ubuntu-18.04-cppGithub Actions
test-ubuntu-18.04-cpp-releaseGithub Actions
test-ubuntu-18.04-cpp-staticGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
test-ubuntu-20.04-cppGithub Actions
test-ubuntu-20.04-cpp-17Github Actions
test-ubuntu-20.04-cpp-bundledGithub Actions
test-ubuntu-20.04-cpp-thread-sanitizerGithub Actions
test-ubuntu-20.04-python-3Azure
test-ubuntu-22.04-cppGithub Actions
test-ubuntu-c-glibGithub Actions
test-ubuntu-default-docsAzure
test-ubuntu-rubyGithub Actions
ubuntu-bionic-amd64Github Actions
ubuntu-bionic-arm64TravisCI
ubuntu-focal-amd64Github Actions
ubuntu-focal-arm64TravisCI
ubuntu-jammy-amd64Github Actions
ubuntu-jammy-arm64TravisCI
wheel-macos-big-sur-cp310-arm64Github Actions
wheel-macos-big-sur-cp310-universal2Github Actions
wheel-macos-big-sur-cp38-arm64Github Actions
wheel-macos-big-sur-cp39-arm64Github Actions
wheel-macos-big-sur-cp39-universal2Github Actions
wheel-macos-high-sierra-cp310-amd64Github Actions
wheel-macos-high-sierra-cp37-amd64Github Actions
wheel-macos-high-sierra-cp38-amd64Github Actions
wheel-macos-high-sierra-cp39-amd64Github Actions
wheel-manylinux2014-cp310-amd64Github Actions
wheel-manylinux2014-cp310-arm64TravisCI
wheel-manylinux2014-cp37-amd64Github Actions
wheel-manylinux2014-cp37-arm64TravisCI
wheel-manylinux2014-cp38-amd64Github Actions
wheel-manylinux2014-cp38-arm64TravisCI
wheel-manylinux2014-cp39-amd64Github Actions
wheel-manylinux2014-cp39-arm64TravisCI
wheel-windows-cp310-amd64Github Actions
wheel-windows-cp37-amd64Github Actions
wheel-windows-cp38-amd64Github Actions
wheel-windows-cp39-amd64Github Actions
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Hmm, I think I need to investigate the "Sphinx & Numpydoc" CI failure to see if it's caused by these changes.
It seems like this was fixed in the meantime (on git master?).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
The Travis-CI s390x build times out. I don't think there's anything we can do against it, though (short of making the build optional).
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
Revision: 24a9099
Submitted crossbow builds: ursacomputing/crossbow @ cxx17-21
TaskStatus
conda-linux-gcc-py37-cpu-r40Azure
conda-linux-gcc-py37-cpu-r41Azure
conda-osx-clang-py37-r40Azure
conda-osx-clang-py37-r41Azure
conda-win-vs2019-py37-r40Azure
conda-win-vs2019-py37-r41Azure
homebrew-r-autobrewGithub Actions
homebrew-r-brewGithub Actions
r-binary-packagesGithub Actions
test-fedora-r-clang-sanitizerAzure
test-r-arrow-backwards-compatibilityGithub Actions
test-r-depsource-bundledAzure
test-r-depsource-systemGithub Actions
test-r-dev-duckdbGithub Actions
test-r-devdocsGithub Actions
test-r-gcc-11Github Actions
test-r-gcc-12Github Actions
test-r-install-localGithub Actions
test-r-linux-as-cranGithub Actions
test-r-linux-rchkGithub Actions
test-r-linux-valgrindAzure
test-r-minimal-buildAzure
test-r-offline-maximalGithub Actions
test-r-offline-minimalAzure
test-r-rhub-debian-gcc-devel-lto-latestAzure
test-r-rhub-debian-gcc-release-custom-ccacheAzure
test-r-rhub-ubuntu-gcc-release-latestAzure
test-r-rocker-r-base-latestAzure
test-r-rstudio-r-base-4.1-opensuse153Azure
test-r-rstudio-r-base-4.2-centos7-devtoolset-8Azure
test-r-rstudio-r-base-4.2-focalAzure
test-r-ubuntu-22.04Github Actions
test-r-versionsGithub Actions
test-ubuntu-18.04-r-sanitizerAzure
@pitrou
pitrou
commented
Sep 12, 2022

Copy link


Copy Markdown

MemberAuthor
I will merge if CI turns out as green as can be hoped given the current failures on git master.
@h-vetinari
h-vetinari
commented
Sep 12, 2022

Copy link


Copy Markdown

Contributor
@pitrou, just FYI, you might be interested in #14102
@pitrou
pitrou
merged commit 9d65981
into
apache:masterSep 13, 2022
@pitrou
pitrou
deleted the

ARROW-17545-cpp17

branch
September 13, 2022 06:40
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = c9844f0 and contender = 9d65981. 9d65981 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.58% ⬆️0.54%] test-mac-arm

[Failed ⬇️0.85% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️4.12% ⬆️2.27%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 9d659810 ec2-t3-xlarge-us-east-2

[Failed] 9d659810 test-mac-arm

[Failed] 9d659810 ursa-i9-9960x

[Finished] 9d659810 ursa-thinkcentre-m75q

[Finished] c9844f05 ec2-t3-xlarge-us-east-2

[Failed] c9844f05 test-mac-arm

[Failed] c9844f05 ursa-i9-9960x

[Finished] c9844f05 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
@ursabot
ursabot
commented
Sep 13, 2022

Copy link


Copy Markdown

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x
@h-vetinarih-vetinari
mentioned this pull request
Sep 17, 2022
 Merged

zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@pitrou@zagto
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
3265b81
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@raulcdraulcd
mentioned this pull request
Dec 15, 2022

Closed

@raulcdraulcd
mentioned this pull request
Dec 22, 2023
 Closed

3 tasks
@koukou
mentioned this pull request
Dec 16, 2024
 Merged

@raulcdraulcd
mentioned this pull request
Apr 29, 2025

Closed

pribor pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
@pitrou@kou
ARROW-17545: [C++][CI] Mandate C++17 instead of C++11 (apache#13991)
1233f3c
This PR switches our build system to require C++17 instead of C++11.
Because the conda packaging jobs are out of sync with the conda-forge files, the Windows conda packaging jobs are broken with this change. The related task (sync conda packaging files with conda-forge) is tracked in ARROW-17635.
Authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson left review comments
@koukoukou approved these changes

+1 more reviewer

@h-vetinarih-vetinarih-vetinari left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

Component: C++Component: DocumentationComponent: GandivaComponent: GLibComponent: JavaComponent: MATLABComponent: ParquetComponent: PythonComponent: RComponent: Ruby

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@pitrou@raulcd@kou@lidavidm@h-vetinari@nealrichardson@ursabot