Skip to content

ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 21 commits into from
Nov 10, 2022
Merged

ARROW-17613: [C++] Add function execution API for a preconfigured kernel #14043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3855d43
ARROW-17613: [C++] Add function execution API for a preconfigured kernel
rtpsw Sep 5, 2022
7f6c189
Fix declarations
rtpsw Sep 5, 2022
eb93a9c
cleanup
rtpsw Sep 5, 2022
d47b901
requested changes
rtpsw Sep 9, 2022
8c3d07b
lint
rtpsw Sep 9, 2022
9366eb9
requested fixed, add test
rtpsw Sep 25, 2022
3844fbc
Merge branch 'master' into ARROW-17613
rtpsw Sep 25, 2022
1815844
fix for C++17
rtpsw Sep 25, 2022
a025492
fix status checking
rtpsw Sep 25, 2022
65ef921
fix test function options
rtpsw Sep 26, 2022
516452e
fix symbol exporting
rtpsw Sep 27, 2022
62f8884
suggested changes
rtpsw Oct 13, 2022
115a59c
Update cpp/src/arrow/compute/exec.h
rtpsw Nov 6, 2022
88f2650
Update cpp/src/arrow/compute/function.h
rtpsw Nov 6, 2022
cdb7ded
requested fixes
rtpsw Nov 8, 2022
d02b58b
fix cast
rtpsw Nov 8, 2022
43c529a
fix forward declaration
rtpsw Nov 8, 2022
798b17e
add tests
rtpsw Nov 10, 2022
0530446
fix test_compute.py
rtpsw Nov 10, 2022
143ba62
Merge branch 'master' into ARROW-17613
pitrou Nov 10, 2022
8e29636
Nits
pitrou Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions cpp/src/arrow/compute/exec.cc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
}
}
if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
data_preallocated_.clear();
ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
}

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
(kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
data_preallocated_.clear();
ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
}

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
const std::string& func_name, std::vector<TypeHolder> in_types,
const FunctionOptions* options, FunctionRegistry* func_registry) {
if (func_registry == NULLPTR) {
func_registry = GetFunctionRegistry();
}
ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
func_registry->GetFunction(func_name));
ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
ARROW_RETURN_NOT_OK(func_exec->Init(options));
return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
const std::string& func_name, const std::vector<Datum>& args,
const FunctionOptions* options, FunctionRegistry* func_registry) {
ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow
28 changes: 25 additions & 3 deletions cpp/src/arrow/compute/exec.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.
///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
const std::string& func_name, std::vector<TypeHolder> in_types,
const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
const std::string& func_name, const std::vector<Datum>& args,
const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
ARROW-17613: [C++] Add function execution API for a preconfigured kernel by rtpsw · Pull Request #14043 · apache/arrow · GitHub
Skip to content
ARROW-17613: [C++] Add function execution API for a preconfigured kernel#14043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

pitrou
merged 21 commits into

from

Nov 10, 2022
 Merged


ARROW-17613: [C++] Add function execution API for a preconfigured kernel
#14043
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


21 commits


Select commit
Hold shift + click to select a range
3855d43

ARROW-17613: [C++] Add function execution API for a preconfigured kernel


rtpsw Sep 5, 2022
7f6c189

Fix declarations


rtpsw Sep 5, 2022
eb93a9c

cleanup


rtpsw Sep 5, 2022
d47b901

requested changes


rtpsw Sep 9, 2022
8c3d07b

lint


rtpsw Sep 9, 2022
9366eb9

requested fixed, add test


rtpsw Sep 25, 2022
3844fbc

Merge branch 'master' into ARROW-17613


rtpsw Sep 25, 2022
1815844

fix for C++17


rtpsw Sep 25, 2022
a025492

fix status checking


rtpsw Sep 25, 2022
65ef921

fix test function options


rtpsw Sep 26, 2022
516452e

fix symbol exporting


rtpsw Sep 27, 2022
62f8884

suggested changes


rtpsw Oct 13, 2022
115a59c

Update cpp/src/arrow/compute/exec.h


rtpsw Nov 6, 2022
88f2650

Update cpp/src/arrow/compute/function.h


rtpsw Nov 6, 2022
cdb7ded

requested fixes


rtpsw Nov 8, 2022
d02b58b

fix cast


rtpsw Nov 8, 2022
43c529a

fix forward declaration


rtpsw Nov 8, 2022
798b17e

add tests


rtpsw Nov 10, 2022
0530446

fix test_compute.py


rtpsw Nov 10, 2022
143ba62

Merge branch 'master' into ARROW-17613


pitrou Nov 10, 2022
8e29636

Nits


pitrou Nov 10, 2022

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


23 changes: 23 additions & 0 deletions
cpp/src/arrow/compute/exec.cc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,7 @@
#include "arrow/chunked_array.h"
#include "arrow/compute/exec_internal.h"
#include "arrow/compute/function.h"
#include "arrow/compute/function_internal.h"
#include "arrow/compute/kernel.h"
#include "arrow/compute/registry.h"
#include "arrow/datum.h"
Expand DownExpand Up@@ -883,6 +884,7 @@ class ScalarExecutor : public KernelExecutorImpl<ScalarKernel> {
 }
 }
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -966,6 +968,7 @@ class VectorExecutor : public KernelExecutorImpl<VectorKernel> {
 (kernel_->null_handling != NullHandling::COMPUTED_NO_PREALLOCATE &&
 kernel_->null_handling != NullHandling::OUTPUT_NOT_NULL);
 if (kernel_->mem_allocation == MemAllocation::PREALLOCATE) {
 data_preallocated_.clear();
 ComputeDataPreallocate(*output_type_.type, &data_preallocated_);
 }

Expand DownExpand Up@@ -1316,5 +1319,25 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,
 return CallFunction(func_name, batch, /*options=*/nullptr, ctx);
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 if (func_registry == NULLPTR) {
 func_registry = GetFunctionRegistry();
 }
 ARROW_ASSIGN_OR_RAISE(std::shared_ptr<const Function> func,
 func_registry->GetFunction(func_name));
 ARROW_ASSIGN_OR_RAISE(auto func_exec, func->GetBestExecutor(std::move(in_types)));
 ARROW_RETURN_NOT_OK(func_exec->Init(options));
 return func_exec;
}

Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options, FunctionRegistry* func_registry) {
 ARROW_ASSIGN_OR_RAISE(auto in_types, internal::GetFunctionArgumentTypes(args));
 return GetFunctionExecutor(func_name, std::move(in_types), options, func_registry);
}

} // namespace compute
} // namespace arrow

28 changes: 25 additions & 3 deletions
cpp/src/arrow/compute/exec.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -47,9 +47,6 @@ class CpuInfo;

namespace compute {

class FunctionOptions;
class FunctionRegistry;

// It seems like 64K might be a good default chunksize to use for execution
// based on the experience of other query processing systems. The current
// default is not to chunk contiguous arrays, though, but this may change in
Expand DownExpand Up@@ -440,5 +437,30 @@ Result<Datum> CallFunction(const std::string& func_name, const ExecBatch& batch,

/// @}

/// \defgroup compute-function-executor One-shot calls to obtain function executors
Comment thread
rtpsw marked this conversation as resolved.

///
/// @{

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, std::vector<TypeHolder> in_types,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// \brief One-shot executor provider for all types of functions.
///
/// This function creates and initializes a `FunctionExecutor` appropriate
/// for the given function name, input types (taken from the Datum arguments)
/// and function options.
ARROW_EXPORT
Result<std::shared_ptr<FunctionExecutor>> GetFunctionExecutor(
 const std::string& func_name, const std::vector<Datum>& args,
 const FunctionOptions* options = NULLPTR, FunctionRegistry* func_registry = NULLPTR);

/// @}

} // namespace compute
} // namespace arrow
Loading