ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059

Merged
kou merged 5 commits into
apache:masterfrom
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged

ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is

Conversation

@dhruv9vats

@dhruv9vatsdhruv9vats commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.

@github-actions

github-actionsBot commented Sep 7, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632

kou
kou reviewed Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in Outdated
message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()

@koukouSep 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?

Comment threadcpp/src/arrow/ArrowConfig.cmake.in Outdated
Comment threadcpp/src/arrow/ArrowConfig.cmake.in Outdated
dhruv9vats
dhruv9vats commented Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in Outdated
Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in Outdated
@dhruv9vats
dhruv9vats requested a review from kouSeptember 7, 2022 12:14
kou
kou reviewed Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in Outdated
Comment threadcpp/src/arrow/ArrowConfig.cmake.in Outdated
Comment threadcpp/src/arrow/ArrowConfig.cmake.in Outdated
if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
string(TOUPPER ${PACKAGE_NAME} package_name_upper)
message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")

@koukouSep 9, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?

It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))

@dhruv9vatsdhruv9vatsSep 11, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:

macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in Outdated
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in Outdated
Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in Outdated
kou
kou approved these changes Sep 12, 2022
View reviewed changes

@koukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 3aee08b into apache:masterSep 12, 2022
@ursabot

ursabot commented Sep 12, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2
[Finished] 3aee08b4 test-mac-arm
[Failed] 3aee08b4 ursa-i9-9960x
[Finished] 3aee08b4 ursa-thinkcentre-m75q
[Finished] f42f3df0 ec2-t3-xlarge-us-east-2
[Failed] f42f3df0 test-mac-arm
[Failed] f42f3df0 ursa-i9-9960x
[Finished] f42f3df0 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees

No one assigned

Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build - #14059
Merged
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Sep 12, 2022
Merged
ARROW-17632: [Python][C++] Add details of where libarrow is being found during build#14059
kou merged 5 commits into
apache:masterfrom 
dhruv9vats:ARROW-17632-Add-details-of-where-lib-arrow-is
Conversation
@dhruv9vats
@dhruv9vatsdhruv9vats
commented
Sep 7, 2022

Copy link


Copy Markdown

Contributor
This PR aims to add back message(STATUS ...) statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of #13892.
@github-actions
github-actionsBot
commented
Sep 7, 2022

Copy link


Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17632
kou
kou
reviewed
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 message(STATUS "Found the Arrow core shared library: ${ARROW_SHARED_LIB}")
 message(STATUS "Found the Arrow core import library: ${ARROW_IMPORT_LIB}")
 message(STATUS "Found the Arrow core static library: ${ARROW_STATIC_LIB}")
endif()
@koukouSep 7, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define a function arrow_show_details(package_name) or something that shows these status messages and use it in all *Config.cmake.in?
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

dhruv9vats
dhruv9vats
commented
Sep 7, 2022
View reviewed changes
Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

@dhruv9vats
dhruv9vats
requested a review
from kouSeptember 7, 2022 12:14
kou
kou
reviewed
Sep 9, 2022
View reviewed changes
Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/ArrowConfig.cmake.in
Outdated

 if(NOT ${PACKAGE_NAME}_FIND_QUIETLY)
 string(TOUPPER ${PACKAGE_NAME} package_name_upper)
 message(STATUS "${PACKAGE_NAME} version: ${${package_name_upper}_VERSION}")
 message(STATUS "Found the ${PACKAGE_NAME} shared library: ${${package_name_upper}_SHARED_LIB}")
@koukouSep 9, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with ArrowDataset?
It seems that we need to pass 2 arguments to this function: arrow_show_details(package_name variable_prefix) (e.g.: arrow_show_details(ArrowDataset ARROW_DATASET))
@dhruv9vatsdhruv9vatsSep 11, 2022•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature now is macro(arrow_show_details package_name variable_prefix), but does it make sense to use target_base_name instead of variable_prefix as in arrow_keep_backward_compatibility, and do something like:
macro(arrow_show_details package_name target_base_name)
string(TOUPPER ${target_base_name} target_base_name_upper)
.
.
.
endmacro()

Comment threadcpp/src/arrow/ArrowTestingConfig.cmake.in
Outdated

Comment threadcpp/src/arrow/flight/ArrowFlightConfig.cmake.in
Outdated

Comment threadpython/pyarrow/src/ArrowPythonConfig.cmake.in
Outdated

kou
kou
approved these changes
Sep 12, 2022
View reviewed changes
@koukou
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
@kou
kou
merged commit 3aee08b
into
apache:masterSep 12, 2022
@ursabot
ursabot
commented
Sep 12, 2022

Copy link


Copy Markdown

Benchmark runs are scheduled for baseline = f42f3df and contender = 3aee08b. 3aee08b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.

Conbench compare runs links:

[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2

[Failed ⬇️0.81% ⬆️0.0%] test-mac-arm

[Failed ⬇️0.0% ⬆️0.28%] ursa-i9-9960x

[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q

Buildkite builds:

[Finished] 3aee08b4 ec2-t3-xlarge-us-east-2

[Finished] 3aee08b4 test-mac-arm

[Failed] 3aee08b4 ursa-i9-9960x

[Finished] 3aee08b4 ursa-thinkcentre-m75q

[Finished] f42f3df0 ec2-t3-xlarge-us-east-2

[Failed] f42f3df0 test-mac-arm

[Failed] f42f3df0 ursa-i9-9960x

[Finished] f42f3df0 ursa-thinkcentre-m75q

Supported benchmarks:

ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True

test-mac-arm: Supported benchmark langs: C++, Python, R

ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript

ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
zagto pushed a commit
to zagto/arrow
that referenced
this pull request
Oct 7, 2022
@dhruv9vats@zagto
ARROW-17632: [Python][C++] Add details of where libarrow is being fou…
e122efe
…nd during build (apache#14059)
This PR aims to add back `message(STATUS ...)` statements that printed some details about Arrow being found, its version, and the paths. These were refactored away as part of apache#13892.
Authored-by: Dhruv Vats <dhruv25vats@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@koukoukou approved these changes

Assignees


No one assigned


Labels

Component: C++Component: FlightRPCComponent: GandivaComponent: ParquetComponent: Python

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@dhruv9vats@ursabot@kou