Skip to content

ARROW-17674: [R] Implement dplyr::across() inside arrange() - #14092

Merged
nealrichardson merged 3 commits into
apache:masterfrom
eitsupi:r-arrange-across
Sep 12, 2022
Merged

ARROW-17674: [R] Implement dplyr::across() inside arrange()#14092
nealrichardson merged 3 commits into
apache:masterfrom
eitsupi:r-arrange-across

Conversation

@eitsupi

@eitsupieitsupi commented Sep 10, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@eitsupi
Implement dplyr::across() inside arrange()
6651b75
Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
@eitsupi
add tests
3667337
Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
@github-actions

github-actionsBot commented Sep 10, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-11699

@eitsupieitsupi changed the title ARROW-11699: [R] Implement dplyr::across() inside arrange()ARROW-17674: [R] Implement dplyr::across() inside arrange()Sep 10, 2022
@github-actions

github-actionsBot commented Sep 10, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-17674

nealrichardson
nealrichardson reviewed Sep 12, 2022
View reviewed changes

@nealrichardsonnealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One question about a possible simplification

Comment threadr/R/dplyr-arrange.R Outdated
@eitsupi
remove unused lines
0cf7585
Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
nealrichardson
nealrichardson approved these changes Sep 12, 2022
View reviewed changes

@nealrichardsonnealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nealrichardson
nealrichardson merged commit 05b7fe3 into apache:masterSep 12, 2022
@eitsupi
eitsupi deleted the r-arrange-across branch September 12, 2022 15:17
@eitsupi

eitsupi commented Sep 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Thank you for merging this.
I hope you see #14090 and #14091 as they relate to this.

@ursabot

ursabot commented Sep 13, 2022

Copy link
Copy Markdown

Benchmark runs are scheduled for baseline = ea382af and contender = 05b7fe3. 05b7fe3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.51% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.28% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 05b7fe35 ec2-t3-xlarge-us-east-2
[Failed] 05b7fe35 test-mac-arm
[Failed] 05b7fe35 ursa-i9-9960x
[Finished] 05b7fe35 ursa-thinkcentre-m75q
[Finished] ea382af7 ec2-t3-xlarge-us-east-2
[Finished] ea382af7 test-mac-arm
[Failed] ea382af7 ursa-i9-9960x
[Finished] ea382af7 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@eitsupi@zagto
ARROW-17674: [R] Implement dplyr::across() inside arrange() (apache#1…
77d6f89
…4092)
Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
This was referenced Sep 14, 2022
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardsonnealrichardsonnealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eitsupi@ursabot@nealrichardson